Skip to content

Speakr is a personal, self-hosted web application designed for transcribing audio recordings

Python

Fix first transcript segment being unclickable: use nullish coalescing so a startTime of 0 survives, in the main app and the share page (fixes #326)

Murtaza Nasir9d2e9c2ed61d
diff --git a/static/js/app.modular.js b/static/js/app.modular.js
index bc763448..e25a88f8 100644
--- a/static/js/app.modular.js
+++ b/static/js/app.modular.js
@@ -2121,7 +2121,7 @@ document.addEventListener('DOMContentLoaded', async () => {
speaker: segment.speaker,
color: segment.color,
speakerId: segment.speakerId,
- startTime: segment.startTime || segment.start_time,
+ startTime: segment.startTime ?? segment.start_time,
runOffset: idx,
segments: []
});
@@ -2148,7 +2148,7 @@ document.addEventListener('DOMContentLoaded', async () => {
}
bubbleRows[bubbleRows.length - 1].bubbles.push({
sentence: segment.sentence,
- startTime: segment.startTime || segment.start_time,
+ startTime: segment.startTime ?? segment.start_time,
color: segment.color
});
});
diff --git a/static/js/modules/composables/ui.js b/static/js/modules/composables/ui.js
index cdf37ee0..d73340b7 100644
--- a/static/js/modules/composables/ui.js
+++ b/static/js/modules/composables/ui.js
@@ -1330,9 +1330,11 @@ export function useUI(state, utils, processedTranscription) {
while (low <= high) {
const mid = Math.floor((low + high) / 2);
- const startTime = segments[mid].startTime || segments[mid].start_time;
+ // Nullish coalescing (??) so a real 0 (the first segment's
+ // startTime) is preserved rather than falling through.
+ const startTime = segments[mid].startTime ?? segments[mid].start_time;
- if (startTime === undefined) {
+ if (startTime === undefined || startTime === null) {
// Skip segments without timing info
high = mid - 1;
continue;
diff --git a/templates/share.html b/templates/share.html
index 9ba03223..2ca71b64 100644
--- a/templates/share.html
+++ b/templates/share.html
@@ -340,7 +340,7 @@
<!-- Simple View -->
<div v-if="transcriptView === 'simple'" class="transcription-simple-view">
<div v-for="(segment, index) in processedTranscription.simpleSegments"
- :key="segment.startTime || Math.random()"
+ :key="segment.startTime ?? Math.random()"
:class="['speaker-segment cursor-pointer hover:bg-[var(--bg-accent-hover)] p-2 rounded transition-colors mb-2', { 'active-playing-segment': currentPlayingSegmentIndex === index }]"
:data-start-time="segment.startTime"
:data-end-time="segment.endTime"
@@ -361,7 +361,7 @@
:key="rowIndex"
:class="['bubble-row', row.isMe ? 'speaker-me' : '']">
<div v-for="(bubble, bubbleIndex) in row.bubbles"
- :key="bubble.startTime || Math.random()"
+ :key="bubble.startTime ?? Math.random()"
:class="['speaker-bubble', bubble.color, row.isMe ? 'speaker-me' : '', 'cursor-pointer', { 'active-playing-segment': currentPlayingSegmentIndex === getBubbleGlobalIndex(rowIndex, bubbleIndex) }]"
:data-start-time="bubble.startTime"
:data-end-time="bubble.endTime"
@@ -678,8 +678,8 @@
speakerId: segment.speaker,
speaker: segment.speaker,
sentence: segment.sentence,
- startTime: segment.start_time || segment.startTime,
- endTime: segment.end_time || segment.endTime,
+ startTime: segment.start_time ?? segment.startTime,
+ endTime: segment.end_time ?? segment.endTime,
color: speakerColors[segment.speaker] || 'speaker-color-1'
}));
@@ -707,8 +707,8 @@
}
bubbleRows[bubbleRows.length - 1].bubbles.push({
sentence: segment.sentence,
- startTime: segment.startTime || segment.start_time,
- endTime: segment.endTime || segment.end_time,
+ startTime: segment.startTime ?? segment.start_time,
+ endTime: segment.endTime ?? segment.end_time,
color: segment.color
});
});