Skip to content

Speakr is a personal, self-hosted web application designed for transcribing audio recordings

Python

fix: clamp hints popover to viewport - shift left at right edge, flip above chip when no room below, scroll when content is tall

Murtaza Nasirb1e64013f09d
diff --git a/static/js/app.modular.js b/static/js/app.modular.js
index 9989a790..7157a696 100644
--- a/static/js/app.modular.js
+++ b/static/js/app.modular.js
@@ -620,6 +620,55 @@ document.addEventListener('DOMContentLoaded', async () => {
// Detail-view popover showing which hotwords/initial-prompt a
// recording actually used (#309).
const showHintsPopover = ref(false);
+ // Inline position overrides for the hints popover. The popover is
+ // anchored `absolute left-0 top-full` to its chip, so when the chip
+ // sits near the right viewport edge (or the prompt text is long)
+ // the panel would clip off-screen. On open we measure and clamp:
+ // shift left to stay inside the right edge, flip above the chip
+ // when there is clearly more room there, and cap height with
+ // internal scrolling otherwise.
+ const hintsPopoverStyle = ref({});
+ const toggleHintsPopover = (event) => {
+ if (showHintsPopover.value) {
+ showHintsPopover.value = false;
+ return;
+ }
+ const btn = event.currentTarget;
+ hintsPopoverStyle.value = {};
+ showHintsPopover.value = true;
+ nextTick(() => {
+ const pop = btn.closest('.relative')?.querySelector('.hints-popover');
+ if (!pop) return;
+ const margin = 8;
+ const rect = pop.getBoundingClientRect();
+ const btnRect = btn.getBoundingClientRect();
+ const style = {};
+
+ const overflowRight = rect.right - (window.innerWidth - margin);
+ if (overflowRight > 0) {
+ // Never shift so far that the left edge leaves the viewport.
+ const shift = Math.min(overflowRight, Math.max(rect.left - margin, 0));
+ style.transform = `translateX(-${Math.round(shift)}px)`;
+ }
+
+ const spaceBelow = window.innerHeight - margin - rect.top;
+ const spaceAbove = btnRect.top - margin;
+ if (rect.height > spaceBelow) {
+ if (spaceBelow < 120 && spaceAbove > spaceBelow) {
+ style.top = 'auto';
+ style.bottom = '100%';
+ style.marginTop = '0';
+ style.marginBottom = '0.25rem';
+ style.maxHeight = `${Math.floor(spaceAbove)}px`;
+ } else {
+ style.maxHeight = `${Math.floor(spaceBelow)}px`;
+ }
+ style.overflowY = 'auto';
+ }
+
+ hintsPopoverStyle.value = style;
+ });
+ };
const uploadTranscriptionModel = ref('');
const uploadPromptVariables = reactive({}); // {variableName: value}
const showPromptVariablesPanel = ref(true); // expander state
@@ -1695,7 +1744,7 @@ document.addEventListener('DOMContentLoaded', async () => {
maxConcurrentUploads, recordingDisclaimer, showRecordingDisclaimerModal, pendingRecordingMode,
uploadDisclaimer, showUploadDisclaimerModal,
customBanner, showBanner,
- showAdvancedOptions, userTranscriptionLanguage, uploadLanguage, uploadMinSpeakers, uploadMaxSpeakers, uploadHotwords, uploadInitialPrompt, initialPromptTemplates, applyInitialPromptTemplate, showHintsPopover, uploadTranscriptionModel, uploadPromptVariables, showPromptVariablesPanel, selectedPromptVariables, reprocessAvailableVariables, transcriptionModelOptions,
+ showAdvancedOptions, userTranscriptionLanguage, uploadLanguage, uploadMinSpeakers, uploadMaxSpeakers, uploadHotwords, uploadInitialPrompt, initialPromptTemplates, applyInitialPromptTemplate, showHintsPopover, hintsPopoverStyle, toggleHintsPopover, uploadTranscriptionModel, uploadPromptVariables, showPromptVariablesPanel, selectedPromptVariables, reprocessAvailableVariables, transcriptionModelOptions,
availableTags, selectedTagIds, uploadTagSearchFilter,
availableFolders, selectedFolderId, foldersEnabled, filterFolder,
diff --git a/templates/components/detail-view.html b/templates/components/detail-view.html
index 07b77b4a..2a383bc9 100644
--- a/templates/components/detail-view.html
+++ b/templates/components/detail-view.html
@@ -124,15 +124,15 @@
<!-- Transcription hints used (#309): click to see the effective
hotwords / initial prompt that steered this transcription. -->
<div v-if="selectedRecording.resolved_hotwords || selectedRecording.resolved_initial_prompt" class="relative">
- <button @click="showHintsPopover = !showHintsPopover"
+ <button @click="toggleHintsPopover($event)"
class="chip-meta chip-meta--clickable"
:title="t('detail.hintsUsed')">
<i class="fas fa-wand-magic-sparkles"></i>
<span>${ t('detail.hints') }</span>
</button>
<div v-if="showHintsPopover" @click="showHintsPopover = false" class="fixed inset-0 z-40"></div>
- <div v-if="showHintsPopover"
- class="absolute left-0 top-full mt-1 z-50 w-72 max-w-[80vw] p-3 bg-[var(--bg-primary)] border border-[var(--border-primary)] rounded-md shadow-lg text-left space-y-2">
+ <div v-if="showHintsPopover" :style="hintsPopoverStyle"
+ class="hints-popover absolute left-0 top-full mt-1 z-50 w-72 max-w-[80vw] p-3 bg-[var(--bg-primary)] border border-[var(--border-primary)] rounded-md shadow-lg text-left space-y-2">
<div v-if="selectedRecording.resolved_hotwords">
<p class="text-[10px] font-semibold uppercase tracking-wide text-[var(--text-muted)]">${ t('form.hotwords') }</p>
<p class="text-xs text-[var(--text-primary)] whitespace-pre-wrap break-words">${ selectedRecording.resolved_hotwords }</p>
diff --git a/templates/components/detail/mobile-header.html b/templates/components/detail/mobile-header.html
index a25d44f6..6a7cb308 100644
--- a/templates/components/detail/mobile-header.html
+++ b/templates/components/detail/mobile-header.html
@@ -150,15 +150,15 @@
<!-- Transcription hints used (#309) -->
<div v-if="selectedRecording.resolved_hotwords || selectedRecording.resolved_initial_prompt" class="relative">
- <button @click.stop="showHintsPopover = !showHintsPopover"
+ <button @click.stop="toggleHintsPopover($event)"
class="chip-meta chip-meta--clickable"
:title="t('detail.hintsUsed')">
<i class="fas fa-wand-magic-sparkles"></i>
<span>${ t('detail.hints') }</span>
</button>
<div v-if="showHintsPopover" @click.stop="showHintsPopover = false" class="fixed inset-0 z-40"></div>
- <div v-if="showHintsPopover"
- class="absolute left-0 top-full mt-1 z-50 w-64 max-w-[80vw] p-3 bg-[var(--bg-primary)] border border-[var(--border-primary)] rounded-md shadow-lg text-left space-y-2">
+ <div v-if="showHintsPopover" :style="hintsPopoverStyle"
+ class="hints-popover absolute left-0 top-full mt-1 z-50 w-64 max-w-[80vw] p-3 bg-[var(--bg-primary)] border border-[var(--border-primary)] rounded-md shadow-lg text-left space-y-2">
<div v-if="selectedRecording.resolved_hotwords">
<p class="text-[10px] font-semibold uppercase tracking-wide text-[var(--text-muted)]">${ t('form.hotwords') }</p>
<p class="text-xs text-[var(--text-primary)] whitespace-pre-wrap break-words">${ selectedRecording.resolved_hotwords }</p>