💫 Toolkit to help you get started with SDD or any other process!
fix(workflows): StepRegistry.add tolerates a corrupted non-dict existing entry (#3630)
Ali jawwad03f9013a7b2a
diff --git a/src/specify_cli/workflows/catalog.py b/src/specify_cli/workflows/catalog.pyindex 082189a17..63ddc7639 100644--- a/src/specify_cli/workflows/catalog.py+++ b/src/specify_cli/workflows/catalog.py@@ -894,7 +894,11 @@ class StepRegistry:import copyfrom datetime import datetime, timezone- existing = self.data["steps"].get(step_id, {})+ raw_existing = self.data["steps"].get(step_id)+ # Corrupted-but-parseable registries may hold non-dict entries; treat+ # them as absent rather than crashing on existing.get() (mirrors+ # WorkflowRegistry.add).+ existing = raw_existing if isinstance(raw_existing, dict) else {}metadata_to_store = copy.deepcopy(metadata)metadata_to_store["installed_at"] = existing.get("installed_at", datetime.now(timezone.utc).isoformat()diff --git a/tests/test_workflows.py b/tests/test_workflows.pyindex c51df1934..0af0fae85 100644--- a/tests/test_workflows.py+++ b/tests/test_workflows.py@@ -10015,6 +10015,17 @@ steps:registry.add("align-wf", {"version": "1.0.0", "source": "catalog"})assert registry.get("align-wf")["version"] == "1.0.0"+ def test_step_registry_add_survives_non_dict_existing_entry(self, project_dir):+ """StepRegistry.add must treat a corrupted non-dict existing entry as+ absent rather than crash on existing.get() (parity with+ WorkflowRegistry.add)."""+ from specify_cli.workflows.catalog import StepRegistry++ registry = StepRegistry(project_dir)+ registry.data["steps"]["my-step"] = "corrupted"+ registry.add("my-step", {"version": "1.0.0"})+ assert registry.get("my-step")["version"] == "1.0.0"+@pytest.mark.parametrize("contents",[