💫 Toolkit to help you get started with SDD or any other process!
fix(workflows): harden community submission workflows (#4510)
Manfred Riem2ec981f7a6d6
diff --git a/.github/workflows/add-community-bundle.lock.yml b/.github/workflows/add-community-bundle.lock.ymlindex 5e277febf..9473e5e42 100644--- a/.github/workflows/add-community-bundle.lock.yml+++ b/.github/workflows/add-community-bundle.lock.yml@@ -1,4 +1,4 @@-# gh-aw-metadata: {"schema_version":"v4","frontmatter_hash":"c64e3dc29aca89e48108bb6d4eb877f6264b4cec9cd56dcd36827893802d2a64","body_hash":"cade22e5083254b735200f4ff7d686104e4ccab848ff7355141b9689354834db","compiler_version":"v0.79.8","strict":true,"agent_id":"copilot","engine_versions":{"copilot":"1.0.60"}}+# gh-aw-metadata: {"schema_version":"v4","frontmatter_hash":"e5175ffebd1e7d54595b73aa83d4e8c1275b01ddca1eda67a6df3713e34d99d4","body_hash":"cade22e5083254b735200f4ff7d686104e4ccab848ff7355141b9689354834db","compiler_version":"v0.79.8","strict":true,"agent_id":"copilot","engine_versions":{"copilot":"1.0.60"}}# gh-aw-manifest: {"version":1,"secrets":["COPILOT_GITHUB_TOKEN","GH_AW_CI_TRIGGER_TOKEN","GH_AW_GITHUB_MCP_SERVER_TOKEN","GH_AW_GITHUB_TOKEN","GITHUB_TOKEN"],"actions":[{"repo":"actions/checkout","sha":"3d3c42e5aac5ba805825da76410c181273ba90b1","version":"v7.0.1"},{"repo":"actions/download-artifact","sha":"3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c","version":"v8.0.1"},{"repo":"actions/github-script","sha":"3a2844b7e9c422d3c10d287c895573f7108da1b3","version":"v9.0.0"},{"repo":"actions/setup-node","sha":"820762786026740c76f36085b0efc47a31fe5020","version":"v7.0.0"},{"repo":"actions/upload-artifact","sha":"043fb46d1a93c77aae656e7c1c64a875d1fc6a0a","version":"v7.0.1"},{"repo":"github/gh-aw-actions/setup","sha":"c0338fef4749d08c21f8f975fb0e37efa17dda47","version":"v0.79.8"}],"containers":[{"image":"ghcr.io/github/gh-aw-firewall/agent:0.27.2","digest":"sha256:f88e5b17b6b7a600117bc121114d6ce2155c88c983c0c939c5df884f730fa1d6","pinned_image":"ghcr.io/github/gh-aw-firewall/agent:0.27.2@sha256:f88e5b17b6b7a600117bc121114d6ce2155c88c983c0c939c5df884f730fa1d6"},{"image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.2","digest":"sha256:ee39841d980878ebbb87592903b06d31a1af500c71525c9616f7e8e2a27041a4","pinned_image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.2@sha256:ee39841d980878ebbb87592903b06d31a1af500c71525c9616f7e8e2a27041a4"},{"image":"ghcr.io/github/gh-aw-firewall/squid:0.27.2","digest":"sha256:2e3a717e5f19a654cd9a2263beb52012b56bcb68562ec5ae2e42f9d156b49591","pinned_image":"ghcr.io/github/gh-aw-firewall/squid:0.27.2@sha256:2e3a717e5f19a654cd9a2263beb52012b56bcb68562ec5ae2e42f9d156b49591"},{"image":"ghcr.io/github/gh-aw-mcpg:v0.3.25","digest":"sha256:c10331ad17668ef89f38f5e356678788a40b0cd5fef96e8f92e1d9c1de47cbaa","pinned_image":"ghcr.io/github/gh-aw-mcpg:v0.3.25@sha256:c10331ad17668ef89f38f5e356678788a40b0cd5fef96e8f92e1d9c1de47cbaa"},{"image":"ghcr.io/github/github-mcp-server:v1.1.2","digest":"sha256:30197479d8036c7811892bc07e06f9a05c9ef3cdd79bc59f256d50647f95788c","pinned_image":"ghcr.io/github/github-mcp-server:v1.1.2@sha256:30197479d8036c7811892bc07e06f9a05c9ef3cdd79bc59f256d50647f95788c"}]}# This file was automatically generated by gh-aw (v0.79.8). DO NOT EDIT. To debug this workflow, load the skill at https://github.com/github/gh-aw/blob/main/debug.md#@@ -1514,12 +1514,11 @@ jobs:- name: Parse and conclude threat detectionid: detection_conclusionif: always()- continue-on-error: trueuses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0env:RUN_DETECTION: ${{ steps.detection_guard.outputs.run_detection }}DETECTION_AGENTIC_EXECUTION_OUTCOME: ${{ steps.detection_agentic_execution.outcome }}- GH_AW_DETECTION_CONTINUE_ON_ERROR: "true"+ GH_AW_DETECTION_CONTINUE_ON_ERROR: "false"with:script: |try {diff --git a/.github/workflows/add-community-bundle.md b/.github/workflows/add-community-bundle.mdindex fbb9b7b2d..1f6d68c60 100644--- a/.github/workflows/add-community-bundle.md+++ b/.github/workflows/add-community-bundle.md@@ -26,6 +26,8 @@ checkout:safe-outputs:noop:report-as-issue: false+ threat-detection:+ continue-on-error: falsecreate-pull-request:title-prefix: "[bundle] "labels: [bundle-submission, automated]diff --git a/.github/workflows/add-community-extension.lock.yml b/.github/workflows/add-community-extension.lock.ymlindex 208585254..8de39f091 100644--- a/.github/workflows/add-community-extension.lock.yml+++ b/.github/workflows/add-community-extension.lock.yml@@ -1,4 +1,4 @@-# gh-aw-metadata: {"schema_version":"v4","frontmatter_hash":"f9532e77722bfd32e8f626cbfbf6c5372ddcd9997963d965d53e8531b3e28a15","body_hash":"83b7e917f475d6ddf32f17e7da09dd4097a01dddbcbbf8eeec673912285de8b2","compiler_version":"v0.79.8","strict":true,"agent_id":"copilot","engine_versions":{"copilot":"1.0.60"}}+# gh-aw-metadata: {"schema_version":"v4","frontmatter_hash":"bf4bb9600475cf7ec1cd2aaf573ce6b2c11f644db0376c30d5b6926dd06d78b1","body_hash":"83b7e917f475d6ddf32f17e7da09dd4097a01dddbcbbf8eeec673912285de8b2","compiler_version":"v0.79.8","strict":true,"agent_id":"copilot","engine_versions":{"copilot":"1.0.60"}}# gh-aw-manifest: {"version":1,"secrets":["COPILOT_GITHUB_TOKEN","GH_AW_CI_TRIGGER_TOKEN","GH_AW_GITHUB_MCP_SERVER_TOKEN","GH_AW_GITHUB_TOKEN","GITHUB_TOKEN"],"actions":[{"repo":"actions/checkout","sha":"3d3c42e5aac5ba805825da76410c181273ba90b1","version":"v7.0.1"},{"repo":"actions/download-artifact","sha":"3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c","version":"v8.0.1"},{"repo":"actions/github-script","sha":"3a2844b7e9c422d3c10d287c895573f7108da1b3","version":"v9.0.0"},{"repo":"actions/setup-node","sha":"820762786026740c76f36085b0efc47a31fe5020","version":"v7.0.0"},{"repo":"actions/upload-artifact","sha":"043fb46d1a93c77aae656e7c1c64a875d1fc6a0a","version":"v7.0.1"},{"repo":"github/gh-aw-actions/setup","sha":"c0338fef4749d08c21f8f975fb0e37efa17dda47","version":"v0.79.8"}],"containers":[{"image":"ghcr.io/github/gh-aw-firewall/agent:0.27.2","digest":"sha256:f88e5b17b6b7a600117bc121114d6ce2155c88c983c0c939c5df884f730fa1d6","pinned_image":"ghcr.io/github/gh-aw-firewall/agent:0.27.2@sha256:f88e5b17b6b7a600117bc121114d6ce2155c88c983c0c939c5df884f730fa1d6"},{"image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.2","digest":"sha256:ee39841d980878ebbb87592903b06d31a1af500c71525c9616f7e8e2a27041a4","pinned_image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.2@sha256:ee39841d980878ebbb87592903b06d31a1af500c71525c9616f7e8e2a27041a4"},{"image":"ghcr.io/github/gh-aw-firewall/squid:0.27.2","digest":"sha256:2e3a717e5f19a654cd9a2263beb52012b56bcb68562ec5ae2e42f9d156b49591","pinned_image":"ghcr.io/github/gh-aw-firewall/squid:0.27.2@sha256:2e3a717e5f19a654cd9a2263beb52012b56bcb68562ec5ae2e42f9d156b49591"},{"image":"ghcr.io/github/gh-aw-mcpg:v0.3.25","digest":"sha256:c10331ad17668ef89f38f5e356678788a40b0cd5fef96e8f92e1d9c1de47cbaa","pinned_image":"ghcr.io/github/gh-aw-mcpg:v0.3.25@sha256:c10331ad17668ef89f38f5e356678788a40b0cd5fef96e8f92e1d9c1de47cbaa"},{"image":"ghcr.io/github/github-mcp-server:v1.1.2","digest":"sha256:30197479d8036c7811892bc07e06f9a05c9ef3cdd79bc59f256d50647f95788c","pinned_image":"ghcr.io/github/github-mcp-server:v1.1.2@sha256:30197479d8036c7811892bc07e06f9a05c9ef3cdd79bc59f256d50647f95788c"}]}# This file was automatically generated by gh-aw (v0.79.8). DO NOT EDIT. To debug this workflow, load the skill at https://github.com/github/gh-aw/blob/main/debug.md#@@ -1494,12 +1494,11 @@ jobs:- name: Parse and conclude threat detectionid: detection_conclusionif: always()- continue-on-error: trueuses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0env:RUN_DETECTION: ${{ steps.detection_guard.outputs.run_detection }}DETECTION_AGENTIC_EXECUTION_OUTCOME: ${{ steps.detection_agentic_execution.outcome }}- GH_AW_DETECTION_CONTINUE_ON_ERROR: "true"+ GH_AW_DETECTION_CONTINUE_ON_ERROR: "false"with:script: |try {diff --git a/.github/workflows/add-community-extension.md b/.github/workflows/add-community-extension.mdindex 9d6f7db2a..c59f20dda 100644--- a/.github/workflows/add-community-extension.md+++ b/.github/workflows/add-community-extension.md@@ -26,6 +26,8 @@ checkout:safe-outputs:noop:report-as-issue: false+ threat-detection:+ continue-on-error: falsecreate-pull-request:title-prefix: "[extension] "labels: [extension-submission, automated]diff --git a/.github/workflows/add-community-preset.lock.yml b/.github/workflows/add-community-preset.lock.ymlindex 97a113d3a..8329c9d91 100644--- a/.github/workflows/add-community-preset.lock.yml+++ b/.github/workflows/add-community-preset.lock.yml@@ -1,4 +1,4 @@-# gh-aw-metadata: {"schema_version":"v4","frontmatter_hash":"09fb89e95c57c7beeaa0c823fb35f38d5f9db898a419e59dd0a323e7a9209753","body_hash":"cb6c19088fa13da0a8320c174e8c14c4887d2c8a005a5cb2d2d2faa3f890de39","compiler_version":"v0.79.8","strict":true,"agent_id":"copilot","engine_versions":{"copilot":"1.0.60"}}+# gh-aw-metadata: {"schema_version":"v4","frontmatter_hash":"1efd167841504436c44dd8e18cf8b1771eda1324272d53b89bd09897bb0f04c8","body_hash":"cb6c19088fa13da0a8320c174e8c14c4887d2c8a005a5cb2d2d2faa3f890de39","compiler_version":"v0.79.8","strict":true,"agent_id":"copilot","engine_versions":{"copilot":"1.0.60"}}# gh-aw-manifest: {"version":1,"secrets":["COPILOT_GITHUB_TOKEN","GH_AW_CI_TRIGGER_TOKEN","GH_AW_GITHUB_MCP_SERVER_TOKEN","GH_AW_GITHUB_TOKEN","GITHUB_TOKEN"],"actions":[{"repo":"actions/checkout","sha":"3d3c42e5aac5ba805825da76410c181273ba90b1","version":"v7.0.1"},{"repo":"actions/download-artifact","sha":"3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c","version":"v8.0.1"},{"repo":"actions/github-script","sha":"3a2844b7e9c422d3c10d287c895573f7108da1b3","version":"v9.0.0"},{"repo":"actions/setup-node","sha":"820762786026740c76f36085b0efc47a31fe5020","version":"v7.0.0"},{"repo":"actions/upload-artifact","sha":"043fb46d1a93c77aae656e7c1c64a875d1fc6a0a","version":"v7.0.1"},{"repo":"github/gh-aw-actions/setup","sha":"c0338fef4749d08c21f8f975fb0e37efa17dda47","version":"v0.79.8"}],"containers":[{"image":"ghcr.io/github/gh-aw-firewall/agent:0.27.2","digest":"sha256:f88e5b17b6b7a600117bc121114d6ce2155c88c983c0c939c5df884f730fa1d6","pinned_image":"ghcr.io/github/gh-aw-firewall/agent:0.27.2@sha256:f88e5b17b6b7a600117bc121114d6ce2155c88c983c0c939c5df884f730fa1d6"},{"image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.2","digest":"sha256:ee39841d980878ebbb87592903b06d31a1af500c71525c9616f7e8e2a27041a4","pinned_image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.2@sha256:ee39841d980878ebbb87592903b06d31a1af500c71525c9616f7e8e2a27041a4"},{"image":"ghcr.io/github/gh-aw-firewall/squid:0.27.2","digest":"sha256:2e3a717e5f19a654cd9a2263beb52012b56bcb68562ec5ae2e42f9d156b49591","pinned_image":"ghcr.io/github/gh-aw-firewall/squid:0.27.2@sha256:2e3a717e5f19a654cd9a2263beb52012b56bcb68562ec5ae2e42f9d156b49591"},{"image":"ghcr.io/github/gh-aw-mcpg:v0.3.25","digest":"sha256:c10331ad17668ef89f38f5e356678788a40b0cd5fef96e8f92e1d9c1de47cbaa","pinned_image":"ghcr.io/github/gh-aw-mcpg:v0.3.25@sha256:c10331ad17668ef89f38f5e356678788a40b0cd5fef96e8f92e1d9c1de47cbaa"},{"image":"ghcr.io/github/github-mcp-server:v1.1.2","digest":"sha256:30197479d8036c7811892bc07e06f9a05c9ef3cdd79bc59f256d50647f95788c","pinned_image":"ghcr.io/github/github-mcp-server:v1.1.2@sha256:30197479d8036c7811892bc07e06f9a05c9ef3cdd79bc59f256d50647f95788c"}]}# This file was automatically generated by gh-aw (v0.79.8). DO NOT EDIT. To debug this workflow, load the skill at https://github.com/github/gh-aw/blob/main/debug.md#@@ -1494,12 +1494,11 @@ jobs:- name: Parse and conclude threat detectionid: detection_conclusionif: always()- continue-on-error: trueuses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0env:RUN_DETECTION: ${{ steps.detection_guard.outputs.run_detection }}DETECTION_AGENTIC_EXECUTION_OUTCOME: ${{ steps.detection_agentic_execution.outcome }}- GH_AW_DETECTION_CONTINUE_ON_ERROR: "true"+ GH_AW_DETECTION_CONTINUE_ON_ERROR: "false"with:script: |try {diff --git a/.github/workflows/add-community-preset.md b/.github/workflows/add-community-preset.mdindex 16930bc57..f93dbef0f 100644--- a/.github/workflows/add-community-preset.md+++ b/.github/workflows/add-community-preset.md@@ -26,6 +26,8 @@ checkout:safe-outputs:noop:report-as-issue: false+ threat-detection:+ continue-on-error: falsecreate-pull-request:title-prefix: "[preset] "labels: [preset-submission, automated]diff --git a/tests/test_github_workflows.py b/tests/test_github_workflows.pyindex 00be8b8ec..dd5abef34 100644--- a/tests/test_github_workflows.py+++ b/tests/test_github_workflows.py@@ -279,6 +279,48 @@ def test_community_submission_allowed_files_do_not_include_other_catalogs_or_doc)+def _frontmatter(source_text: str) -> dict:+ if not source_text.startswith("---"):+ raise AssertionError("workflow source is missing YAML frontmatter")+ _, frontmatter, _ = source_text.split("---", 2)+ return yaml.safe_load(frontmatter)+++def test_community_submission_threat_detection_is_fail_closed():+ for workflow, *_ in COMMUNITY_SUBMISSION_WORKFLOWS:+ source = WORKFLOWS_DIR / f"add-community-{workflow}.md"+ compiled = WORKFLOWS_DIR / f"add-community-{workflow}.lock.yml"++ assert source.is_file()+ assert compiled.is_file()++ safe_outputs = _frontmatter(source.read_text(encoding="utf-8")).get(+ "safe-outputs", {}+ )+ threat_detection = safe_outputs.get("threat-detection")+ assert threat_detection is not None, (+ f"add-community-{workflow}.md must configure "+ "safe-outputs.threat-detection"+ )+ assert threat_detection.get("continue-on-error") is False, (+ f"add-community-{workflow}.md must set threat-detection "+ "continue-on-error: false so detections block safe outputs"+ )++ compiled_text = compiled.read_text(encoding="utf-8")+ assert 'GH_AW_DETECTION_CONTINUE_ON_ERROR: "false"' in compiled_text, (+ f"add-community-{workflow}.lock.yml must compile threat detection "+ "in fail-closed mode"+ )+ assert (+ "process.env.GH_AW_DETECTION_CONTINUE_ON_ERROR !== 'false'"+ in compiled_text+ ), (+ f"add-community-{workflow}.lock.yml is missing the detection "+ "continue-on-error gate"+ )++def test_bug_test_workflow_provisions_python_dependencies():source = WORKFLOWS_DIR / "bug-test.md"compiled = WORKFLOWS_DIR / "bug-test.lock.yml"