Skip to content

πŸ’« Toolkit to help you get started with SDD or any other process!

fix(presets): seed constitution from preset constitution-template (#3272) (#3276)

Ben Buttigieg353851e9663d
diff --git a/src/specify_cli/commands/init.py b/src/specify_cli/commands/init.py
index 9eb830288..b5503e517 100644
--- a/src/specify_cli/commands/init.py
+++ b/src/specify_cli/commands/init.py
@@ -33,11 +33,17 @@ def _stdin_is_interactive() -> bool:
def ensure_constitution_from_template(
project_path: Path, tracker: StepTracker | None = None
) -> None:
- """Copy constitution template to memory if it doesn't exist."""
+ """Materialize the resolved constitution template to memory if missing.
+
+ Resolution walks the full priority stack (project overrides β†’ installed
+ presets β†’ extensions β†’ core) via :class:`PresetResolver`, so a preset that
+ ships a ``constitution-template`` (e.g. ``strategy: replace`` with a ratified
+ constitution) can seed the memory file. When nothing overrides it, the
+ resolver falls through to the core template.
+ """
+ from ..presets import _materialize_constitution_template
+
memory_constitution = project_path / ".specify" / "memory" / "constitution.md"
- template_constitution = (
- project_path / ".specify" / "templates" / "constitution-template.md"
- )
if memory_constitution.exists():
if tracker:
@@ -45,18 +51,21 @@ def ensure_constitution_from_template(
tracker.skip("constitution", "existing file preserved")
return
- if not template_constitution.exists():
- if tracker:
- tracker.add("constitution", "Constitution setup")
- tracker.error("constitution", "template not found")
- return
-
try:
- memory_constitution.parent.mkdir(parents=True, exist_ok=True)
- shutil.copy2(template_constitution, memory_constitution)
+ materialization = _materialize_constitution_template(
+ project_path, memory_constitution
+ )
+ if materialization is None:
+ if tracker:
+ tracker.add("constitution", "Constitution setup")
+ tracker.error("constitution", "template not found")
+ return
if tracker:
tracker.add("constitution", "Constitution setup")
- tracker.complete("constitution", "copied from template")
+ if materialization == "copied":
+ tracker.complete("constitution", "copied from template")
+ else:
+ tracker.complete("constitution", "composed from template")
else:
console.print("[cyan]Initialized constitution from template[/cyan]")
except Exception as e:
@@ -476,8 +485,6 @@ def register(app: typer.Typer) -> None:
"shared-infra", f"scripts ({selected_script}) + templates"
)
- ensure_constitution_from_template(project_path, tracker=tracker)
-
try:
bundled_wf = _locate_bundled_workflow("speckit")
if bundled_wf:
@@ -605,6 +612,11 @@ def register(app: typer.Typer) -> None:
continuing="Continuing without the optional preset.",
)
+ # Seed the constitution AFTER preset installation so that a
+ # preset-provided constitution-template (resolved via the
+ # priority stack) wins over the core template.
+ ensure_constitution_from_template(project_path, tracker=tracker)
+
tracker.complete("final", "project ready")
except (typer.Exit, SystemExit):
raise
diff --git a/src/specify_cli/presets/__init__.py b/src/specify_cli/presets/__init__.py
index 0f662a72a..98bba08fd 100644
--- a/src/specify_cli/presets/__init__.py
+++ b/src/specify_cli/presets/__init__.py
@@ -31,7 +31,117 @@ from ..extensions import REINSTALL_COMMAND, ExtensionRegistry, normalize_priorit
from .._init_options import is_ai_skills_enabled
from ..integrations.base import IntegrationBase
from .._utils import dump_frontmatter, version_satisfies
-from ..shared_infra import verify_archive_sha256
+from ..shared_infra import (
+ _ensure_safe_shared_destination,
+ _ensure_safe_shared_directory,
+ _write_shared_bytes,
+ _write_shared_text,
+ verify_archive_sha256,
+)
+
+
+_CONSTITUTION_PROVENANCE_FILE = ".constitution-template.json"
+
+
+def _content_sha256(content: bytes) -> str:
+ return hashlib.sha256(content).hexdigest()
+
+
+def _constitution_is_generated(
+ project_root: Path,
+ memory_constitution: Path,
+ resolver: "PresetResolver",
+) -> bool:
+ """Return whether the live constitution is an unchanged generated file."""
+ _ensure_safe_shared_destination(project_root, memory_constitution)
+ content = memory_constitution.read_bytes()
+ provenance = memory_constitution.parent / _CONSTITUTION_PROVENANCE_FILE
+ _ensure_safe_shared_destination(project_root, provenance)
+
+ if provenance.exists():
+ try:
+ metadata = json.loads(provenance.read_text(encoding="utf-8"))
+ except (json.JSONDecodeError, UnicodeDecodeError):
+ return False
+ return (
+ isinstance(metadata, dict)
+ and metadata.get("sha256") == _content_sha256(content)
+ )
+
+ # Older projects have no provenance sidecar. Only the immutable bundled or
+ # source-checkout core template is safe to treat as generated.
+ core = resolver._find_bundled_core(
+ "constitution-template", "template", ".md"
+ )
+ return core is not None and core.read_bytes() == content
+
+
+def _constitution_provenance_matches_preset(
+ project_root: Path,
+ memory_constitution: Path,
+ pack_id: str,
+ pack_version: str,
+) -> bool:
+ """Return whether provenance identifies a preset as the materialized source."""
+ provenance = memory_constitution.parent / _CONSTITUTION_PROVENANCE_FILE
+ if not provenance.parent.exists():
+ return False
+ _ensure_safe_shared_destination(project_root, provenance)
+ if not provenance.exists():
+ return False
+ try:
+ metadata = json.loads(provenance.read_text(encoding="utf-8"))
+ except (json.JSONDecodeError, UnicodeDecodeError):
+ return False
+ return (
+ isinstance(metadata, dict)
+ and metadata.get("source") == f"{pack_id} v{pack_version}"
+ )
+
+
+def _materialize_constitution_template(
+ project_root: Path,
+ memory_constitution: Path,
+) -> str | None:
+ """Materialize constitution-template content into memory/constitution.md.
+
+ Returns:
+ "copied" when the winning layer is ``replace`` and the source file is
+ copied verbatim; "composed" when a composing strategy is materialized
+ via ``resolve_content``; ``None`` when no constitution template resolves.
+ """
+ resolver = PresetResolver(project_root)
+ layers = resolver.collect_all_layers("constitution-template", "template")
+ if not layers:
+ return None
+
+ top_layer = layers[0]
+ if top_layer["strategy"] == "replace":
+ content = top_layer["path"].read_bytes()
+ result = "copied"
+ else:
+ composed_content = resolver.resolve_content("constitution-template", "template")
+ if composed_content is None:
+ return None
+ content = composed_content.encode("utf-8")
+ result = "composed"
+
+ _ensure_safe_shared_directory(project_root, memory_constitution.parent)
+ _write_shared_bytes(project_root, memory_constitution, content)
+ provenance = memory_constitution.parent / _CONSTITUTION_PROVENANCE_FILE
+ _write_shared_text(
+ project_root,
+ provenance,
+ json.dumps(
+ {
+ "sha256": _content_sha256(content),
+ "source": top_layer["source"],
+ },
+ indent=2,
+ )
+ + "\n",
+ )
+ return result
def _substitute_core_template(
@@ -1629,8 +1739,73 @@ class PresetManager:
stacklevel=2,
)
+ # Seed/re-seed memory/constitution.md from a preset-provided
+ # constitution-template. The constitution is the only template that is
+ # materialized to a live file rather than resolved on demand, so a
+ # preset that ships one (e.g. strategy: replace with a ratified
+ # constitution) must be propagated here. Guard against clobbering an
+ # already-authored constitution by only replacing a file whose recorded
+ # hash (or exact legacy core-template content) proves it was generated.
+ self._seed_constitution_from_preset(manifest, dest_dir)
+
return manifest
+ def _seed_constitution_from_preset(
+ self, manifest: PresetManifest, preset_dir: Path
+ ) -> None:
+ """Seed memory/constitution.md from a preset constitution-template.
+
+ Only runs when the preset declares a ``type: template`` entry named
+ ``constitution-template`` or provides one at a convention path, and the
+ live memory file is either missing or is an unchanged generated file.
+ Authored constitutions are never overwritten.
+ """
+ provides_constitution = any(
+ t.get("type") == "template" and t.get("name") == "constitution-template"
+ for t in manifest.templates
+ ) or any(
+ (preset_dir / relative_path).is_file()
+ for relative_path in (
+ "templates/constitution-template.md",
+ "constitution-template.md",
+ )
+ )
+ if not provides_constitution:
+ return
+
+ self.reconcile_constitution(
+ f"Failed to seed constitution from preset {manifest.id}",
+ create_if_missing=True,
+ )
+
+ def reconcile_constitution(
+ self, failure_context: str, *, create_if_missing: bool = False
+ ) -> None:
+ """Reconcile generated constitution content without failing a persisted change."""
+ try:
+ self._reconcile_constitution(create_if_missing=create_if_missing)
+ except (OSError, UnicodeDecodeError, PresetValidationError, ValueError) as exc:
+ import warnings
+
+ warnings.warn(
+ f"{failure_context}: {exc}.",
+ stacklevel=2,
+ )
+
+ def _reconcile_constitution(self, *, create_if_missing: bool = False) -> None:
+ """Materialize the winning constitution layer when the live file is generated."""
+ memory_constitution = (
+ self.project_root / ".specify" / "memory" / "constitution.md"
+ )
+ if not memory_constitution.exists() and not create_if_missing:
+ return
+ resolver = PresetResolver(self.project_root)
+ if memory_constitution.exists() and not _constitution_is_generated(
+ self.project_root, memory_constitution, resolver
+ ):
+ return
+ _materialize_constitution_template(self.project_root, memory_constitution)
+
def install_from_zip(
self,
zip_path: Path,
@@ -1710,6 +1885,25 @@ class PresetManager:
# Also include aliases from the manifest as a safety net for registries
# populated by older versions that may not track aliases.
removed_cmd_names = set()
+ removed_constitution = any(
+ path.exists()
+ for path in (
+ pack_dir / "templates" / "constitution-template.md",
+ pack_dir / "constitution-template.md",
+ )
+ )
+ if metadata and isinstance(metadata.get("version"), str):
+ memory_constitution = (
+ self.project_root / ".specify" / "memory" / "constitution.md"
+ )
+ removed_constitution = removed_constitution or (
+ _constitution_provenance_matches_preset(
+ self.project_root,
+ memory_constitution,
+ pack_id,
+ metadata["version"],
+ )
+ )
for cmd_names in registered_commands.values():
removed_cmd_names.update(cmd_names)
manifest_path = pack_dir / "preset.yml"
@@ -1717,6 +1911,11 @@ class PresetManager:
try:
manifest = PresetManifest(manifest_path)
for tmpl in manifest.templates:
+ if (
+ tmpl.get("type") == "template"
+ and tmpl.get("name") == "constitution-template"
+ ):
+ removed_constitution = True
if tmpl.get("type") == "command":
for alias in tmpl.get("aliases", []):
if isinstance(alias, str):
@@ -1763,6 +1962,18 @@ class PresetManager:
stacklevel=2,
)
+ if removed_constitution:
+ try:
+ self._reconcile_constitution()
+ except (OSError, UnicodeDecodeError, PresetValidationError, ValueError) as exc:
+ import warnings
+
+ warnings.warn(
+ f"Post-removal constitution reconciliation failed for {pack_id}: "
+ f"{exc}. The live constitution may be stale.",
+ stacklevel=2,
+ )
+
return True
def list_installed(self) -> List[Dict[str, Any]]:
diff --git a/src/specify_cli/presets/_commands.py b/src/specify_cli/presets/_commands.py
index 0c5632358..44402831e 100644
--- a/src/specify_cli/presets/_commands.py
+++ b/src/specify_cli/presets/_commands.py
@@ -484,6 +484,9 @@ def preset_set_priority(
# Update priority
manager.registry.update(preset_id, {"priority": priority})
+ manager.reconcile_constitution(
+ f"Failed to reconcile constitution after changing priority for preset {preset_id}"
+ )
console.print(f"[green]βœ“[/green] Preset '{preset_id}' priority changed: {old_priority} β†’ {priority}")
console.print("\n[dim]Lower priority = higher precedence in template resolution[/dim]")
@@ -517,6 +520,9 @@ def preset_enable(
# Enable the preset
manager.registry.update(preset_id, {"enabled": True})
+ manager.reconcile_constitution(
+ f"Failed to reconcile constitution after enabling preset {preset_id}"
+ )
console.print(f"[green]βœ“[/green] Preset '{preset_id}' enabled")
console.print("\nTemplates from this preset will now be included in resolution.")
@@ -551,6 +557,9 @@ def preset_disable(
# Disable the preset
manager.registry.update(preset_id, {"enabled": False})
+ manager.reconcile_constitution(
+ f"Failed to reconcile constitution after disabling preset {preset_id}"
+ )
console.print(f"[green]βœ“[/green] Preset '{preset_id}' disabled")
console.print("\nTemplates from this preset will be skipped during resolution.")
diff --git a/tests/integrations/test_integration_base_markdown.py b/tests/integrations/test_integration_base_markdown.py
index 886dfb912..aa906c440 100644
--- a/tests/integrations/test_integration_base_markdown.py
+++ b/tests/integrations/test_integration_base_markdown.py
@@ -253,6 +253,7 @@ class MarkdownIntegrationTests:
"spec-template.md", "tasks-template.md"]:
files.append(f".specify/templates/{name}")
+ files.append(".specify/memory/.constitution-template.json")
files.append(".specify/memory/constitution.md")
# Bundled workflow
files.append(".specify/workflows/speckit/workflow.yml")
diff --git a/tests/integrations/test_integration_base_skills.py b/tests/integrations/test_integration_base_skills.py
index d88b78675..79c6d3fb5 100644
--- a/tests/integrations/test_integration_base_skills.py
+++ b/tests/integrations/test_integration_base_skills.py
@@ -399,6 +399,7 @@ class SkillsIntegrationTests:
".specify/integration.json",
f".specify/integrations/{self.KEY}.manifest.json",
".specify/integrations/speckit.manifest.json",
+ ".specify/memory/.constitution-template.json",
".specify/memory/constitution.md",
]
# Script variant
diff --git a/tests/integrations/test_integration_base_toml.py b/tests/integrations/test_integration_base_toml.py
index 37bad8a60..8a7344e4b 100644
--- a/tests/integrations/test_integration_base_toml.py
+++ b/tests/integrations/test_integration_base_toml.py
@@ -517,6 +517,7 @@ class TomlIntegrationTests:
]:
files.append(f".specify/templates/{name}")
+ files.append(".specify/memory/.constitution-template.json")
files.append(".specify/memory/constitution.md")
# Bundled workflow
files.append(".specify/workflows/speckit/workflow.yml")
diff --git a/tests/integrations/test_integration_base_yaml.py b/tests/integrations/test_integration_base_yaml.py
index a3968384f..f3e39b24f 100644
--- a/tests/integrations/test_integration_base_yaml.py
+++ b/tests/integrations/test_integration_base_yaml.py
@@ -431,6 +431,7 @@ class YamlIntegrationTests:
]:
files.append(f".specify/templates/{name}")
+ files.append(".specify/memory/.constitution-template.json")
files.append(".specify/memory/constitution.md")
# Bundled workflow
files.append(".specify/workflows/speckit/workflow.yml")
diff --git a/tests/integrations/test_integration_cline.py b/tests/integrations/test_integration_cline.py
index 7475b5ad0..f1abdedc8 100644
--- a/tests/integrations/test_integration_cline.py
+++ b/tests/integrations/test_integration_cline.py
@@ -214,6 +214,7 @@ class TestClineIntegration(MarkdownIntegrationTests):
]:
files.append(f".specify/templates/{name}")
+ files.append(".specify/memory/.constitution-template.json")
files.append(".specify/memory/constitution.md")
# Bundled workflow
files.append(".specify/workflows/speckit/workflow.yml")
diff --git a/tests/integrations/test_integration_copilot.py b/tests/integrations/test_integration_copilot.py
index 41261ba1c..5b3a5712a 100644
--- a/tests/integrations/test_integration_copilot.py
+++ b/tests/integrations/test_integration_copilot.py
@@ -252,6 +252,7 @@ class TestCopilotIntegration:
".specify/templates/plan-template.md",
".specify/templates/spec-template.md",
".specify/templates/tasks-template.md",
+ ".specify/memory/.constitution-template.json",
".specify/memory/constitution.md",
".specify/workflows/speckit/workflow.yml",
".specify/workflows/workflow-registry.json",
@@ -313,6 +314,7 @@ class TestCopilotIntegration:
".specify/templates/plan-template.md",
".specify/templates/spec-template.md",
".specify/templates/tasks-template.md",
+ ".specify/memory/.constitution-template.json",
".specify/memory/constitution.md",
".specify/workflows/speckit/workflow.yml",
".specify/workflows/workflow-registry.json",
@@ -724,6 +726,7 @@ class TestCopilotSkillsMode:
".specify/templates/plan-template.md",
".specify/templates/spec-template.md",
".specify/templates/tasks-template.md",
+ ".specify/memory/.constitution-template.json",
".specify/memory/constitution.md",
# Bundled workflow
".specify/workflows/speckit/workflow.yml",
diff --git a/tests/integrations/test_integration_generic.py b/tests/integrations/test_integration_generic.py
index 1c5edc2ef..3f079c438 100644
--- a/tests/integrations/test_integration_generic.py
+++ b/tests/integrations/test_integration_generic.py
@@ -286,6 +286,7 @@ class TestGenericIntegration:
".specify/integration.json",
".specify/integrations/generic.manifest.json",
".specify/integrations/speckit.manifest.json",
+ ".specify/memory/.constitution-template.json",
".specify/memory/constitution.md",
".specify/scripts/bash/check-prerequisites.sh",
".specify/scripts/bash/common.sh",
@@ -342,6 +343,7 @@ class TestGenericIntegration:
".specify/integration.json",
".specify/integrations/generic.manifest.json",
".specify/integrations/speckit.manifest.json",
+ ".specify/memory/.constitution-template.json",
".specify/memory/constitution.md",
".specify/scripts/powershell/check-prerequisites.ps1",
".specify/scripts/powershell/common.ps1",
diff --git a/tests/test_presets.py b/tests/test_presets.py
index 8208a416e..797835a88 100644
--- a/tests/test_presets.py
+++ b/tests/test_presets.py
@@ -2777,6 +2777,40 @@ def install_self_test_preset(manager: PresetManager, speckit_version: str = "0.1
return manager.install_from_directory(SELF_TEST_PRESET_DIR, speckit_version)
+def _make_convention_constitution_preset(temp_dir: Path) -> Path:
+ """Create a preset whose constitution is found by convention, not its manifest."""
+ preset_dir = temp_dir / "convention-constitution"
+ (preset_dir / "templates").mkdir(parents=True)
+ (preset_dir / "templates" / "constitution-template.md").write_text(
+ "# Convention Constitution\n"
+ )
+ (preset_dir / "templates" / "spec-template.md").write_text("# Spec\n")
+ (preset_dir / "preset.yml").write_text(
+ yaml.dump(
+ {
+ "schema_version": "1.0",
+ "preset": {
+ "id": "convention-constitution",
+ "name": "Convention Constitution",
+ "version": "1.0.0",
+ "description": "Convention-based constitution for testing",
+ },
+ "requires": {"speckit_version": ">=0.1.0"},
+ "provides": {
+ "templates": [
+ {
+ "type": "template",
+ "name": "spec-template",
+ "file": "templates/spec-template.md",
+ }
+ ]
+ },
+ }
+ )
+ )
+ return preset_dir
+
+
class TestSelfTestPreset:
"""Tests using the self-test preset that ships with the repo.
@@ -2884,6 +2918,24 @@ class TestSelfTestPreset:
assert result is not None
assert result["source"] == "core"
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ assert memory.read_text() == "# Core constitution-template\n"
+
+ def test_self_test_removal_preserves_edited_constitution(self, project_dir):
+ """Removing a preset does not overwrite an edited generated constitution."""
+ templates_dir = project_dir / ".specify" / "templates"
+ (templates_dir / "constitution-template.md").write_text("# Core Constitution\n")
+
+ manager = PresetManager(project_dir)
+ install_self_test_preset(manager)
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ edited = memory.read_text() + "\n## Authored amendment\n"
+ memory.write_text(edited)
+
+ manager.remove("self-test")
+
+ assert memory.read_text() == edited
+
def test_self_test_not_in_catalog(self):
"""Verify the self-test preset is NOT in the catalog (it's local-only)."""
catalog_path = Path(__file__).parent.parent / "presets" / "catalog.json"
@@ -2958,6 +3010,432 @@ class TestSelfTestPreset:
metadata = manager.registry.get("self-test")
assert metadata["registered_commands"] == {}
+ def test_self_test_seeds_constitution_when_memory_absent(self, project_dir):
+ """Installing a preset seeds memory/constitution.md from its template."""
+ manager = PresetManager(project_dir)
+ install_self_test_preset(manager)
+
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ assert memory.exists(), "constitution.md was not seeded from the preset"
+ assert "preset:self-test" in memory.read_text(), (
+ "constitution.md was not seeded from the self-test preset template"
+ )
+
+ def test_self_test_reseeds_exact_core_constitution(self, project_dir):
+ """An unchanged core constitution is re-seeded from the preset template."""
+ resolver = PresetResolver(project_dir)
+ bundled_core = resolver._find_bundled_core(
+ "constitution-template", "template", ".md"
+ )
+ assert bundled_core is not None
+ core = bundled_core.read_bytes()
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ memory.parent.mkdir(parents=True, exist_ok=True)
+ memory.write_bytes(core)
+
+ manager = PresetManager(project_dir)
+ install_self_test_preset(manager)
+
+ content = memory.read_text()
+ assert "preset:self-test" in content, "placeholder constitution was not re-seeded"
+ assert "[PROJECT_NAME]" not in content
+
+ @pytest.mark.parametrize(
+ "provenance_content",
+ [
+ '{"sha256": "does-not-match", "source": "old-preset"}\n',
+ "{not valid json",
+ ],
+ ids=["hash-mismatch", "malformed"],
+ )
+ def test_self_test_preserves_core_content_with_existing_invalid_provenance(
+ self, project_dir, provenance_content
+ ):
+ """A present invalid sidecar disables legacy core-template migration."""
+ resolver = PresetResolver(project_dir)
+ bundled_core = resolver._find_bundled_core(
+ "constitution-template", "template", ".md"
+ )
+ assert bundled_core is not None
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ memory.parent.mkdir(parents=True, exist_ok=True)
+ memory.write_bytes(bundled_core.read_bytes())
+ (memory.parent / ".constitution-template.json").write_text(
+ provenance_content
+ )
+ original = memory.read_bytes()
+
+ manager = PresetManager(project_dir)
+ install_self_test_preset(manager)
+
+ assert memory.read_bytes() == original
+
+ def test_self_test_preserves_mutable_project_core_copy(self, project_dir):
+ """A project template copy does not establish generated provenance."""
+ authored = "# Acme Organization Constitution\n\nOrganization policy.\n"
+ project_template = (
+ project_dir / ".specify" / "templates" / "constitution-template.md"
+ )
+ project_template.write_text(authored)
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ memory.parent.mkdir(parents=True, exist_ok=True)
+ memory.write_text(authored)
+
+ manager = PresetManager(project_dir)
+ install_self_test_preset(manager)
+
+ assert memory.read_text() == authored
+ assert not (memory.parent / ".constitution-template.json").exists()
+
+ def test_core_prefixed_preset_does_not_establish_generated_provenance(
+ self, project_dir, temp_dir
+ ):
+ """A preset ID beginning with core is not an immutable core source."""
+ authored = "# Acme Organization Constitution\n\nOrganization policy.\n"
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ memory.parent.mkdir(parents=True, exist_ok=True)
+ memory.write_text(authored)
+
+ preset_dir = temp_dir / "core-company"
+ (preset_dir / "templates").mkdir(parents=True)
+ (preset_dir / "templates" / "constitution-template.md").write_text(authored)
+ (preset_dir / "preset.yml").write_text(
+ yaml.safe_dump(
+ {
+ "schema_version": "1.0",
+ "preset": {
+ "id": "core-company",
+ "name": "Core Company",
+ "version": "1.0.0",
+ "description": "Company constitution preset",
+ "author": "Test Author",
+ "repository": "https://github.com/test/core-company",
+ "license": "MIT",
+ },
+ "requires": {"speckit_version": ">=0.1.0"},
+ "provides": {
+ "templates": [
+ {
+ "type": "template",
+ "name": "constitution-template",
+ "file": "templates/constitution-template.md",
+ "description": "Company constitution",
+ "replaces": "constitution-template",
+ }
+ ]
+ },
+ }
+ )
+ )
+
+ PresetManager(project_dir).install_from_directory(preset_dir, "0.1.5")
+
+ assert memory.read_text() == authored
+ assert not (memory.parent / ".constitution-template.json").exists()
+
+ def test_self_test_preserves_authored_constitution_with_placeholder(
+ self, project_dir
+ ):
+ """A placeholder mention does not establish generated provenance."""
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ memory.parent.mkdir(parents=True, exist_ok=True)
+ authored = "# Acme Constitution\n\nGuidance for [PROJECT_NAME].\n"
+ memory.write_text(authored)
+
+ manager = PresetManager(project_dir)
+ install_self_test_preset(manager)
+
+ assert memory.read_text() == authored
+
+ def test_self_test_preserves_authored_constitution(self, project_dir):
+ """An authored (placeholder-free) constitution is never overwritten."""
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ memory.parent.mkdir(parents=True, exist_ok=True)
+ authored = "# Acme Constitution\n\n### I. Ship It\nAuthored by a human.\n"
+ memory.write_text(authored)
+
+ manager = PresetManager(project_dir)
+ install_self_test_preset(manager)
+
+ assert memory.read_text() == authored, "authored constitution was overwritten"
+
+ def test_self_test_override_resolves_constitution_template(self, project_dir):
+ """The preset override of constitution-template resolves to the preset file."""
+ templates_dir = project_dir / ".specify" / "templates"
+ (templates_dir / "constitution-template.md").write_text("# Core constitution\n")
+
+ manager = PresetManager(project_dir)
+ install_self_test_preset(manager)
+
+ resolver = PresetResolver(project_dir)
+ result = resolver.resolve("constitution-template", "template")
+ assert result is not None
+ assert "preset:self-test" in result.read_text()
+
+ def test_constitution_seed_composes_wrap_strategy(self, project_dir, temp_dir):
+ """Seeding memory composes wrap constitution-template layers."""
+ templates_dir = project_dir / ".specify" / "templates"
+ templates_dir.mkdir(parents=True, exist_ok=True)
+ (templates_dir / "constitution-template.md").write_text(
+ "# Core Constitution\n\n## Core Principle\n"
+ )
+
+ preset_dir = temp_dir / "constitution-wrap"
+ (preset_dir / "templates").mkdir(parents=True)
+ (preset_dir / "templates" / "constitution-template.md").write_text(
+ "# Wrapper Constitution\n\n{CORE_TEMPLATE}\n\n## Wrapper Footer\n"
+ )
+ (preset_dir / "preset.yml").write_text(
+ yaml.dump(
+ {
+ "schema_version": "1.0",
+ "preset": {
+ "id": "constitution-wrap",
+ "name": "Constitution Wrap",
+ "version": "1.0.0",
+ "description": "Wrap constitution template for testing",
+ },
+ "requires": {"speckit_version": ">=0.1.0"},
+ "provides": {
+ "templates": [
+ {
+ "type": "template",
+ "name": "constitution-template",
+ "file": "templates/constitution-template.md",
+ "strategy": "wrap",
+ "description": "Wrapped constitution template",
+ }
+ ]
+ },
+ }
+ )
+ )
+
+ manager = PresetManager(project_dir)
+ manager.install_from_directory(preset_dir, "0.1.5")
+
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ content = memory.read_text()
+ assert "{CORE_TEMPLATE}" not in content
+ assert "# Wrapper Constitution" in content
+ assert "## Core Principle" in content
+
+ def test_constitution_follows_priority_when_winning_preset_removed(
+ self, project_dir, temp_dir
+ ):
+ """An unchanged generated constitution follows priority and fallback layers."""
+ manager = PresetManager(project_dir)
+ install_self_test_preset(manager)
+
+ preset_dir = temp_dir / "higher-priority"
+ (preset_dir / "templates").mkdir(parents=True)
+ (preset_dir / "templates" / "constitution-template.md").write_text(
+ "# Higher Priority Constitution\n"
+ )
+ (preset_dir / "preset.yml").write_text(
+ yaml.dump(
+ {
+ "schema_version": "1.0",
+ "preset": {
+ "id": "higher-priority",
+ "name": "Higher Priority",
+ "version": "1.0.0",
+ "description": "Higher-priority constitution",
+ },
+ "requires": {"speckit_version": ">=0.1.0"},
+ "provides": {
+ "templates": [
+ {
+ "type": "template",
+ "name": "constitution-template",
+ "file": "templates/constitution-template.md",
+ "strategy": "replace",
+ "description": "Higher-priority constitution",
+ }
+ ]
+ },
+ }
+ )
+ )
+
+ manager.install_from_directory(preset_dir, "0.1.5", priority=1)
+
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ assert memory.read_text() == "# Higher Priority Constitution\n"
+
+ manager.remove("higher-priority")
+
+ assert "preset:self-test" in memory.read_text()
+
+ def test_convention_constitution_removal_restores_remaining_layer(
+ self, project_dir, temp_dir
+ ):
+ """Removing a convention layer rematerializes the remaining resolver layer."""
+ manager = PresetManager(project_dir)
+ install_self_test_preset(manager)
+ manager.install_from_directory(
+ _make_convention_constitution_preset(temp_dir), "0.1.5", priority=1
+ )
+
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ assert memory.read_text() == "# Convention Constitution\n"
+
+ manager.remove("convention-constitution")
+
+ assert "preset:self-test" in memory.read_text()
+
+ def test_convention_constitution_removal_preserves_edited_content(
+ self, project_dir, temp_dir
+ ):
+ """Removing a convention layer does not overwrite edited generated content."""
+ from specify_cli.commands.init import ensure_constitution_from_template
+
+ templates_dir = project_dir / ".specify" / "templates"
+ (templates_dir / "constitution-template.md").write_text("# Core Constitution\n")
+ manager = PresetManager(project_dir)
+ manager.install_from_directory(
+ _make_convention_constitution_preset(temp_dir), "0.1.5"
+ )
+ ensure_constitution_from_template(project_dir)
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ edited = memory.read_text() + "\n## Authored amendment\n"
+ memory.write_text(edited)
+
+ manager.remove("convention-constitution")
+
+ assert memory.read_text() == edited
+
+ def test_custom_constitution_removal_recovers_with_invalid_manifest(
+ self, project_dir, temp_dir
+ ):
+ """Provenance triggers fallback when a custom-path manifest is invalid."""
+ manager = PresetManager(project_dir)
+ install_self_test_preset(manager)
+
+ preset_dir = temp_dir / "custom-constitution"
+ (preset_dir / "policy").mkdir(parents=True)
+ (preset_dir / "policy" / "charter.md").write_text("# Custom Constitution\n")
+ (preset_dir / "preset.yml").write_text(
+ yaml.dump(
+ {
+ "schema_version": "1.0",
+ "preset": {
+ "id": "custom-constitution",
+ "name": "Custom Constitution",
+ "version": "1.0.0",
+ "description": "Custom-path constitution for testing",
+ },
+ "requires": {"speckit_version": ">=0.1.0"},
+ "provides": {
+ "templates": [
+ {
+ "type": "template",
+ "name": "constitution-template",
+ "file": "policy/charter.md",
+ }
+ ]
+ },
+ }
+ )
+ )
+ manager.install_from_directory(preset_dir, "0.1.5", priority=1)
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ assert memory.read_text() == "# Custom Constitution\n"
+
+ installed_manifest = (
+ project_dir
+ / ".specify"
+ / "presets"
+ / "custom-constitution"
+ / "preset.yml"
+ )
+ installed_manifest.write_text("invalid: [")
+
+ manager.remove("custom-constitution")
+
+ assert "preset:self-test" in memory.read_text()
+
+ def test_constitution_seed_rejects_symlinked_memory_directory(
+ self, project_dir, temp_dir
+ ):
+ """Preset installation cannot seed through a symlinked memory directory."""
+ outside = temp_dir / "outside"
+ outside.mkdir()
+ try:
+ (project_dir / ".specify" / "memory").symlink_to(
+ outside, target_is_directory=True
+ )
+ except OSError:
+ pytest.skip("symlinks are unavailable")
+
+ manager = PresetManager(project_dir)
+ with pytest.warns(UserWarning, match="symlinked"):
+ install_self_test_preset(manager)
+
+ assert manager.registry.is_installed("self-test")
+ assert not (outside / "constitution.md").exists()
+
+ def test_constitution_seed_rejects_dangling_destination_symlink(
+ self, project_dir, temp_dir
+ ):
+ """Preset installation cannot seed through a dangling destination symlink."""
+ memory = project_dir / ".specify" / "memory"
+ memory.mkdir(parents=True)
+ outside = temp_dir / "outside-constitution.md"
+ try:
+ (memory / "constitution.md").symlink_to(outside)
+ except OSError:
+ pytest.skip("symlinks are unavailable")
+
+ manager = PresetManager(project_dir)
+ with pytest.warns(UserWarning, match="symlinked"):
+ install_self_test_preset(manager)
+
+ assert manager.registry.is_installed("self-test")
+ assert not outside.exists()
+
+ def test_constitution_materialization_error_is_nonfatal(
+ self, project_dir, temp_dir
+ ):
+ """An invalid wrap warns without reporting an uninstalled preset."""
+ preset_dir = temp_dir / "invalid-wrap"
+ (preset_dir / "templates").mkdir(parents=True)
+ (preset_dir / "templates" / "constitution-template.md").write_text(
+ "# Missing core placeholder\n"
+ )
+ (preset_dir / "preset.yml").write_text(
+ yaml.dump(
+ {
+ "schema_version": "1.0",
+ "preset": {
+ "id": "invalid-wrap",
+ "name": "Invalid Wrap",
+ "version": "1.0.0",
+ "description": "Invalid wrapping constitution",
+ },
+ "requires": {"speckit_version": ">=0.1.0"},
+ "provides": {
+ "templates": [
+ {
+ "type": "template",
+ "name": "constitution-template",
+ "file": "templates/constitution-template.md",
+ "strategy": "wrap",
+ "description": "Invalid wrap",
+ }
+ ]
+ },
+ }
+ )
+ )
+
+ manager = PresetManager(project_dir)
+ with pytest.warns(UserWarning, match="Failed to seed constitution"):
+ manifest = manager.install_from_directory(preset_dir, "0.1.5")
+
+ assert manifest.id == "invalid-wrap"
+ assert manager.registry.is_installed("invalid-wrap")
+
def test_extension_command_skipped_when_extension_missing(self, project_dir, temp_dir):
"""Test that extension command overrides are skipped if the extension isn't installed."""
claude_dir = project_dir / ".claude" / "skills"
@@ -4308,6 +4786,31 @@ class TestPresetSetPriority:
manager2 = PresetManager(project_dir)
assert manager2.registry.get("test-pack")["priority"] == 5
+ def test_set_priority_reconciles_generated_constitution(
+ self, project_dir, temp_dir
+ ):
+ """Changing priority rematerializes an unchanged generated constitution."""
+ from typer.testing import CliRunner
+ from unittest.mock import patch
+ from specify_cli import app
+
+ manager = PresetManager(project_dir)
+ install_self_test_preset(manager)
+ manager.install_from_directory(
+ _make_convention_constitution_preset(temp_dir), "0.1.5", priority=20
+ )
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ assert "preset:self-test" in memory.read_text()
+
+ with patch.object(Path, "cwd", return_value=project_dir):
+ result = CliRunner().invoke(
+ app,
+ ["preset", "set-priority", "convention-constitution", "1"],
+ )
+
+ assert result.exit_code == 0, result.output
+ assert memory.read_text() == "# Convention Constitution\n"
+
def test_set_priority_same_value_no_change(self, project_dir, pack_dir):
"""Test set-priority with same value shows already set message."""
from typer.testing import CliRunner
@@ -4528,6 +5031,61 @@ class TestPresetEnableDisable:
manager2 = PresetManager(project_dir)
assert manager2.registry.get("test-pack")["enabled"] is True
+ def test_enable_disable_reconciles_generated_constitution(
+ self, project_dir, temp_dir
+ ):
+ """Enable and disable rematerialize the winning constitution layer."""
+ from typer.testing import CliRunner
+ from unittest.mock import patch
+ from specify_cli import app
+
+ manager = PresetManager(project_dir)
+ install_self_test_preset(manager)
+ manager.install_from_directory(
+ _make_convention_constitution_preset(temp_dir), "0.1.5", priority=1
+ )
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ assert memory.read_text() == "# Convention Constitution\n"
+ runner = CliRunner()
+
+ with patch.object(Path, "cwd", return_value=project_dir):
+ disabled = runner.invoke(
+ app, ["preset", "disable", "convention-constitution"]
+ )
+
+ assert disabled.exit_code == 0, disabled.output
+ assert "preset:self-test" in memory.read_text()
+
+ with patch.object(Path, "cwd", return_value=project_dir):
+ enabled = runner.invoke(
+ app, ["preset", "enable", "convention-constitution"]
+ )
+
+ assert enabled.exit_code == 0, enabled.output
+ assert memory.read_text() == "# Convention Constitution\n"
+
+ def test_stack_changes_do_not_create_missing_constitution(
+ self, project_dir, pack_dir
+ ):
+ """Stack changes for non-providers do not seed a missing constitution."""
+ from typer.testing import CliRunner
+ from unittest.mock import patch
+ from specify_cli import app
+
+ PresetManager(project_dir).install_from_directory(pack_dir, "0.1.5")
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ runner = CliRunner()
+
+ for args in (
+ ["preset", "set-priority", "test-pack", "5"],
+ ["preset", "disable", "test-pack"],
+ ["preset", "enable", "test-pack"],
+ ):
+ with patch.object(Path, "cwd", return_value=project_dir):
+ result = runner.invoke(app, args)
+ assert result.exit_code == 0, result.output
+ assert not memory.exists()
+
def test_disable_already_disabled(self, project_dir, pack_dir):
"""Test disable on already disabled preset shows warning."""
from typer.testing import CliRunner
@@ -6678,3 +7236,130 @@ def test_preset_wrapper_resolves_ghes_asset_when_host_configured(tmp_path, monke
)
assert resolved == "https://ghes.example/api/v3/repos/o/r/releases/assets/9"
assert captured == ["https://ghes.example/api/v3/repos/o/r/releases/tags/v2"]
+
+
+# ===== ensure_constitution_from_template resolver-awareness =====
+
+
+class TestEnsureConstitutionResolverAware:
+ """`ensure_constitution_from_template` must resolve through PresetResolver.
+
+ The constitution is the only template materialized to a live file rather
+ than resolved on demand. These tests pin the regression from issue #3272:
+ a preset-provided ``constitution-template`` must seed memory, while the
+ core template is used when no preset overrides it.
+ """
+
+ def _core_constitution(self, project_dir):
+ templates_dir = project_dir / ".specify" / "templates"
+ templates_dir.mkdir(parents=True, exist_ok=True)
+ (templates_dir / "constitution-template.md").write_text(
+ "# [PROJECT_NAME] Constitution\n\n### [PRINCIPLE_1_NAME]\n"
+ )
+
+ def _wrap_constitution_preset(self, temp_dir):
+ preset_dir = temp_dir / "ensure-wrap-preset"
+ (preset_dir / "templates").mkdir(parents=True)
+ (preset_dir / "templates" / "constitution-template.md").write_text(
+ "# Ensure Wrapper\n\n{CORE_TEMPLATE}\n\n## Tail\n"
+ )
+ (preset_dir / "preset.yml").write_text(
+ yaml.dump(
+ {
+ "schema_version": "1.0",
+ "preset": {
+ "id": "ensure-wrap",
+ "name": "Ensure Wrap",
+ "version": "1.0.0",
+ "description": "Wrap strategy for ensure() coverage",
+ },
+ "requires": {"speckit_version": ">=0.1.0"},
+ "provides": {
+ "templates": [
+ {
+ "type": "template",
+ "name": "constitution-template",
+ "file": "templates/constitution-template.md",
+ "strategy": "wrap",
+ "description": "Wrapped constitution",
+ }
+ ]
+ },
+ }
+ )
+ )
+ return preset_dir
+
+ def test_seeds_from_core_when_no_preset(self, project_dir):
+ from specify_cli.commands.init import ensure_constitution_from_template
+
+ self._core_constitution(project_dir)
+ ensure_constitution_from_template(project_dir)
+
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ assert memory.exists()
+ assert "[PROJECT_NAME]" in memory.read_text()
+ assert (memory.parent / ".constitution-template.json").exists()
+
+ def test_seeds_from_preset_when_installed(self, project_dir):
+ from specify_cli.commands.init import ensure_constitution_from_template
+
+ self._core_constitution(project_dir)
+ manager = PresetManager(project_dir)
+ install_self_test_preset(manager)
+
+ # Remove the memory file seeded during install to test ensure() in
+ # isolation; it must re-seed from the preset, not the core template.
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ memory.unlink()
+
+ ensure_constitution_from_template(project_dir)
+
+ assert memory.exists()
+ content = memory.read_text()
+ assert "preset:self-test" in content
+ assert "[PROJECT_NAME]" not in content
+
+ def test_preserves_existing_memory(self, project_dir):
+ from specify_cli.commands.init import ensure_constitution_from_template
+
+ self._core_constitution(project_dir)
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ memory.parent.mkdir(parents=True, exist_ok=True)
+ authored = "# Acme Constitution\nAuthored.\n"
+ memory.write_text(authored)
+
+ ensure_constitution_from_template(project_dir)
+
+ assert memory.read_text() == authored
+
+ def test_preserves_edited_generated_memory(self, project_dir):
+ from specify_cli.commands.init import ensure_constitution_from_template
+
+ self._core_constitution(project_dir)
+ ensure_constitution_from_template(project_dir)
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ authored = memory.read_text() + "\nAuthored amendment.\n"
+ memory.write_text(authored)
+
+ manager = PresetManager(project_dir)
+ install_self_test_preset(manager)
+
+ assert memory.read_text() == authored
+
+ def test_composes_wrap_strategy_when_ensuring(self, project_dir, temp_dir):
+ from specify_cli.commands.init import ensure_constitution_from_template
+
+ self._core_constitution(project_dir)
+ manager = PresetManager(project_dir)
+ manager.install_from_directory(self._wrap_constitution_preset(temp_dir), "0.1.5")
+
+ # Ensure we validate ensure() behavior directly.
+ memory = project_dir / ".specify" / "memory" / "constitution.md"
+ memory.unlink()
+ ensure_constitution_from_template(project_dir)
+
+ content = memory.read_text()
+ assert "{CORE_TEMPLATE}" not in content
+ assert "# Ensure Wrapper" in content
+ assert "[PROJECT_NAME]" in content