💫 Toolkit to help you get started with SDD or any other process!
fix(presets): validate required manifest mappings (#3898)
Marsel Safin400ad01f12a9
diff --git a/src/specify_cli/presets/__init__.py b/src/specify_cli/presets/__init__.pyindex 0a42e06ba..2f32d162b 100644--- a/src/specify_cli/presets/__init__.py+++ b/src/specify_cli/presets/__init__.py@@ -299,6 +299,12 @@ class PresetManifest:f"(expected {self.SCHEMA_VERSION})")+ for section in ("preset", "requires", "provides"):+ if not isinstance(self.data[section], dict):+ raise PresetValidationError(+ f"Invalid {section}: expected a mapping"+ )+# Validate preset metadatapack = self.data["preset"]for field in ["id", "name", "version", "description"]:diff --git a/tests/test_presets.py b/tests/test_presets.pyindex 32f62fd72..d4c964c83 100644--- a/tests/test_presets.py+++ b/tests/test_presets.py@@ -198,6 +198,25 @@ class TestPresetManifest:with pytest.raises(PresetValidationError, match="YAML mapping"):PresetManifest(manifest_path)+ @pytest.mark.parametrize("section", ["preset", "requires", "provides"])+ @pytest.mark.parametrize("bad_value", [None, [], "text"])+ def test_required_section_not_mapping_raises_validation_error(+ self, temp_dir, valid_pack_data, section, bad_value+ ):+ """Required manifest sections reject null, list, and scalar values."""+ valid_pack_data[section] = bad_value+ manifest_path = temp_dir / "preset.yml"+ manifest_path.write_text(+ yaml.safe_dump(valid_pack_data),+ encoding="utf-8",+ )++ with pytest.raises(+ PresetValidationError,+ match=rf"Invalid {section}: expected a mapping",+ ):+ PresetManifest(manifest_path)+@pytest.mark.parametrize("bad",[