💫 Toolkit to help you get started with SDD or any other process!
fix(events): skip non-UTF-8 extension manifests (#3900)
Marsel Safin4343cd5e8061
diff --git a/src/specify_cli/events.py b/src/specify_cli/events.pyindex 98e49aee3..d3002fe80 100644--- a/src/specify_cli/events.py+++ b/src/specify_cli/events.py@@ -895,7 +895,7 @@ def collect_extension_events(project_root: Path) -> ResolvedEvents:continuetry:data = yaml.safe_load(ext_yml.read_text(encoding="utf-8")) or {}- except yaml.YAMLError:+ except (UnicodeDecodeError, yaml.YAMLError):continueif not isinstance(data, dict):continuediff --git a/tests/integrations/test_events.py b/tests/integrations/test_events.pyindex 659ae4859..084156a52 100644--- a/tests/integrations/test_events.py+++ b/tests/integrations/test_events.py@@ -164,6 +164,13 @@ class TestCollectExtensionEvents:(ext_dir / "extension.yml").write_text("invalid: - - -", encoding="utf-8")assert collect_extension_events(tmp_path) == {}+ def test_non_utf8_manifest_skipped(self, tmp_path):+ ext_dir = tmp_path / ".specify" / "extensions" / "my-ext"+ ext_dir.mkdir(parents=True)+ (ext_dir / "extension.yml").write_bytes(b"\xff\xfe")++ assert collect_extension_events(tmp_path) == {}+def test_event_command_ref_canonicalized_via_manifest(self, tmp_path):"""R1: events are read from a validated ExtensionManifest, so anobsolete command ref (e.g. my-ext.boot) is canonicalized