💫 Toolkit to help you get started with SDD or any other process!
fix(integrations): drop invalid --model/--output-format flags from Vibe dispatch (#4784)
Tymur5a046ab80fbd
diff --git a/src/specify_cli/integrations/vibe/__init__.py b/src/specify_cli/integrations/vibe/__init__.pyindex 44ae6f96d..e0d0957d9 100644--- a/src/specify_cli/integrations/vibe/__init__.py+++ b/src/specify_cli/integrations/vibe/__init__.py@@ -6,6 +6,7 @@ Vibe uses ``.vibe/skills/speckit-<name>/SKILL.md`` layout (enforced since v2.0.0from __future__ import annotations+from collections.abc import Mapping, Sequencefrom pathlib import Pathfrom typing import Any@@ -79,6 +80,33 @@ class VibeIntegration(SkillsIntegration):)return opts+ def build_exec_args(+ self,+ prompt: str,+ *,+ model: str | None = None,+ output_json: bool = True,+ integration_args: Sequence[str] | None = None,+ integration_options: Mapping[str, Any] | None = None,+ project_root: Path | None = None,+ ) -> list[str] | None:+ """Build CLI arguments for non-interactive ``vibe`` execution.++ ``SkillsIntegration``'s default appends ``--model`` and+ ``--output-format``, neither of which exists in the Vibe CLI, so a+ dispatched step exits 2 at argument parsing whenever either flag ends+ up appended (a configured ``model``, or ``output_json=True``). Vibe's+ structured output is ``--output json``. ``model`` is deliberately+ dropped: Vibe has no per-invocation model flag and selects its model+ out of band via ``active_model`` in its config (or ``VIBE_ACTIVE_MODEL``).+ """+ self.validate_runtime_config(integration_args, integration_options)+ args = [self._resolve_executable(), "-p", prompt]+ self._apply_extra_args_env_var(args)+ if output_json:+ args.extend(["--output", "json"])+ return args+def _render_skill(self, template_name: str, frontmatter: dict[str, Any], body: str) -> str:"""Render a processed command template as a Vibe skill."""skill_name = f"speckit-{template_name.replace('.', '-')}"diff --git a/tests/integrations/test_integration_vibe.py b/tests/integrations/test_integration_vibe.pyindex 8bd26fe75..c2189a4b8 100644--- a/tests/integrations/test_integration_vibe.py+++ b/tests/integrations/test_integration_vibe.py@@ -128,6 +128,54 @@ class TestVibeIntegration(SkillsIntegrationTests):f"{f.parent.name}/SKILL.md unexpectedly has argument-hint frontmatter")+ def test_build_exec_args_uses_prompt_mode(self):+ integration = get_integration("vibe")++ args = integration.build_exec_args(+ "/speckit-specify build a login page",+ output_json=False,+ )++ assert args == ["vibe", "-p", "/speckit-specify build a login page"]++ def test_build_exec_args_requests_json_output(self):+ """Vibe's structured output is `--output json`; it has no `--output-format`."""+ integration = get_integration("vibe")++ args = integration.build_exec_args("/speckit-plan add OAuth", output_json=True)++ assert args == ["vibe", "-p", "/speckit-plan add OAuth", "--output", "json"]+ assert "--output-format" not in args++ def test_build_exec_args_omits_model_flag(self):+ """Vibe has no model flag; passing `--model` exits 2 at argument parsing."""+ integration = get_integration("vibe")++ args = integration.build_exec_args(+ "explain this repository",+ model="mistral-medium-latest",+ output_json=False,+ )++ assert args == ["vibe", "-p", "explain this repository"]+ assert "--model" not in args+ assert "mistral-medium-latest" not in args++ def test_build_exec_args_applies_extra_args(self, monkeypatch):+ monkeypatch.setenv("SPECKIT_INTEGRATION_VIBE_EXTRA_ARGS", "--auto-approve")+ integration = get_integration("vibe")++ args = integration.build_exec_args("check the build", output_json=True)++ assert args == [+ "vibe",+ "-p",+ "check the build",+ "--auto-approve",+ "--output",+ "json",+ ]+class TestVibeTomlMerging:"""Behavioral tests for the toml-vibe hooks.toml generation and cleanup."""