π« Toolkit to help you get started with SDD or any other process!
fix: log progress tracker refresh errors instead of silently swallowing (#3975)
Quratulain-bilal618d16e94be3
diff --git a/src/specify_cli/_console.py b/src/specify_cli/_console.pyindex 8d1216387..0e448780a 100644--- a/src/specify_cli/_console.py+++ b/src/specify_cli/_console.py@@ -7,6 +7,7 @@ layer, not out of it, to avoid circular imports."""from __future__ import annotations+import loggingimport sysfrom collections.abc import Callable@@ -21,6 +22,8 @@ from rich.text import Textfrom rich.tree import Treefrom typer.core import TyperGroup+logger = logging.getLogger(__name__)+BANNER = """βββββββββββββββ ββββββββ βββββββββββββββββββββ ββββββββββββββββββββββββββββββββββββββββββββββββββ ββββ@@ -85,7 +88,7 @@ class StepTracker:try:self._refresh_cb()except Exception:- pass+ logger.debug("Progress tracker refresh failed", exc_info=True)def render(self):tree = Tree(f"[cyan]{self.title}[/cyan]", guide_style="grey50")diff --git a/tests/test_console_imports.py b/tests/test_console_imports.pyindex 2ae328732..9ecb49cf3 100644--- a/tests/test_console_imports.py+++ b/tests/test_console_imports.py@@ -1,9 +1,12 @@"""Regression guard: console symbols must remain importable from specify_cli."""+import logging+from specify_cli import (console,StepTracker,select_with_arrows,)+from specify_cli._console import logger as console_loggerdef test_console_symbols_importable():@@ -39,3 +42,21 @@ def test_select_with_arrows_raises_on_empty_options():import pytestwith pytest.raises(ValueError, match="at least one option"):select_with_arrows({})+++def test_step_tracker_refresh_error_is_logged(caplog):+ """Regression: _maybe_refresh must log exceptions instead of silently swallowing."""+ tracker = StepTracker("test")++ def failing_refresh():+ raise RuntimeError("simulated refresh failure")++ tracker.attach_refresh(failing_refresh)+ tracker.add("step1", "Step One")++ with caplog.at_level(logging.DEBUG, logger=console_logger.name):+ tracker.complete("step1", "done")++ assert "Progress tracker refresh failed" in caplog.text+ assert "RuntimeError: simulated refresh failure" in caplog.text+ assert tracker.steps[0]["status"] == "done"