Skip to content

πŸ’« Toolkit to help you get started with SDD or any other process!

fix(scripts): git-ext PowerShell emits the '# To persist' SPECIFY_FEATURE hint (parity) (#3632)

Ali jawwad8db722842f11
diff --git a/extensions/git/scripts/powershell/create-new-feature-branch.ps1 b/extensions/git/scripts/powershell/create-new-feature-branch.ps1
index 1536f9a2b..2d6f2bcfe 100644
--- a/extensions/git/scripts/powershell/create-new-feature-branch.ps1
+++ b/extensions/git/scripts/powershell/create-new-feature-branch.ps1
@@ -565,6 +565,12 @@ if (-not $DryRun) {
$env:SPECIFY_FEATURE = $branchName
}
+# Build the PowerShell-idiomatic persist hint, mirroring the core
+# create-new-feature.ps1 twin (and the bash/python twins of this script), which
+# all emit "# To persist in your shell: ...".
+$quotedBranchName = "'" + $branchName.Replace("'", "''") + "'"
+$featureAssignment = '$env:SPECIFY_FEATURE = ' + $quotedBranchName
+
if ($Json) {
$obj = [PSCustomObject]@{
BRANCH_NAME = $branchName
@@ -581,6 +587,6 @@ if ($Json) {
Write-Output "BRANCH_NAME: $branchName"
Write-Output "FEATURE_NUM: $featureNum"
if (-not $DryRun) {
- Write-Output "SPECIFY_FEATURE environment variable set to: $branchName"
+ Write-Output "# To persist in your shell: $featureAssignment"
}
}
diff --git a/tests/extensions/git/test_git_extension.py b/tests/extensions/git/test_git_extension.py
index 79acfcb79..1354af394 100644
--- a/tests/extensions/git/test_git_extension.py
+++ b/tests/extensions/git/test_git_extension.py
@@ -698,6 +698,22 @@ class TestCreateFeaturePowerShell:
assert rt.returncode == 0, rt.stderr
assert "HAS_GIT" not in rt.stdout
+ def test_persist_hint_matches_twins(self, tmp_path: Path):
+ """The non-JSON SPECIFY_FEATURE hint must use the '# To persist in your
+ shell: $env:SPECIFY_FEATURE = '<name>' form β€” matching the core
+ create-new-feature.ps1 twin and the bash/python twins of this script β€”
+ not the old 'environment variable set to:' wording (the env var is only
+ set in this child process, so the actionable output is the persist hint)."""
+ project = _setup_project(tmp_path)
+ result = _run_pwsh(
+ "create-new-feature-branch.ps1", project,
+ "-ShortName", "persist", "Persist hint feature",
+ )
+ assert result.returncode == 0, result.stderr
+ assert "# To persist in your shell:" in result.stdout
+ assert "$env:SPECIFY_FEATURE = '001-persist'" in result.stdout
+ assert "environment variable set to:" not in result.stdout
+
def test_help_documents_branch_prefix(self, tmp_path: Path):
"""-Help documents both template config knobs."""
project = _setup_project(tmp_path)