π« Toolkit to help you get started with SDD or any other process!
chore: remove unused open_github_url/_StripAuthOnRedirect from _github_http.py (#2883)
Ali jawwad9c4fa31ceccb
diff --git a/src/specify_cli/_github_http.py b/src/specify_cli/_github_http.pyindex 8f6abc40f..d2030b57a 100644--- a/src/specify_cli/_github_http.py+++ b/src/specify_cli/_github_http.py@@ -1,9 +1,11 @@-"""Shared GitHub-authenticated HTTP helpers.--Used by both ExtensionCatalog and PresetCatalog to attach-GITHUB_TOKEN / GH_TOKEN credentials to requests targeting-GitHub-hosted domains, while preventing token leakage to-third-party hosts on redirects.+"""Shared GitHub HTTP request helpers.++Provides ``build_github_request()`` for attaching GITHUB_TOKEN / GH_TOKEN+credentials to requests targeting GitHub-hosted domains, and+``resolve_github_release_asset_api_url()`` β used by extensions, presets,+and workflow URL resolution β to translate browser release-download URLs+into GitHub REST API asset URLs. Authenticated downloads themselves go+through the config-driven helpers in :mod:`specify_cli.authentication.http`."""import os@@ -54,28 +56,6 @@ def build_github_request(url: str) -> urllib.request.Request:return urllib.request.Request(url, headers=headers)-class _StripAuthOnRedirect(urllib.request.HTTPRedirectHandler):- """Redirect handler that drops the Authorization header when leaving GitHub.-- Prevents token leakage to CDNs or other third-party hosts that GitHub- may redirect to (e.g. S3 for release asset downloads, objects.githubusercontent.com).- Auth is preserved as long as the redirect target remains within GITHUB_HOSTS.- """-- def redirect_request(self, req, fp, code, msg, headers, newurl):- original_auth = req.get_header("Authorization")- new_req = super().redirect_request(req, fp, code, msg, headers, newurl)- if new_req is not None:- hostname = (urlparse(newurl).hostname or "").lower()- if hostname in GITHUB_HOSTS:- if original_auth:- new_req.add_unredirected_header("Authorization", original_auth)- else:- new_req.headers.pop("Authorization", None)- new_req.unredirected_hdrs.pop("Authorization", None)- return new_req--def resolve_github_release_asset_api_url(download_url: str,open_url_fn: Callable,@@ -147,20 +127,3 @@ def resolve_github_release_asset_api_url(return str(asset["url"])return None---def open_github_url(url: str, timeout: int = 10):- """Open a URL with GitHub auth, stripping the header on cross-host redirects.-- When the request carries an Authorization header, a custom redirect- handler drops that header if the redirect target is not a GitHub-owned- domain, preventing token leakage to CDNs or other third-party hosts- that GitHub may redirect to (e.g. S3 for release asset downloads).- """- req = build_github_request(url)-- if not req.get_header("Authorization"):- return urllib.request.urlopen(req, timeout=timeout)-- opener = urllib.request.build_opener(_StripAuthOnRedirect)- return opener.open(req, timeout=timeout)