💫 Toolkit to help you get started with SDD or any other process!
fix(agent-context): apply default markers when config markers are blank (bash) (#3736)
Mateus Cardoso9e150cd3b22f
diff --git a/extensions/agent-context/scripts/bash/update-agent-context.sh b/extensions/agent-context/scripts/bash/update-agent-context.shindex 747a47a16..7fbe3ef49 100755--- a/extensions/agent-context/scripts/bash/update-agent-context.sh+++ b/extensions/agent-context/scripts/bash/update-agent-context.sh@@ -176,13 +176,18 @@ _opts_lines=()while IFS= read -r _line || [[ -n "$_line" ]]; do_opts_lines+=("$_line")done < <(printf '%s\n' "$_raw_opts")-if (( ${#_opts_lines[@]} < 3 )); then- echo "agent-context: malformed config parser output; expected 3 lines (context_files, marker_start, marker_end), got ${#_opts_lines[@]}; skipping update." >&2+if (( ${#_opts_lines[@]} < 1 )); then+ echo "agent-context: malformed config parser output; expected at least the context_files line, got ${#_opts_lines[@]}; skipping update." >&2exit 0fi+# The marker lines may be absent: the $(...) capture above strips trailing+# newlines, so blank markers (the config omitting context_markers and relying on+# defaults) collapse the 3-line output to fewer lines. Default them to empty here+# and let the DEFAULT_START/END substitution below fill them in, matching the+# Python and PowerShell ports.CONTEXT_FILES_JSON="${_opts_lines[0]}"-MARKER_START="${_opts_lines[1]}"-MARKER_END="${_opts_lines[2]}"+MARKER_START="${_opts_lines[1]:-}"+MARKER_END="${_opts_lines[2]:-}"if ! _context_files_raw="$("$_python" - "$CONTEXT_FILES_JSON" <<'PY'import jsondiff --git a/tests/extensions/test_update_agent_context_python_parity.py b/tests/extensions/test_update_agent_context_python_parity.pyindex 51d183166..969192eef 100644--- a/tests/extensions/test_update_agent_context_python_parity.py+++ b/tests/extensions/test_update_agent_context_python_parity.py@@ -222,6 +222,32 @@ def test_python_custom_markers_matching_bash(tmp_path: Path) -> None:assert "old" not in content+@requires_posix_bash+def test_python_blank_markers_use_defaults_matching_bash(tmp_path: Path) -> None:+ # Regression: with blank markers (config relying on the built-in defaults),+ # the Bash port must fall back to DEFAULT_START/END, matching the Python and+ # PowerShell ports. Previously the Bash config-parser transport dropped the+ # trailing empty marker lines under $(...) command substitution, tripping the+ # "malformed config parser output" guard so the default-marker substitution+ # became unreachable and the context file was never updated.+ markers = {"start": "", "end": ""}+ repo_a, repo_b = twin_projects(+ tmp_path, context_file="AGENTS.md", context_markers=markers+ )+ add_plan(repo_a)+ add_plan(repo_b)++ bash = run_bash(repo_a)+ py = run_python(repo_b)++ assert_parity(bash, py, repo_a, repo_b)+ content = (repo_b / "AGENTS.md").read_bytes()+ assert content == (repo_a / "AGENTS.md").read_bytes()+ assert b"<!-- SPECKIT START -->" in content+ assert b"<!-- SPECKIT END -->" in content+ assert b"at specs/001-demo/plan.md" in content++@requires_posix_bashdef test_python_multiple_context_files_dedup_matching_bash(tmp_path: Path) -> None:files = ["AGENTS.md", "docs/CONTEXT.md", "AGENTS.md"]