Skip to content

💫 Toolkit to help you get started with SDD or any other process!

fix: remove TOCTOU race in RunState.load (#3839)

Quratulain-bilalc807e2450c8d
diff --git a/src/specify_cli/workflows/engine.py b/src/specify_cli/workflows/engine.py
index 835183a2c..b9bf83701 100644
--- a/src/specify_cli/workflows/engine.py
+++ b/src/specify_cli/workflows/engine.py
@@ -743,12 +743,13 @@ class RunState:
cls._validate_run_id(run_id)
runs_dir = project_root / ".specify" / "workflows" / "runs" / run_id
state_path = runs_dir / "state.json"
- if not state_path.exists():
+
+ try:
+ with open(state_path, encoding="utf-8") as f:
+ state_data = json.load(f)
+ except FileNotFoundError:
msg = f"Run state not found: {state_path}"
raise FileNotFoundError(msg)
-
- with open(state_path, encoding="utf-8") as f:
- state_data = json.load(f)
if not isinstance(state_data, dict):
raise ValueError("Invalid run state: expected a JSON object")
missing_fields = [