💫 Toolkit to help you get started with SDD or any other process!
fix(workflows): list-literal expression ignores trailing/empty commas (#3631)
Ali jawwadcef00a1cb313
diff --git a/src/specify_cli/workflows/expressions.py b/src/specify_cli/workflows/expressions.pyindex 0c70a7b28..1805b4bc0 100644--- a/src/specify_cli/workflows/expressions.py+++ b/src/specify_cli/workflows/expressions.py@@ -535,6 +535,10 @@ def _evaluate_simple_expression(expr: str, namespace: dict[str, Any]) -> Any:items = [_evaluate_simple_expression(i.strip(), namespace)for i in _split_top_level_commas(inner)+ # Drop empty segments from trailing/leading/double commas ([1, 2,] ->+ # [1, 2], not [1, 2, None]). An intentional empty-string element+ # ('') strips to "''" (truthy), so ['', 'a'] is preserved.+ if i.strip()]return itemsdiff --git a/tests/test_workflows.py b/tests/test_workflows.pyindex 0af0fae85..0445f61ac 100644--- a/tests/test_workflows.py+++ b/tests/test_workflows.py@@ -404,6 +404,17 @@ class TestExpressions:assert evaluate_expression('{{ [["a", "b"], "c"] }}', ctx) == [["a", "b"], "c"]assert evaluate_expression("{{ [[1, 2], [3, 4]] }}", ctx) == [[1, 2], [3, 4]]+ def test_list_literal_ignores_trailing_and_empty_commas(self):+ from specify_cli.workflows.expressions import evaluate_expression+ from specify_cli.workflows.base import StepContext++ ctx = StepContext()+ # A trailing comma must not append a spurious None element.+ assert evaluate_expression("{{ [1, 2,] }}", ctx) == [1, 2]+ assert evaluate_expression("{{ [1,, 2] }}", ctx) == [1, 2]+ # …but an intentional empty-string element is still preserved.+ assert evaluate_expression("{{ ['', 'a'] }}", ctx) == ["", "a"]+def test_operator_splitting_is_quote_aware(self):from specify_cli.workflows.expressions import (evaluate_condition,