💫 Toolkit to help you get started with SDD or any other process!
fix: add JSON error handling to auth config loader (#3836)
Quratulain-bilale2d4cfafc44c
diff --git a/src/specify_cli/authentication/config.py b/src/specify_cli/authentication/config.pyindex b4a1753d2..95b8ff99b 100644--- a/src/specify_cli/authentication/config.py+++ b/src/specify_cli/authentication/config.py@@ -112,7 +112,10 @@ def load_auth_config(except OSError:pass # stat failed — skip permission check- raw = json.loads(config_path.read_text(encoding="utf-8"))+ try:+ raw = json.loads(config_path.read_text(encoding="utf-8"))+ except json.JSONDecodeError as exc:+ raise ValueError(f"{config_path} contains invalid JSON: {exc}") from excif not isinstance(raw, dict):raise ValueError(f"auth.json must be a JSON object, got {type(raw).__name__}")diff --git a/tests/test_authentication.py b/tests/test_authentication.pyindex 97ca1c6dd..38e12edd5 100644--- a/tests/test_authentication.py+++ b/tests/test_authentication.py@@ -205,7 +205,7 @@ class TestLoadAuthConfig:def test_invalid_json_raises(self, tmp_path):cfg = tmp_path / "auth.json"cfg.write_text("not json")- with pytest.raises(json.JSONDecodeError):+ with pytest.raises(ValueError, match="invalid JSON"):load_auth_config(cfg)def test_not_object_raises(self, tmp_path):