Skip to content

💫 Toolkit to help you get started with SDD or any other process!

fix(workflows): guard non-mapping 'inputs:' block in engine._resolve_inputs (#3696)

Ali jawwadea6843c1feb4
diff --git a/src/specify_cli/workflows/engine.py b/src/specify_cli/workflows/engine.py
index 98005a790..03afaee74 100644
--- a/src/specify_cli/workflows/engine.py
+++ b/src/specify_cli/workflows/engine.py
@@ -1400,6 +1400,14 @@ class WorkflowEngine:
) -> dict[str, Any]:
"""Resolve workflow inputs against definitions and provided values."""
resolved: dict[str, Any] = {}
+ # execute()/resume() accept UNVALIDATED definitions (load_workflow does
+ # not validate). A non-mapping ``inputs:`` block (bare ``inputs:`` ->
+ # None, or ``inputs: []``) is stored raw, so iterating ``.items()`` here
+ # would crash the run with AttributeError. Treat a non-mapping inputs
+ # block as "no inputs"; validate_workflow reports the malformed shape
+ # via its own isinstance check.
+ if not isinstance(definition.inputs, dict):
+ return {}
for name, input_def in definition.inputs.items():
if not isinstance(input_def, dict):
continue
diff --git a/tests/test_workflows.py b/tests/test_workflows.py
index 1c29ab56e..54cea4d77 100644
--- a/tests/test_workflows.py
+++ b/tests/test_workflows.py
@@ -3612,6 +3612,23 @@ class TestWorkflowDefinition:
assert definition.id == "test-workflow"
assert len(definition.inputs) == 2
+ @pytest.mark.parametrize(
+ "block",
+ [
+ "workflow:\n id: w\n name: W\nsteps: []\ninputs: []\n", # list
+ "workflow:\n id: w\n name: W\nsteps: []\ninputs:\n", # null
+ ],
+ )
+ def test_resolve_inputs_tolerates_non_mapping_inputs(self, block):
+ # execute()/resume() run UNVALIDATED definitions; a non-mapping `inputs:`
+ # block (list/null) is stored raw and would crash _resolve_inputs at
+ # `.items()`. It must be treated as "no inputs" instead.
+ from specify_cli.workflows.engine import WorkflowDefinition, WorkflowEngine
+
+ definition = WorkflowDefinition.from_string(block)
+ resolved = WorkflowEngine()._resolve_inputs(definition, {}) # must not raise
+ assert resolved == {}
+
def test_from_string_invalid(self):
from specify_cli.workflows.engine import WorkflowDefinition