💫 Toolkit to help you get started with SDD or any other process!
fix(integrations): dispatch Forge via prompt flag only (#4668)
Hesam Mohammadif2a2616125fd
diff --git a/src/specify_cli/integrations/forge/__init__.py b/src/specify_cli/integrations/forge/__init__.pyindex f455556e3..b57a8657d 100644--- a/src/specify_cli/integrations/forge/__init__.py+++ b/src/specify_cli/integrations/forge/__init__.py@@ -9,6 +9,7 @@ Forge has several unique behaviors compared to standard markdown agents:from __future__ import annotations+from collections.abc import Mapping, Sequencefrom pathlib import Pathfrom typing import Any@@ -103,6 +104,36 @@ class ForgeIntegration(MarkdownIntegration):invocation = f"{invocation} {args}"return invocation+ def build_exec_args(+ self,+ prompt: str,+ *,+ model: str | None = None,+ output_json: bool = True,+ integration_args: Sequence[str] | None = None,+ integration_options: Mapping[str, Any] | None = None,+ project_root: Path | None = None,+ ) -> list[str] | None:+ self.validate_runtime_config(integration_args, integration_options)+ args = [self._resolve_executable()]+ # Operator-injected extra args go before -p: Forge parses its global+ # flags ahead of the prompt flag, matching the opencode/goose/codex+ # ordering.+ self._apply_extra_args_env_var(args)++ args.extend(["-p", prompt])++ # `model` is deliberately dropped: Forge has no model-selection flag.+ # Model choice is a persisted setting (`forge config set model`), and+ # `--agent` takes an agent ID rather than a model identifier, so+ # forwarding the caller's model onto it would silently select the+ # wrong thing.+ #+ # `output_json` is likewise dropped: Forge has no `--output-format`.+ # Its machine-readable `--porcelain` exists only on certain+ # subcommands, not on the top-level prompt invocation.+ return args+def setup(self,project_root: Path,diff --git a/tests/integrations/test_integration_forge.py b/tests/integrations/test_integration_forge.pyindex 0559e9be9..830c506c4 100644--- a/tests/integrations/test_integration_forge.py+++ b/tests/integrations/test_integration_forge.py@@ -281,6 +281,74 @@ class TestForgeIntegration:f"{cmd_file.name} name field should start with 'speckit-': {name_value}")+ def test_build_exec_args_uses_prompt_flag(self):+ """Forge dispatches through ``-p``, with no extra flags appended.++ Forge accepts ``-p/--prompt``, but the inherited ``--model`` and+ ``--output-format`` do not exist in its CLI; sending them aborts the+ run at argument parsing with ``unexpected argument`` (#4666).+ """+ integration = get_integration("forge")++ args = integration.build_exec_args(+ "/speckit-specify build a login page",+ model="gpt-4o",+ output_json=True,+ )++ assert args == [+ "forge",+ "-p",+ "/speckit-specify build a login page",+ ]++ def test_build_exec_args_omits_output_format(self):+ """Forge has no ``--output-format``; requesting JSON must not add one."""+ integration = get_integration("forge")++ args = integration.build_exec_args("/speckit-plan add OAuth", output_json=True)++ assert args == ["forge", "-p", "/speckit-plan add OAuth"]+ assert "--output-format" not in args+ assert "json" not in args++ def test_build_exec_args_omits_model_flag(self):+ """Forge exposes no model-selection flag, so ``model`` is not forwarded.++ Model choice is a persisted setting (``forge config set model``).+ ``--agent`` takes an agent ID, not a model identifier, so remapping the+ caller's model onto it would select the wrong thing.+ """+ integration = get_integration("forge")++ args = integration.build_exec_args(+ "explain this repository",+ model="gpt-4o",+ output_json=False,+ )++ assert args == ["forge", "-p", "explain this repository"]+ assert "--model" not in args+ assert "gpt-4o" not in args++ def test_build_exec_args_applies_extra_args_before_prompt(self, monkeypatch):+ """Operator-injected flags precede ``-p`` so they stay global.++ Forge parses its global flags ahead of ``-p`` (``forge --verbose -p x``+ is accepted), matching the opencode / goose / codex ordering.+ """+ monkeypatch.setenv("SPECKIT_INTEGRATION_FORGE_EXTRA_ARGS", "--verbose")+ integration = get_integration("forge")++ args = integration.build_exec_args("check the build", output_json=True)++ assert args == [+ "forge",+ "--verbose",+ "-p",+ "check the build",+ ]+class TestForgeCommandRegistrar:"""Test CommandRegistrar's Forge-specific name formatting."""