Skip to content

πŸ’« Toolkit to help you get started with SDD or any other process!

fix(workflows): fan-out max_concurrency .inf falls back to sequential, not crash (#3521)

Ali jawwadfb076a38b873
diff --git a/src/specify_cli/workflows/engine.py b/src/specify_cli/workflows/engine.py
index ed52710be..0c2a06f77 100644
--- a/src/specify_cli/workflows/engine.py
+++ b/src/specify_cli/workflows/engine.py
@@ -1197,9 +1197,9 @@ class WorkflowEngine:
already flipped), so the prefix never drops the actual halting item.
``max_concurrency`` is coerced with ``int()``; a value that cannot be
- coerced (``None``, a non-numeric string, …) or that coerces to <= 1 runs
- sequentially, while a numeric string like ``"4"`` or a float like ``4.0``
- is honored.
+ coerced (``None``, a non-numeric string, ``.inf``/``.nan``, …) or that
+ coerces to <= 1 runs sequentially, while a numeric string like ``"4"`` or
+ a float like ``4.0`` is honored.
"""
if not items:
return []
@@ -1207,7 +1207,9 @@ class WorkflowEngine:
halting = (RunStatus.PAUSED, RunStatus.FAILED, RunStatus.ABORTED)
try:
workers = max(1, int(max_concurrency))
- except (TypeError, ValueError):
+ except (TypeError, ValueError, OverflowError):
+ # OverflowError: int(float("inf")) β€” a YAML ``max_concurrency: .inf``
+ # would otherwise crash the whole run instead of falling back.
workers = 1
# Never spin up more workers than there is work β€” bounds a user-controlled
# max_concurrency from over-allocating threads.
diff --git a/tests/test_workflows.py b/tests/test_workflows.py
index a76628311..468aad53b 100644
--- a/tests/test_workflows.py
+++ b/tests/test_workflows.py
@@ -2727,8 +2727,13 @@ class TestFanOutConcurrency:
results, _ = self._run(tmp_path, list(range(n)), n, on_item)
assert results == [{"seen": i} for i in range(n)]
- @pytest.mark.parametrize("bad", [0, -1, None, "abc", 1.0])
+ @pytest.mark.parametrize(
+ "bad", [0, -1, None, "abc", 1.0, float("inf"), float("nan")]
+ )
def test_invalid_max_concurrency_coerces_to_sequential(self, tmp_path, bad):
+ # float("inf") -> int() raises OverflowError (not TypeError/ValueError);
+ # it must fall back to sequential like any other uncoercible value, not
+ # crash the run.
results, _ = self._run(tmp_path, list(range(4)), bad)
assert results == [{"seen": i} for i in range(4)]