Skip to content

SpiderFoot automates OSINT for threat intelligence and mapping your attack surface.

sfp_tldsearch: Return if sf.domainKeyword(eventData) returns no keywords (#1353)

bcoles28b37f22cd1f
diff --git a/modules/sfp_tldsearch.py b/modules/sfp_tldsearch.py
index a1eb9084..6d5f2997 100644
--- a/modules/sfp_tldsearch.py
+++ b/modules/sfp_tldsearch.py
@@ -156,8 +156,12 @@ class sfp_tldsearch(SpiderFootPlugin):
self.results[eventData] = True
keyword = self.sf.domainKeyword(eventData, self.opts['_internettlds'])
- self.sf.debug("Keyword extracted from " + eventData + ": " + keyword)
- targetList = list()
+
+ if not keyword:
+ self.sf.error(f"Failed to extract keyword from {eventData}")
+ return
+
+ self.sf.debug(f"Keyword extracted from {eventData}: {keyword}")
if keyword in self.results:
return
@@ -165,6 +169,7 @@ class sfp_tldsearch(SpiderFootPlugin):
self.results[keyword] = True
# Look through all TLDs for the existence of this target keyword
+ targetList = list()
for tld in self.opts['_internettlds']:
if type(tld) != str:
tld = str(tld.strip(), errors='ignore')
diff --git a/test/unit/test_spiderfoot.py b/test/unit/test_spiderfoot.py
index 249da01f..cf96e2e2 100644
--- a/test/unit/test_spiderfoot.py
+++ b/test/unit/test_spiderfoot.py
@@ -379,6 +379,10 @@ class TestSpiderFoot(unittest.TestCase):
self.assertIsInstance(keyword, str)
self.assertEqual('spiderfoot', keyword)
+ keyword = sf.domainKeyword('spiderfööt.example', sf.opts.get('_internettlds'))
+ self.assertIsInstance(keyword, str)
+ self.assertEqual('spiderfööt', keyword)
+
def test_domain_keyword_invalid_domain_should_return_none(self):
"""
Test domainKeyword(self, domain, tldList)
@@ -394,6 +398,10 @@ class TestSpiderFoot(unittest.TestCase):
self.assertEqual(None, keyword)
keyword = sf.domainKeyword("net", sf.opts.get('_internettlds'))
self.assertEqual(None, keyword)
+ keyword = sf.domainKeyword(".net", sf.opts.get('_internettlds'))
+ self.assertEqual(None, keyword)
+ keyword = sf.domainKeyword(".", sf.opts.get('_internettlds'))
+ self.assertEqual(None, keyword)
def test_domain_keywords_should_return_a_set(self):
"""