Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
add mocked test for updating account with password mismatch error
KacperMekarski01a158e24f60
diff --git a/api/spec/requests/spree/api/v2/storefront/account_spec.rb b/api/spec/requests/spree/api/v2/storefront/account_spec.rbindex 935661ff45..fb9f9fb6c4 100644--- a/api/spec/requests/spree/api/v2/storefront/account_spec.rb+++ b/api/spec/requests/spree/api/v2/storefront/account_spec.rb@@ -6,6 +6,30 @@ describe 'Storefront API v2 Account spec', type: :request dolet!(:user) { create(:user_with_addresses) }let(:headers) { headers_bearer }+ shared_examples 'mock tests for failed user saving' do+ it { expect(service).to receive(:call).with(permitted_params).and_return(result) }+ it { expect(result).to receive(:success?).and_return(false) }+ it { expect(result).to receive(:error).and_return(error) }+ it { expect(error).to receive_message_chain(:full_messages, :to_sentence).and_return("Password Confirmation doesn't match Password") }+ end++ shared_context 'stubs for failed user saving' do+ before do+ allow(service).to receive(:call).with(permitted_params).and_return(result)+ allow(result).to receive(:success?).and_return(false)+ allow(result).to receive(:error).and_return(error)+ allow(error).to receive(:is_a?).with(ActiveModel::Errors).and_return(true)+ allow(error).to receive(:messages).and_return({ password_confirmation: "doesn't match Password" })+ allow(error).to receive_message_chain(:full_messages, :to_sentence).and_return("Password Confirmation doesn't match Password")+ end+ end++ shared_examples 'password mismatched error' do+ it 'returns error' do+ expect(json_response['error']).to eq "Password Confirmation doesn't match Password"+ end+ end+describe 'account#show' dobefore { get '/api/v2/storefront/account', headers: headers }@@ -95,37 +119,29 @@ describe 'Storefront API v2 Account spec', type: :request dopassword_confirmation: ''}end- let(:create_service) { double(Spree::Account::Create) }+ let(:service) { double(Spree::Account::Create) }let(:permitted_params) { {user_params: ActionController::Parameters.new(params).require(:user).permit!} }let(:result) { instance_double(Spree::ServiceModule::Result) }let(:error) { instance_double(ActiveModel::Errors) }before do- allow(Spree::Api::Dependencies).to receive_message_chain(:storefront_account_create_service, :constantize).and_return(create_service)- allow(create_service).to receive(:call).with(permitted_params).and_return(result)- allow(result).to receive(:success?).and_return(false)- allow(result).to receive(:error).and_return(error)- allow(error).to receive(:is_a?).with(ActiveModel::Errors).and_return(true)- allow(error).to receive(:messages).and_return({ password_confirmation: "doesn't match Password" })- allow(error).to receive_message_chain(:full_messages, :to_sentence).and_return("Password Confirmation doesn't match Password")+ allow(Spree::Api::Dependencies).to receive_message_chain(:storefront_account_create_service, :constantize).and_return(service)end+ include_context 'stubs for failed user saving'+describe 'mocks' doafter { post "/api/v2/storefront/account", params: params }- it { expect(Spree::Api::Dependencies).to receive_message_chain(:storefront_account_create_service, :constantize).and_return(create_service) }- it { expect(create_service).to receive(:call) }- it { expect(result).to receive(:success?).and_return(false) }- it { expect(result).to receive(:error).and_return(error) }- it { expect(error).to receive_message_chain(:full_messages, :to_sentence).and_return("Password Confirmation doesn't match Password") }+ it { expect(Spree::Api::Dependencies).to receive_message_chain(:storefront_account_create_service, :constantize).and_return(service) }++ it_behaves_like 'mock tests for failed user saving'enddescribe 'response' dobefore { post "/api/v2/storefront/account", params: params }- it 'returns errors' do- expect(json_response['error']).to eq "Password Confirmation doesn't match Password"- end+ it_behaves_like 'password mismatched error'endendend@@ -186,17 +202,53 @@ describe 'Storefront API v2 Account spec', type: :request doendcontext 'invalid request' do- let!(:other_user) { create(:user_with_addresses) }- let(:new_default_bill_address) { create(:address, user: other_user) }- let(:new_default_ship_address) { create(:address, user: other_user) }+ context 'wrong default address' do+ let!(:other_user) { create(:user_with_addresses) }+ let(:new_default_bill_address) { create(:address, user: other_user) }+ let(:new_default_ship_address) { create(:address, user: other_user) }- before { patch "/api/v2/storefront/account", params: params, headers: headers }+ before { patch "/api/v2/storefront/account", params: params, headers: headers }- it 'returns errors' do- expect(json_response['errors']).to eq(- 'bill_address_id' => ["belongs to other user"],- 'ship_address_id' => ["belongs to other user"]- )+ it 'returns errors' do+ expect(json_response['errors']).to eq(+ 'bill_address_id' => ["belongs to other user"],+ 'ship_address_id' => ["belongs to other user"]+ )+ end+ end++ context 'password mismatch error' do+ let(:new_attributes) do+ {+ email: '[email protected]',+ password: 'newpassword123',+ password_confirmation: ''+ }+ end+ let(:service) { double(Spree::Account::Update) }+ let(:permitted_params) { { user_params: ActionController::Parameters.new(params).require(:user).permit!, user: user } }+ let(:result) { instance_double(Spree::ServiceModule::Result) }+ let(:error) { instance_double(ActiveModel::Errors) }++ before do+ allow(Spree::Api::Dependencies).to receive_message_chain(:storefront_account_update_service, :constantize).and_return(service)+ end++ include_context 'stubs for failed user saving'++ describe 'mocks' do+ after { patch "/api/v2/storefront/account", params: params, headers: headers }++ it { expect(Spree::Api::Dependencies).to receive_message_chain(:storefront_account_update_service, :constantize).and_return(service) }++ it_behaves_like 'mock tests for failed user saving'+ end++ describe 'response' do+ before { patch "/api/v2/storefront/account", params: params, headers: headers }++ it_behaves_like 'password mismatched error'+ endendend