Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Ability to create oAuth application with blank redirect_uri

Damian Legawiec0415ff207a6a
diff --git a/api/app/models/spree/oauth_application.rb b/api/app/models/spree/oauth_application.rb
index 899bac95d8..ec86fbcb7a 100644
--- a/api/app/models/spree/oauth_application.rb
+++ b/api/app/models/spree/oauth_application.rb
@@ -3,5 +3,13 @@ module Spree
include ::Doorkeeper::Orm::ActiveRecord::Mixins::Application
self.table_name = 'spree_oauth_applications'
+
+ before_validation :set_blank_for_redirect_uri
+
+ private
+
+ def set_blank_for_redirect_uri
+ self.redirect_uri = '' if redirect_uri.nil?
+ end
end
end
diff --git a/api/lib/spree/api/testing_support/factories/oauth_application_factory.rb b/api/lib/spree/api/testing_support/factories/oauth_application_factory.rb
new file mode 100644
index 0000000000..782412115a
--- /dev/null
+++ b/api/lib/spree/api/testing_support/factories/oauth_application_factory.rb
@@ -0,0 +1,8 @@
+FactoryBot.define do
+ factory :oauth_application, class: Spree::OauthApplication do
+ name { "Admin Panel" }
+ scopes { "admin" }
+ uid { "admin_panel" }
+ secret { "secret" }
+ end
+end
diff --git a/api/spec/models/spree/oauth_application_spec.rb b/api/spec/models/spree/oauth_application_spec.rb
new file mode 100644
index 0000000000..1fd51edd3e
--- /dev/null
+++ b/api/spec/models/spree/oauth_application_spec.rb
@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+module Spree
+ describe OauthApplication, type: :model do
+ subject { build(:oauth_application) }
+
+ it 'creates a valid oauth application' do
+ expect(subject).to be_valid
+ end
+ end
+end