Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

move create account service from spree_auth_devise to spree

KacperMekarski057b087cc7c4
diff --git a/api/app/models/spree/api_dependencies.rb b/api/app/models/spree/api_dependencies.rb
index a262fd934b..b6f5713f54 100644
--- a/api/app/models/spree/api_dependencies.rb
+++ b/api/app/models/spree/api_dependencies.rb
@@ -16,7 +16,7 @@ module Spree
:storefront_cart_update_service, :storefront_cart_estimate_shipping_rates_service, :storefront_estimated_shipment_serializer,
:storefront_store_serializer, :storefront_address_serializer, :storefront_order_serializer,
:storefront_account_create_address_service, :storefront_account_update_address_service, :storefront_address_finder,
- :storefront_account_update_service, :storefront_collection_sorter, :error_handler
+ :storefront_account_create_service, :storefront_account_update_service, :storefront_collection_sorter, :error_handler
].freeze
attr_accessor *INJECTION_POINTS
@@ -52,6 +52,7 @@ module Spree
@storefront_checkout_get_shipping_rates_service = Spree::Dependencies.checkout_get_shipping_rates_service
# account services
+ @storefront_account_create_service = Spree::Dependencies.account_create_service
@storefront_account_update_service = Spree::Dependencies.account_update_service
@storefront_account_create_address_service = Spree::Dependencies.account_create_address_service
@storefront_account_update_address_service = Spree::Dependencies.account_update_address_service
diff --git a/core/app/models/spree/app_dependencies.rb b/core/app/models/spree/app_dependencies.rb
index 6c69622b39..35124ccbfa 100644
--- a/core/app/models/spree/app_dependencies.rb
+++ b/core/app/models/spree/app_dependencies.rb
@@ -12,8 +12,8 @@ module Spree
:coupon_handler, :country_finder, :current_order_finder, :credit_card_finder,
:completed_order_finder, :order_sorter, :cart_compare_line_items_service, :collection_paginator, :products_sorter,
:products_finder, :taxon_finder, :line_item_by_variant_finder, :cart_estimate_shipping_rates_service,
- :account_create_address_service, :account_update_address_service, :account_update_service, :address_finder,
- :collection_sorter, :error_handler
+ :account_create_address_service, :account_update_address_service, :account_create_service, :account_update_service,
+ :address_finder, :collection_sorter, :error_handler
].freeze
attr_accessor *INJECTION_POINTS
@@ -64,6 +64,7 @@ module Spree
@coupon_handler = 'Spree::PromotionHandler::Coupon'
# account
+ @account_create_service = 'Spree::Account::Create'
@account_update_service = 'Spree::Account::Update'
@account_create_address_service = 'Spree::Account::Addresses::Create'
@account_update_address_service = 'Spree::Account::Addresses::Update'
diff --git a/core/app/services/spree/account/create.rb b/core/app/services/spree/account/create.rb
new file mode 100644
index 0000000000..674c4834f5
--- /dev/null
+++ b/core/app/services/spree/account/create.rb
@@ -0,0 +1,17 @@
+module Spree
+ module Account
+ class Create
+ prepend Spree::ServiceModule::Base
+
+ def call(user_params: {})
+ user = Spree.user_class.new(user_params)
+
+ if user.save
+ success(user)
+ else
+ failure(user)
+ end
+ end
+ end
+ end
+end
diff --git a/core/spec/services/spree/account/create_spec.rb b/core/spec/services/spree/account/create_spec.rb
new file mode 100644
index 0000000000..fb2d8a01c3
--- /dev/null
+++ b/core/spec/services/spree/account/create_spec.rb
@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+module Spree
+ describe Account::Create do
+ subject { described_class }
+
+ let(:result) { subject.call(user_params: user_params) }
+ let(:value) { result.value }
+
+ describe '#call' do
+ context 'with valid params' do
+ let(:user_params) do
+ {
+ email: '[email protected]',
+ password: 'password123',
+ password_confirmation: 'password123'
+ }
+ end
+
+ it 'creates new user' do
+ expect { result }.to change(Spree.user_class, :count)
+ end
+
+ it 'creates user with given params' do
+ expect(value).to have_attributes(user_params)
+ end
+
+ it 'result is successful' do
+ expect(result).to be_success
+ end
+ end
+
+ # did not add unhappy path because validations are included in spree_auth_devise gem
+ end
+ end
+end