Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fixed Admin Page Sections flaky test (#12848)

Damian Legawiec05b51fa2e81a
diff --git a/admin/spec/controllers/spree/admin/page_sections_controller_spec.rb b/admin/spec/controllers/spree/admin/page_sections_controller_spec.rb
index 180752cf10..054c9ef3a4 100644
--- a/admin/spec/controllers/spree/admin/page_sections_controller_spec.rb
+++ b/admin/spec/controllers/spree/admin/page_sections_controller_spec.rb
@@ -4,10 +4,10 @@ RSpec.describe Spree::Admin::PageSectionsController, type: :controller do
stub_authorization!
render_views
- let(:store) { @default_store }
- let(:parent_theme) { create(:theme, store: store) }
- let(:theme) { create(:theme, :preview, parent: parent_theme) }
- let(:page) { create(:page, :preview, pageable: parent_theme) }
+ let!(:store) { Spree::Store.default }
+ let!(:parent_theme) { create(:theme, store: store) }
+ let!(:theme) { create(:theme, :preview, parent: parent_theme) }
+ let!(:page) { create(:page, :preview, pageable: parent_theme) }
before do
session[:page_preview_id] = page.id
@@ -69,7 +69,7 @@ RSpec.describe Spree::Admin::PageSectionsController, type: :controller do
end
describe '#update' do
- let!(:page_section) { create(:header_page_section, pageable: theme) }
+ let!(:page_section) { create(:featured_taxon_page_section, pageable: page) }
it 'updates the page section' do
put :update, params: { id: page_section.id, page_section: { preferred_top_padding: 100 } }, format: :turbo_stream
@@ -84,7 +84,7 @@ RSpec.describe Spree::Admin::PageSectionsController, type: :controller do
end
context "with action text field" do
- let(:page_section) { create(:announcement_bar_page_section, pageable: theme) }
+ let!(:page_section) { create(:announcement_bar_page_section, pageable: theme) }
it "persists page section action text" do
put :update, params: { id: page_section.id, page_section: { text: "Welcome to our amazing store" } }, format: :turbo_stream