Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Don't cast eligible values to integers in Option Value Promo Rule (#11663)

Damian Legawiec08e45f327660
diff --git a/core/app/models/spree/promotion/rules/option_value.rb b/core/app/models/spree/promotion/rules/option_value.rb
index 109a349b6c..c5932eb3df 100644
--- a/core/app/models/spree/promotion/rules/option_value.rb
+++ b/core/app/models/spree/promotion/rules/option_value.rb
@@ -4,9 +4,9 @@ module Spree
module OptionValueWithNumerificationSupport
def preferred_eligible_values
values = super || {}
- Hash[values.keys.map(&:to_i).zip(
+ Hash[values.keys.zip(
values.values.map do |v|
- (v.is_a?(Array) ? v : v.split(',')).map(&:to_i)
+ (v.is_a?(Array) ? v : v.split(','))
end
)]
end
diff --git a/core/spec/models/spree/promotion/rules/option_value_spec.rb b/core/spec/models/spree/promotion/rules/option_value_spec.rb
index c5480b5e4d..6356fd31dc 100644
--- a/core/spec/models/spree/promotion/rules/option_value_spec.rb
+++ b/core/spec/models/spree/promotion/rules/option_value_spec.rb
@@ -8,7 +8,7 @@ describe Spree::Promotion::Rules::OptionValue do
it 'assigns a nicely formatted hash' do
rule.preferred_eligible_values = Hash['5' => '1,2', '6' => '1']
- expect(subject).to eq Hash[5 => [1, 2], 6 => [1]]
+ expect(subject).to eq Hash['5' => ['1', '2'], '6' => ['1']]
end
end