Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Fixes GHSA-3ghg-3787-w2xr Unauthenticated IDOR - Guest Address (#13422)
Damian Legawiec0bbbdef952b9
diff --git a/core/app/models/spree/ability.rb b/core/app/models/spree/ability.rbindex 2b87f47840..5aa1dd5000 100644--- a/core/app/models/spree/ability.rb+++ b/core/app/models/spree/ability.rb@@ -143,7 +143,8 @@ module Spreecan :update, ::Spree::Order do |order, token|!order.completed? && (order.user == user || order.token && token == order.token)end- can :manage, ::Spree::Address, user_id: user.id+ # Address management - only for persisted users with matching user_id+ can :manage, ::Spree::Address, user_id: user.id if user.persisted?can [:read, :destroy], ::Spree::CreditCard, user_id: user.idcan :read, ::Spree::Productcan :read, ::Spree::ProductPropertydiff --git a/core/app/models/spree/permission_sets/default_customer.rb b/core/app/models/spree/permission_sets/default_customer.rbindex 7d12fd627a..083b8fbee7 100644--- a/core/app/models/spree/permission_sets/default_customer.rb+++ b/core/app/models/spree/permission_sets/default_customer.rb@@ -43,8 +43,8 @@ module Spreecan :create, Spree.user_classcan [:show, :update, :destroy], Spree.user_class, id: user.id- # Address management- can :manage, Spree::Address, user_id: user.id+ # Address management - only for persisted users with matching user_id+ can :manage, Spree::Address, user_id: user.id if user.persisted?# Credit card managementcan [:read, :destroy], Spree::CreditCard, user_id: user.iddiff --git a/core/spec/models/spree/ability_spec.rb b/core/spec/models/spree/ability_spec.rbindex 7128bc13a1..401c3fab5a 100644--- a/core/spec/models/spree/ability_spec.rb+++ b/core/spec/models/spree/ability_spec.rb@@ -293,5 +293,54 @@ describe Spree::Ability, type: :model doit_behaves_like 'read only'endend++ context 'for Address (IDOR vulnerability prevention)' do+ let(:guest_address) { create(:address, user_id: nil) }++ context 'with non-persisted guest user' do+ let(:guest_user) { Spree.user_class.new }+ let(:guest_ability) { Spree::Ability.new(guest_user) }++ it 'cannot read guest addresses with nil user_id' do+ expect(guest_ability).not_to be_able_to :read, guest_address+ end++ it 'cannot edit guest addresses with nil user_id' do+ expect(guest_ability).not_to be_able_to :edit, guest_address+ end++ it 'cannot update guest addresses with nil user_id' do+ expect(guest_ability).not_to be_able_to :update, guest_address+ end++ it 'cannot destroy guest addresses with nil user_id' do+ expect(guest_ability).not_to be_able_to :destroy, guest_address+ end++ it 'cannot manage any address' do+ expect(guest_ability).not_to be_able_to :manage, guest_address+ end+ end++ context 'with persisted user' do+ let(:persisted_user) { create(:user) }+ let(:persisted_ability) { Spree::Ability.new(persisted_user) }+ let(:own_address) { create(:address, user_id: persisted_user.id) }++ it 'can manage own address' do+ expect(persisted_ability).to be_able_to :manage, own_address+ end++ it 'cannot manage guest addresses' do+ expect(persisted_ability).not_to be_able_to :manage, guest_address+ end++ it 'cannot manage other user addresses' do+ other_user = create(:user)+ other_address = create(:address, user_id: other_user.id)+ expect(persisted_ability).not_to be_able_to :manage, other_address+ end+ end+ endendenddiff --git a/core/spec/models/spree/permission_sets/default_customer_spec.rb b/core/spec/models/spree/permission_sets/default_customer_spec.rbindex 7fd5945459..b6e52d6d2c 100644--- a/core/spec/models/spree/permission_sets/default_customer_spec.rb+++ b/core/spec/models/spree/permission_sets/default_customer_spec.rb@@ -123,6 +123,32 @@ RSpec.describe Spree::PermissionSets::DefaultCustomer doit 'prevents managing other user address' doexpect(ability.can?(:manage, other_address)).to be falseend++ context 'with guest user (non-persisted)' do+ let(:guest_user) { Spree.user_class.new }+ let(:guest_ability) { Spree::Ability.new(guest_user) }+ let(:guest_permission_set) { described_class.new(guest_ability) }+ let(:guest_address) { build(:address, user_id: nil) }+ let(:other_guest_address) { create(:address, user_id: nil) }++ before { guest_permission_set.activate! }++ it 'prevents guest user from managing addresses with nil user_id (IDOR protection)' do+ expect(guest_ability.can?(:manage, guest_address)).to be false+ end++ it 'prevents guest user from editing other guest addresses (IDOR protection)' do+ expect(guest_ability.can?(:edit, other_guest_address)).to be false+ end++ it 'prevents guest user from updating other guest addresses (IDOR protection)' do+ expect(guest_ability.can?(:update, other_guest_address)).to be false+ end++ it 'prevents guest user from reading other guest addresses (IDOR protection)' do+ expect(guest_ability.can?(:read, other_guest_address)).to be false+ end+ endendcontext 'credit card permissions' dodiff --git a/storefront/app/controllers/spree/addresses_controller.rb b/storefront/app/controllers/spree/addresses_controller.rbindex d498bfab53..3f6362031b 100644--- a/storefront/app/controllers/spree/addresses_controller.rb+++ b/storefront/app/controllers/spree/addresses_controller.rb@@ -1,6 +1,7 @@module Spreeclass AddressesController < Spree::StoreControllerhelper Spree::AddressesHelper+ before_action :require_userbefore_action :load_and_authorize_address, except: [:index]def creatediff --git a/storefront/spec/controllers/spree/addresses_controller_spec.rb b/storefront/spec/controllers/spree/addresses_controller_spec.rbindex 2b788fca02..4e7cd4f474 100644--- a/storefront/spec/controllers/spree/addresses_controller_spec.rb+++ b/storefront/spec/controllers/spree/addresses_controller_spec.rb@@ -312,4 +312,156 @@ describe Spree::AddressesController, type: :controller doendendend++end++# Separate describe block for security tests - without mocked authorization+describe Spree::AddressesController, 'security', type: :controller do+ let(:store) { @default_store }+ let(:country) { store.default_country || create(:country_us) }+ let(:state) { create(:state, country: country, name: 'New York', abbr: 'NY') }+ let(:user) { create(:user) }++ render_views++ context 'authentication requirement (IDOR vulnerability fix)' do+ let(:guest_address) { create(:address, user_id: nil, country: country, state: state) }++ before do+ allow(controller).to receive_messages try_spree_current_user: nil+ allow(controller).to receive_messages spree_current_user: nil+ end++ describe '#edit' do+ it 'requires authentication and redirects to login' do+ get :edit, params: { id: guest_address.id }+ expect(response).to have_http_status(:redirect)+ end+ end++ describe '#update' do+ let(:address_params) { guest_address.attributes.symbolize_keys.merge(firstname: 'Hacker') }++ it 'requires authentication and redirects to login' do+ put :update, params: { id: guest_address.id, address: address_params }+ expect(response).to have_http_status(:redirect)+ end++ it 'does not update the address when not authenticated' do+ original_firstname = guest_address.firstname+ put :update, params: { id: guest_address.id, address: address_params }+ expect(guest_address.reload.firstname).to eq(original_firstname)+ end+ end++ describe '#destroy' do+ it 'requires authentication and redirects to login' do+ delete :destroy, params: { id: guest_address.id }+ expect(response).to have_http_status(:redirect)+ end++ it 'does not destroy the address when not authenticated' do+ delete :destroy, params: { id: guest_address.id }+ expect(Spree::Address.find_by(id: guest_address.id)).to be_present+ end+ end++ describe '#new' do+ it 'requires authentication and redirects to login' do+ get :new+ expect(response).to have_http_status(:redirect)+ end+ end++ describe '#create' do+ let(:address_params) do+ build(:address, country: country, state: state).attributes.except('created_at', 'updated_at')+ end++ it 'requires authentication and redirects to login' do+ post :create, params: { address: address_params }+ expect(response).to have_http_status(:redirect)+ end+ end+ end++ context 'when authenticated user tries to access another users address' do+ let(:other_user) { create(:user) }+ let(:other_user_address) { create(:address, user: other_user, country: country, state: state) }++ before do+ allow(controller).to receive_messages try_spree_current_user: user+ allow(controller).to receive_messages spree_current_user: user+ end++ describe '#edit' do+ it 'denies access to other users address' do+ get :edit, params: { id: other_user_address.id }+ expect(response).to have_http_status(:redirect)+ expect(response).to redirect_to(spree.forbidden_path)+ end+ end++ describe '#update' do+ let(:address_params) { other_user_address.attributes.symbolize_keys.merge(firstname: 'Hacker') }++ it 'denies update to other users address' do+ put :update, params: { id: other_user_address.id, address: address_params }+ expect(response).to have_http_status(:redirect)+ expect(response).to redirect_to(spree.forbidden_path)+ end++ it 'does not update the address when denied' do+ original_firstname = other_user_address.firstname+ put :update, params: { id: other_user_address.id, address: address_params }+ expect(other_user_address.reload.firstname).to eq(original_firstname)+ end+ end++ describe '#destroy' do+ it 'denies destroy of other users address' do+ delete :destroy, params: { id: other_user_address.id }+ expect(response).to have_http_status(:redirect)+ expect(response).to redirect_to(spree.forbidden_path)+ end++ it 'does not destroy the address when denied' do+ delete :destroy, params: { id: other_user_address.id }+ expect(Spree::Address.find_by(id: other_user_address.id)).to be_present+ end+ end+ end++ context 'when authenticated user accesses their own address' do+ let(:own_address) { create(:address, user: user, country: country, state: state) }++ before do+ allow(controller).to receive_messages try_spree_current_user: user+ allow(controller).to receive_messages spree_current_user: user+ end++ describe '#edit' do+ it 'allows access to own address' do+ get :edit, params: { id: own_address.id }+ expect(response).to have_http_status(:ok)+ end+ end++ describe '#update' do+ let(:address_params) { own_address.attributes.symbolize_keys.merge(firstname: 'Updated') }++ it 'allows update to own address' do+ put :update, params: { id: own_address.id, address: address_params }+ expect(response).to have_http_status(:redirect)+ expect(response).not_to redirect_to(spree.forbidden_path)+ end+ end++ describe '#destroy' do+ it 'allows destroy of own address' do+ delete :destroy, params: { id: own_address.id }+ expect(response).to have_http_status(:see_other)+ end+ end+ endend