Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fix: the customers CSV export finishes again (#14726)

Damian Legawiec10cf651c31b4
diff --git a/spree/core/app/models/spree/exports/customers.rb b/spree/core/app/models/spree/exports/customers.rb
index b025f39aaf..6c41af2e8f 100644
--- a/spree/core/app/models/spree/exports/customers.rb
+++ b/spree/core/app/models/spree/exports/customers.rb
@@ -3,8 +3,8 @@ module Spree
class Customers < Spree::Export
def scope_includes
[
- { bill_address: :state },
- { ship_address: :state },
+ :bill_address,
+ :ship_address,
{ custom_fields: :custom_field_definition }
]
end
diff --git a/spree/core/spec/models/spree/export_spec.rb b/spree/core/spec/models/spree/export_spec.rb
index 9f84f68717..2fa0a83631 100644
--- a/spree/core/spec/models/spree/export_spec.rb
+++ b/spree/core/spec/models/spree/export_spec.rb
@@ -75,6 +75,19 @@ RSpec.describe Spree::Export, :job, type: :model do
export.save!
expect { export.generate }.to change(export.attachment, :attached?).from(false).to(true)
end
+
+ it 'writes a row for a customer with addresses' do
+ customer = create(:customer_with_addresses)
+ export.save!
+ export.generate
+
+ row = CSV.parse(export.attachment.download, headers: true).find { |r| r['Email'] == customer.email }
+ expect(row.to_h).to include(
+ 'City' => customer.bill_address.city,
+ 'Province Code' => customer.bill_address.state_code,
+ 'Country Code' => customer.bill_address.country.iso
+ )
+ end
end
# Header and value rows are built in different objects, so they have to