Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Remove legacy API v2 dependency registrations

Damian Legawiec10df66f3aa7e
diff --git a/spree/api/lib/spree/api.rb b/spree/api/lib/spree/api.rb
index 093d3c7b6b..518f2e1bd9 100644
--- a/spree/api/lib/spree/api.rb
+++ b/spree/api/lib/spree/api.rb
@@ -12,10 +12,10 @@ module Spree
# API dependencies accessor for cleaner access to API dependencies
#
# @example Getting a dependency (returns resolved class)
- # Spree.api.storefront_coupon_handler.call(order: order, coupon_code: code)
+ # Spree.api.product_serializer.render(product)
#
# @example Setting a dependency
- # Spree.api.storefront_coupon_handler = MyApp::CouponHandler
+ # Spree.api.product_serializer = MyApp::ProductSerializer
#
# @return [Spree::ApiDependenciesAccessor] the API dependencies accessor
def self.api
diff --git a/spree/api/lib/spree/api/dependencies.rb b/spree/api/lib/spree/api/dependencies.rb
index 106e83bfe5..42fe3fc65b 100644
--- a/spree/api/lib/spree/api/dependencies.rb
+++ b/spree/api/lib/spree/api/dependencies.rb
@@ -4,93 +4,6 @@ module Spree
module Api
class ApiDependencies
INJECTION_POINTS_WITH_DEFAULTS = {
- # Legacy API v2 dependencies - will be removed in Spree 6
- # cart services
- storefront_cart_create_service: -> { Spree::Dependencies.cart_create_service },
- storefront_cart_add_item_service: -> { Spree::Dependencies.cart_add_item_service },
- storefront_cart_compare_line_items_service: -> { Spree::Dependencies.cart_compare_line_items_service },
- storefront_cart_update_service: -> { Spree::Dependencies.cart_update_service },
- storefront_cart_remove_line_item_service: -> { Spree::Dependencies.cart_remove_line_item_service },
- storefront_cart_remove_item_service: -> { Spree::Dependencies.cart_remove_item_service },
- storefront_cart_set_item_quantity_service: -> { Spree::Dependencies.cart_set_item_quantity_service },
- storefront_cart_recalculate_service: -> { Spree::Dependencies.cart_recalculate_service },
- storefront_cart_estimate_shipping_rates_service: -> { Spree::Dependencies.cart_estimate_shipping_rates_service },
- storefront_cart_empty_service: -> { Spree::Dependencies.cart_empty_service },
- storefront_cart_destroy_service: -> { Spree::Dependencies.cart_destroy_service },
- storefront_cart_associate_service: -> { Spree::Dependencies.cart_associate_service },
- storefront_cart_change_currency_service: -> { Spree::Dependencies.cart_change_currency_service },
-
- # coupon code handler
- storefront_coupon_handler: -> { Spree::Dependencies.coupon_handler },
-
- # checkout services
- storefront_checkout_next_service: -> { Spree::Dependencies.checkout_next_service },
- storefront_checkout_advance_service: -> { Spree::Dependencies.checkout_advance_service },
- storefront_checkout_update_service: -> { Spree::Dependencies.checkout_update_service },
- storefront_checkout_complete_service: -> { Spree::Dependencies.checkout_complete_service },
- storefront_checkout_add_store_credit_service: -> { Spree::Dependencies.checkout_add_store_credit_service },
- storefront_checkout_remove_store_credit_service: -> { Spree::Dependencies.checkout_remove_store_credit_service },
- storefront_checkout_get_shipping_rates_service: -> { Spree::Dependencies.checkout_get_shipping_rates_service },
- storefront_checkout_select_shipping_method_service: -> { Spree::Dependencies.checkout_select_shipping_method_service },
-
- # gift cards
- storefront_gift_card_apply_service: -> { Spree::Dependencies.gift_card_apply_service },
- storefront_gift_card_remove_service: -> { Spree::Dependencies.gift_card_remove_service },
-
- # account services
- storefront_account_create_service: -> { Spree::Dependencies.account_create_service },
- storefront_account_update_service: -> { Spree::Dependencies.account_update_service },
-
- # address services
- storefront_address_create_service: -> { Spree::Dependencies.address_create_service },
- storefront_address_update_service: -> { Spree::Dependencies.address_update_service },
-
- # credit card services
- storefront_credit_cards_destroy_service: -> { Spree::Dependencies.credit_cards_destroy_service },
-
- # payment services
- storefront_payment_create_service: -> { Spree::Dependencies.payment_create_service },
-
- # serializers
- storefront_address_serializer: 'Spree::V2::Storefront::AddressSerializer',
- storefront_cart_serializer: 'Spree::V2::Storefront::CartSerializer',
- storefront_cms_page_serializer: nil, # LEGACY
- storefront_credit_card_serializer: 'Spree::V2::Storefront::CreditCardSerializer',
- storefront_country_serializer: 'Spree::V2::Storefront::CountrySerializer',
- storefront_menu_serializer: nil, # LEGACY
- storefront_user_serializer: 'Spree::V2::Storefront::UserSerializer',
- storefront_shipment_serializer: 'Spree::V2::Storefront::ShipmentSerializer',
- storefront_taxon_serializer: 'Spree::V2::Storefront::TaxonSerializer',
- storefront_payment_method_serializer: 'Spree::V2::Storefront::PaymentMethodSerializer',
- storefront_payment_serializer: 'Spree::V2::Storefront::PaymentSerializer',
- storefront_product_serializer: 'Spree::V2::Storefront::ProductSerializer',
- storefront_estimated_shipment_serializer: 'Spree::V2::Storefront::EstimatedShippingRateSerializer',
- storefront_store_serializer: 'Spree::V2::Storefront::StoreSerializer',
- storefront_policy_serializer: 'Spree::V2::Storefront::PolicySerializer',
- storefront_post_category_serializer: 'Spree::V2::Storefront::PostCategorySerializer',
- storefront_post_serializer: 'Spree::V2::Storefront::PostSerializer',
- storefront_order_serializer: 'Spree::V2::Storefront::OrderSerializer',
- storefront_variant_serializer: 'Spree::V2::Storefront::VariantSerializer',
- storefront_image_serializer: 'Spree::V2::Storefront::ImageSerializer',
- storefront_line_item_serializer: 'Spree::V2::Storefront::LineItemSerializer',
- storefront_option_type_serializer: 'Spree::V2::Storefront::OptionTypeSerializer',
- storefront_option_value_serializer: 'Spree::V2::Storefront::OptionValueSerializer',
- storefront_product_property_serializer: 'Spree::V2::Storefront::ProductPropertySerializer',
- storefront_order_promotion_serializer: 'Spree::V2::Storefront::OrderPromotionSerializer',
- storefront_shipping_method_serializer: 'Spree::V2::Storefront::ShippingMethodSerializer',
- storefront_shipping_rate_serializer: 'Spree::V2::Storefront::ShippingRateSerializer',
- storefront_stock_location_serializer: 'Spree::V2::Storefront::StockLocationSerializer',
- storefront_store_credit_category_serializer: 'Spree::V2::Storefront::StoreCreditCategorySerializer',
- storefront_store_credit_event_serializer: 'Spree::V2::Storefront::StoreCreditEventSerializer',
- storefront_store_credit_type_serializer: 'Spree::V2::Storefront::StoreCreditTypeSerializer',
- storefront_digital_link_serializer: 'Spree::V2::Storefront::DigitalLinkSerializer',
- storefront_gift_card_serializer: 'Spree::V2::Storefront::GiftCardSerializer',
- storefront_taxonomy_serializer: 'Spree::V2::Storefront::TaxonomySerializer',
- storefront_taxon_image_serializer: 'Spree::V2::Storefront::TaxonImageSerializer',
- storefront_wishlist_serializer: 'Spree::V2::Storefront::WishlistSerializer',
- storefront_wished_item_serializer: 'Spree::V2::Storefront::WishedItemSerializer',
- storefront_metafield_serializer: 'Spree::V2::Storefront::MetafieldSerializer',
-
# v3 serializers (API v3)
credit_card_serializer: 'Spree::Api::V3::CreditCardSerializer',
price_serializer: 'Spree::Api::V3::PriceSerializer',
@@ -240,133 +153,6 @@ module Spree
admin_price_list_serializer: 'Spree::Api::V3::Admin::PriceListSerializer',
admin_price_rule_serializer: 'Spree::Api::V3::Admin::PriceRuleSerializer',
admin_resource_translations_serializer: 'Spree::Api::V3::Admin::ResourceTranslationsSerializer',
-
- # platform serializers
- platform_metafield_serializer: 'Spree::Api::V2::Platform::MetafieldSerializer',
-
- # sorters
- storefront_collection_sorter: -> { Spree::Dependencies.collection_sorter },
- storefront_order_sorter: -> { Spree::Dependencies.collection_sorter },
- storefront_posts_sorter: nil,
- storefront_products_sorter: -> { Spree::Dependencies.products_sorter },
- platform_products_sorter: -> { Spree::Dependencies.products_sorter },
- # paginators
- storefront_collection_paginator: 'Spree::Api::Paginate',
-
- # finders
- storefront_address_finder: -> { Spree::Dependencies.address_finder },
- storefront_country_finder: -> { Spree::Dependencies.country_finder },
- storefront_cms_page_finder: -> { Spree::Dependencies.cms_page_finder },
- storefront_menu_finder: -> { Spree::Dependencies.menu_finder },
- storefront_current_order_finder: -> { Spree::Dependencies.current_order_finder },
- storefront_completed_order_finder: -> { Spree::Dependencies.completed_order_finder },
- storefront_credit_card_finder: -> { Spree::Dependencies.credit_card_finder },
- storefront_find_by_variant_finder: -> { Spree::Dependencies.line_item_by_variant_finder },
- storefront_posts_finder: nil,
- storefront_products_finder: -> { Spree::Dependencies.products_finder },
- storefront_taxon_finder: -> { Spree::Dependencies.taxon_finder },
- storefront_variant_finder: -> { Spree::Dependencies.variant_finder },
-
- # serializers
- platform_address_serializer: 'Spree::Api::V2::Platform::AddressSerializer',
- platform_adjustment_serializer: 'Spree::Api::V2::Platform::AdjustmentSerializer',
- platform_admin_user_serializer: 'Spree::Api::V2::Platform::AdminUserSerializer',
- platform_asset_serializer: 'Spree::Api::V2::Platform::AssetSerializer',
- platform_calculator_serializer: 'Spree::Api::V2::Platform::CalculatorSerializer',
- platform_classification_serializer: 'Spree::Api::V2::Platform::ClassificationSerializer',
- platform_country_serializer: 'Spree::Api::V2::Platform::CountrySerializer',
- platform_credit_card_serializer: 'Spree::Api::V2::Platform::CreditCardSerializer',
- platform_customer_return_serializer: 'Spree::Api::V2::Platform::CustomerReturnSerializer',
- platform_digital_link_serializer: 'Spree::Api::V2::Platform::DigitalLinkSerializer',
- platform_digital_serializer: 'Spree::Api::V2::Platform::DigitalSerializer',
- platform_gift_card_serializer: 'Spree::Api::V2::Platform::GiftCardSerializer',
- platform_image_serializer: 'Spree::Api::V2::Platform::ImageSerializer',
- platform_inventory_unit_serializer: 'Spree::Api::V2::Platform::InventoryUnitSerializer',
- platform_line_item_serializer: 'Spree::Api::V2::Platform::LineItemSerializer',
- platform_log_entry_serializer: 'Spree::Api::V2::Platform::LogEntrySerializer',
- platform_option_type_serializer: 'Spree::Api::V2::Platform::OptionTypeSerializer',
- platform_option_value_serializer: 'Spree::Api::V2::Platform::OptionValueSerializer',
- platform_order_promotion_serializer: 'Spree::Api::V2::Platform::OrderPromotionSerializer',
- platform_order_serializer: 'Spree::Api::V2::Platform::OrderSerializer',
- platform_payment_capture_event_serializer: 'Spree::Api::V2::Platform::PaymentCaptureEventSerializer',
- platform_payment_method_serializer: 'Spree::Api::V2::Platform::PaymentMethodSerializer',
- platform_payment_serializer: 'Spree::Api::V2::Platform::PaymentSerializer',
- platform_payment_source_serializer: 'Spree::Api::V2::Platform::PaymentSourceSerializer',
- platform_price_serializer: 'Spree::Api::V2::Platform::PriceSerializer',
- platform_product_property_serializer: 'Spree::Api::V2::Platform::ProductPropertySerializer',
- platform_product_serializer: 'Spree::Api::V2::Platform::ProductSerializer',
- platform_promotion_action_line_item_serializer: 'Spree::Api::V2::Platform::PromotionActionLineItemSerializer',
- platform_promotion_action_serializer: 'Spree::Api::V2::Platform::PromotionActionSerializer',
- platform_promotion_category_serializer: 'Spree::Api::V2::Platform::PromotionCategorySerializer',
- platform_promotion_rule_serializer: 'Spree::Api::V2::Platform::PromotionRuleSerializer',
- platform_property_serializer: 'Spree::Api::V2::Platform::PropertySerializer',
- platform_promotion_serializer: 'Spree::Api::V2::Platform::PromotionSerializer',
- platform_prototype_serializer: 'Spree::Api::V2::Platform::PrototypeSerializer',
- platform_refund_reason_serializer: 'Spree::Api::V2::Platform::RefundReasonSerializer',
- platform_refund_serializer: 'Spree::Api::V2::Platform::RefundSerializer',
- platform_reimbursement_credit_serializer: 'Spree::Api::V2::Platform::ReimbursementCreditSerializer',
- platform_reimbursement_serializer: 'Spree::Api::V2::Platform::ReimbursementSerializer',
- platform_reimbursement_type_serializer: 'Spree::Api::V2::Platform::ReimbursementTypeSerializer',
- platform_return_authorization_reason_serializer: 'Spree::Api::V2::Platform::ReturnAuthorizationReasonSerializer',
- platform_return_authorization_serializer: 'Spree::Api::V2::Platform::ReturnAuthorizationSerializer',
- platform_return_item_serializer: 'Spree::Api::V2::Platform::ReturnItemSerializer',
- platform_role_serializer: 'Spree::Api::V2::Platform::RoleSerializer',
- platform_shipment_serializer: 'Spree::Api::V2::Platform::ShipmentSerializer',
- platform_shipping_category_serializer: 'Spree::Api::V2::Platform::ShippingCategorySerializer',
- platform_shipping_method_serializer: 'Spree::Api::V2::Platform::ShippingMethodSerializer',
- platform_shipping_rate_serializer: 'Spree::Api::V2::Platform::ShippingRateSerializer',
- platform_state_change_serializer: 'Spree::Api::V2::Platform::StateChangeSerializer',
- platform_state_serializer: 'Spree::Api::V2::Platform::StateSerializer',
- platform_stock_item_serializer: 'Spree::Api::V2::Platform::StockItemSerializer',
- platform_stock_location_serializer: 'Spree::Api::V2::Platform::StockLocationSerializer',
- platform_stock_movement_serializer: 'Spree::Api::V2::Platform::StockMovementSerializer',
- platform_stock_transfer_serializer: 'Spree::Api::V2::Platform::StockTransferSerializer',
- platform_store_credit_category_serializer: 'Spree::Api::V2::Platform::StoreCreditCategorySerializer',
- platform_store_credit_event_serializer: 'Spree::Api::V2::Platform::StoreCreditEventSerializer',
- platform_store_credit_serializer: 'Spree::Api::V2::Platform::StoreCreditSerializer',
- platform_store_credit_type_serializer: 'Spree::Api::V2::Platform::StoreCreditTypeSerializer',
- platform_store_serializer: 'Spree::Api::V2::Platform::StoreSerializer',
- platform_tax_category_serializer: 'Spree::Api::V2::Platform::TaxCategorySerializer',
- platform_tax_rate_serializer: 'Spree::Api::V2::Platform::TaxRateSerializer',
- platform_taxon_image_serializer: 'Spree::Api::V2::Platform::TaxonImageSerializer',
- platform_taxon_serializer: 'Spree::Api::V2::Platform::TaxonSerializer',
- platform_taxonomy_serializer: 'Spree::Api::V2::Platform::TaxonomySerializer',
- platform_user_serializer: 'Spree::Api::V2::Platform::UserSerializer',
- platform_variant_serializer: 'Spree::Api::V2::Platform::VariantSerializer',
- platform_webhooks_event_serializer: 'Spree::Api::V2::Platform::Webhooks::EventSerializer',
- platform_webhooks_subscriber_serializer: 'Spree::Api::V2::Platform::Webhooks::SubscriberSerializer',
- platform_wished_item_serializer: 'Spree::Api::V2::Platform::WishedItemSerializer',
- platform_wishlist_serializer: 'Spree::Api::V2::Platform::WishlistSerializer',
- platform_zone_member_serializer: 'Spree::Api::V2::Platform::ZoneMemberSerializer',
- platform_zone_serializer: 'Spree::Api::V2::Platform::ZoneSerializer',
-
- # coupon code handler
- platform_coupon_handler: -> { Spree::Dependencies.coupon_handler },
-
- # order services
- platform_order_recalculate_service: -> { Spree::Dependencies.cart_recalculate_service },
- platform_order_update_service: -> { Spree::Dependencies.checkout_update_service },
- platform_order_empty_service: -> { Spree::Dependencies.cart_empty_service },
- platform_order_destroy_service: -> { Spree::Dependencies.cart_destroy_service },
- platform_order_next_service: -> { Spree::Dependencies.checkout_next_service },
- platform_order_advance_service: -> { Spree::Dependencies.checkout_advance_service },
- platform_order_complete_service: -> { Spree::Dependencies.checkout_complete_service },
- platform_order_use_store_credit_service: -> { Spree::Dependencies.checkout_add_store_credit_service },
- platform_order_remove_store_credit_service: -> { Spree::Dependencies.checkout_remove_store_credit_service },
- platform_order_approve_service: -> { Spree::Dependencies.order_approve_service },
- platform_order_cancel_service: -> { Spree::Dependencies.order_cancel_service },
-
- # line item services
- platform_line_item_create_service: -> { Spree::Dependencies.line_item_create_service },
- platform_line_item_update_service: -> { Spree::Dependencies.line_item_update_service },
- platform_line_item_destroy_service: -> { Spree::Dependencies.line_item_destroy_service },
-
- # shipment services
- platform_shipment_create_service: -> { Spree::Dependencies.shipment_create_service },
- platform_shipment_update_service: -> { Spree::Dependencies.shipment_update_service },
- platform_shipment_change_state_service: -> { Spree::Dependencies.shipment_change_state_service },
- platform_shipment_add_item_service: -> { Spree::Dependencies.shipment_add_item_service },
- platform_shipment_remove_item_service: -> { Spree::Dependencies.shipment_remove_item_service },
}
include Spree::DependenciesHelper
diff --git a/spree/api/spec/lib/spree/api/api_dependencies_spec.rb b/spree/api/spec/lib/spree/api/api_dependencies_spec.rb
index 111d4e906f..7b104e3f2f 100644
--- a/spree/api/spec/lib/spree/api/api_dependencies_spec.rb
+++ b/spree/api/spec/lib/spree/api/api_dependencies_spec.rb
@@ -6,35 +6,20 @@ class MyNewSerializer
attributes :total
end
-class MyCustomCreateService
-end
-
-class MyCustomCouponHandler
+class MyCustomFieldSerializer
end
describe Spree::Api::ApiDependencies, type: :model do
let(:deps) { described_class.new }
- describe 'backwards compatibility' do
+ describe 'defaults' do
it 'returns the default value as string' do
- expect(deps.storefront_cart_serializer).to eq('Spree::V2::Storefront::CartSerializer')
+ expect(deps.product_serializer).to eq('Spree::Api::V3::ProductSerializer')
end
it 'allows to overwrite the value' do
- deps.storefront_cart_serializer = MyNewSerializer
- expect(deps.storefront_cart_serializer).to eq MyNewSerializer
- end
-
- it 'respects global dependencies' do
- original_value = Spree::Dependencies.cart_create_service
- begin
- Spree::Dependencies.cart_create_service = MyCustomCreateService
- expect(deps.storefront_cart_create_service).to eq(MyCustomCreateService)
- ensure
- # Use setter to properly clear memoization
- Spree::Dependencies.cart_create_service = original_value
- Spree::Dependencies.instance_variable_get(:@overrides)&.delete(:cart_create_service)
- end
+ deps.product_serializer = MyNewSerializer
+ expect(deps.product_serializer).to eq MyNewSerializer
end
end
@@ -47,10 +32,6 @@ describe Spree::Api::ApiDependencies, type: :model do
deps.order_serializer = MyNewSerializer
expect(deps.order_serializer_class).to eq MyNewSerializer
end
-
- it 'resolves proc-based dependencies from core' do
- expect(deps.order_serializer_class).to eq Spree::Api::V3::OrderSerializer
- end
end
describe '#overrides' do
@@ -95,28 +76,28 @@ describe 'Spree.api accessor' do
describe 'Spree.api.<dependency>=' do
# Use around hook with ensure to guarantee cleanup even if test fails
around do |example|
- original_value = Spree::Api::Dependencies.storefront_coupon_handler
+ original_value = Spree::Api::Dependencies.custom_field_serializer
example.run
ensure
# Restore original value using setter (which clears memoization)
- Spree::Api::Dependencies.storefront_coupon_handler = original_value
+ Spree::Api::Dependencies.custom_field_serializer = original_value
# Clear override tracking for this test
- Spree::Api::Dependencies.instance_variable_get(:@overrides)&.delete(:storefront_coupon_handler)
+ Spree::Api::Dependencies.instance_variable_get(:@overrides)&.delete(:custom_field_serializer)
end
it 'sets the dependency via Spree.api' do
- Spree.api.storefront_coupon_handler = MyCustomCouponHandler
- expect(Spree::Api::Dependencies.storefront_coupon_handler).to eq MyCustomCouponHandler
+ Spree.api.custom_field_serializer = MyCustomFieldSerializer
+ expect(Spree::Api::Dependencies.custom_field_serializer).to eq MyCustomFieldSerializer
end
it 'returns the new class via Spree.api' do
- Spree.api.storefront_coupon_handler = MyCustomCouponHandler
- expect(Spree.api.storefront_coupon_handler).to eq MyCustomCouponHandler
+ Spree.api.custom_field_serializer = MyCustomFieldSerializer
+ expect(Spree.api.custom_field_serializer).to eq MyCustomFieldSerializer
end
it 'tracks override source correctly (not internal routing code)' do
- Spree.api.storefront_coupon_handler = MyCustomCouponHandler
- info = Spree::Api::Dependencies.override_info(:storefront_coupon_handler)
+ Spree.api.custom_field_serializer = MyCustomFieldSerializer
+ info = Spree::Api::Dependencies.override_info(:custom_field_serializer)
# Should point to this spec file, not api.rb method_missing
expect(info[:source]).to include('api_dependencies_spec.rb')
diff --git a/spree/api/spec/models/spree/api_dependencies_spec.rb b/spree/api/spec/models/spree/api_dependencies_spec.rb
deleted file mode 100644
index b5134f431b..0000000000
--- a/spree/api/spec/models/spree/api_dependencies_spec.rb
+++ /dev/null
@@ -1,132 +0,0 @@
-require 'spec_helper'
-
-class MyNewSerializer
- include Alba::Resource
-
- attributes :total
-end
-
-class MyCustomCreateService
-end
-
-class MyCustomCouponHandler
-end
-
-describe Spree::Api::ApiDependencies, type: :model do
- let(:deps) { described_class.new }
-
- describe 'backwards compatibility' do
- it 'returns the default value as string' do
- expect(deps.order_serializer).to eq('Spree::Api::V3::OrderSerializer')
- end
-
- it 'allows to overwrite the value' do
- deps.order_serializer = MyNewSerializer
- expect(deps.order_serializer).to eq MyNewSerializer
- end
-
- it 'respects global dependencies' do
- original_value = Spree::Dependencies.cart_create_service
- begin
- Spree::Dependencies.cart_create_service = MyCustomCreateService
- expect(deps.storefront_cart_create_service).to eq(MyCustomCreateService)
- ensure
- # Use setter to properly clear memoization
- Spree::Dependencies.cart_create_service = original_value
- Spree::Dependencies.instance_variable_get(:@overrides)&.delete(:cart_create_service)
- end
- end
- end
-
- describe '#<dependency>_class' do
- it 'returns the constantized class for string values' do
- expect(deps.order_serializer_class).to eq Spree::Api::V3::OrderSerializer
- end
-
- it 'returns the class directly when set as class' do
- deps.order_serializer = MyNewSerializer
- expect(deps.order_serializer_class).to eq MyNewSerializer
- end
-
- it 'resolves proc-based dependencies from core' do
- expect(deps.storefront_cart_create_service_class).to eq Spree::Cart::Create
- end
- end
-
- describe '#overrides' do
- it 'tracks overridden dependencies' do
- deps.storefront_cart_serializer = MyNewSerializer
- expect(deps.overrides).to have_key(:storefront_cart_serializer)
- end
- end
-
- describe '#current_values' do
- it 'returns all dependencies with metadata' do
- values = deps.current_values
- expect(values).to be_an(Array)
- expect(values.first).to include(:name, :current, :default, :overridden)
- end
- end
-
- describe '#validate!' do
- it 'raises Spree::DependencyError for invalid dependencies' do
- deps.storefront_cart_serializer = 'NonExistentClass'
- expect { deps.validate! }.to raise_error(Spree::DependencyError)
- end
- end
-end
-
-describe 'Spree.api accessor' do
- describe 'Spree.api.<dependency>' do
- it 'returns the resolved class' do
- expect(Spree.api.order_serializer).to eq Spree::Api::V3::OrderSerializer
- end
-
- it 'responds to dependency methods' do
- expect(Spree.api.respond_to?(:order_serializer)).to be true
- expect(Spree.api.respond_to?(:order_serializer=)).to be true
- end
-
- it 'does not respond to non-dependency methods' do
- expect(Spree.api.respond_to?(:non_existent_dependency)).to be false
- end
- end
-
- describe 'Spree.api.<dependency>=' do
- # Use around hook with ensure to guarantee cleanup even if test fails
- around do |example|
- original_value = Spree::Api::Dependencies.storefront_coupon_handler
- example.run
- ensure
- # Restore original value using setter (which clears memoization)
- Spree::Api::Dependencies.storefront_coupon_handler = original_value
- # Clear override tracking for this test
- Spree::Api::Dependencies.instance_variable_get(:@overrides)&.delete(:storefront_coupon_handler)
- end
-
- it 'sets the dependency via Spree.api' do
- Spree.api.storefront_coupon_handler = MyCustomCouponHandler
- expect(Spree::Api::Dependencies.storefront_coupon_handler).to eq MyCustomCouponHandler
- end
-
- it 'returns the new class via Spree.api' do
- Spree.api.storefront_coupon_handler = MyCustomCouponHandler
- expect(Spree.api.storefront_coupon_handler).to eq MyCustomCouponHandler
- end
-
- it 'tracks override source correctly (not internal routing code)' do
- Spree.api.storefront_coupon_handler = MyCustomCouponHandler
- info = Spree::Api::Dependencies.override_info(:storefront_coupon_handler)
-
- # Should point to this spec file, not api.rb method_missing
- expect(info[:source]).to include('api_dependencies_spec.rb')
- expect(info[:source]).not_to include('lib/spree/api.rb')
- end
- end
-
- describe 'Spree.api.dependencies' do
- it 'returns the raw dependencies object' do
- expect(Spree.api.dependencies).to eq Spree::Api::Dependencies
- end
- end
-end