Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Store a commission rate code in one case

Damian Legawiec1274dc8ff473
diff --git a/spree/core/app/models/spree/commission_rate.rb b/spree/core/app/models/spree/commission_rate.rb
index 42ab77f62e..40913ea194 100644
--- a/spree/core/app/models/spree/commission_rate.rb
+++ b/spree/core/app/models/spree/commission_rate.rb
@@ -37,6 +37,12 @@ module Spree
validates :kind, presence: true, inclusion: { in: KINDS }
validates :priority, numericality: { only_integer: true }
validates :value, numericality: { greater_than_or_equal_to: 0 }
+ # Stored lowercase so the database enforces the same uniqueness the
+ # validation promises. A functional index over LOWER(code) would be the
+ # alternative, but that is a MySQL-only construct MariaDB rejects — and
+ # normalizing on write means every adapter agrees without one.
+ normalizes :code, with: ->(value) { value.to_s.strip.downcase.presence }
+
validates :code, uniqueness: { scope: [*spree_base_uniqueness_scope, :store_id], case_sensitive: false },
allow_blank: true
# A flat fee is meaningless without one; a percentage applies in any
diff --git a/spree/core/spec/models/spree/commission_rate_spec.rb b/spree/core/spec/models/spree/commission_rate_spec.rb
index b9d241bdc4..da060e9add 100644
--- a/spree/core/spec/models/spree/commission_rate_spec.rb
+++ b/spree/core/spec/models/spree/commission_rate_spec.rb
@@ -32,6 +32,15 @@ RSpec.describe Spree::CommissionRate, type: :model do
expect { create(:commission_rate, store: store, code: 'standard') }.not_to raise_error
end
+ # The validation is case-insensitive, so the stored value has to be too —
+ # otherwise the index would let "Foo" past "foo" on a concurrent write.
+ it 'stores a code in one case, so the database enforces what the validation promises' do
+ rate = create(:commission_rate, store: store, code: ' Standard ')
+
+ expect(rate.code).to eq('standard')
+ expect(build(:commission_rate, store: store, code: 'STANDARD')).not_to be_valid
+ end
+
it 'allows several rates to carry no code at all' do
create(:commission_rate, store: store, code: nil)