Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Added `UsersController#select_options` JSON endpoint

Damian Legawiec13fb7a9c59c1
diff --git a/admin/app/controllers/spree/admin/countries_controller.rb b/admin/app/controllers/spree/admin/countries_controller.rb
index 488e0483c5..c49ffeaf7f 100644
--- a/admin/app/controllers/spree/admin/countries_controller.rb
+++ b/admin/app/controllers/spree/admin/countries_controller.rb
@@ -5,7 +5,7 @@ module Spree
search_params = params[:q].is_a?(String) ? { name_cont: params[:q] } : params[:q]
countries = Spree::Country.ransack(search_params).result.order(:name).limit(50)
- render json: countries.map { |c| { id: c.id, name: c.name } }
+ render json: countries.pluck(:id, :name).map { |id, name| { id: id, name: name } }
end
end
end
diff --git a/admin/app/controllers/spree/admin/users_controller.rb b/admin/app/controllers/spree/admin/users_controller.rb
index 09d5727c17..6e6fb4491e 100644
--- a/admin/app/controllers/spree/admin/users_controller.rb
+++ b/admin/app/controllers/spree/admin/users_controller.rb
@@ -13,6 +13,13 @@ module Spree
add_breadcrumb_icon 'users'
add_breadcrumb Spree.t(:customers), :admin_users_path
+ def select_options
+ search_params = params[:q].is_a?(String) ? { email_cont: params[:q] } : params[:q]
+ users = model_class.ransack(search_params).result.order(:email).limit(50)
+
+ render json: users.pluck(:id, :email).map { |id, email| { id: id, name: email } }
+ end
+
def show
add_breadcrumb @user.name, spree.admin_user_path(@user)
end
diff --git a/admin/config/routes.rb b/admin/config/routes.rb
index 377691c127..56e1e9161e 100644
--- a/admin/config/routes.rb
+++ b/admin/config/routes.rb
@@ -46,6 +46,7 @@ Spree::Core::Engine.add_routes do
get '/taxons/select_options' => 'taxons#select_options', as: :taxons_select_options, defaults: { format: :json }
get '/tags/select_options' => 'tags#select_options', as: :tags_select_options, defaults: { format: :json }
get '/countries/select_options' => 'countries#select_options', as: :countries_select_options, defaults: { format: :json }
+ get '/users/select_options' => 'users#select_options', as: :users_select_options, defaults: { format: :json }
# media library
resources :assets, only: [:create, :edit, :update, :destroy] do
diff --git a/admin/spec/controllers/spree/admin/users_controller_spec.rb b/admin/spec/controllers/spree/admin/users_controller_spec.rb
index bd7cae7aa3..27eec78946 100644
--- a/admin/spec/controllers/spree/admin/users_controller_spec.rb
+++ b/admin/spec/controllers/spree/admin/users_controller_spec.rb
@@ -196,4 +196,67 @@ RSpec.describe Spree::Admin::UsersController, type: :controller do
end
end
end
+
+ describe 'GET #select_options' do
+ let!(:user_1) { create(:user, email: '[email protected]') }
+ let!(:user_2) { create(:user, email: '[email protected]') }
+ let!(:user_3) { create(:user, email: '[email protected]') }
+
+ it 'returns users matching the search query as JSON' do
+ get :select_options, params: { q: 'alice' }, format: :json
+
+ expect(response).to have_http_status(:ok)
+ json = JSON.parse(response.body)
+
+ expect(json.size).to eq(2)
+ expect(json.map { |u| u['name'] }).to contain_exactly('[email protected]', '[email protected]')
+ end
+
+ it 'returns users with id and name (email) attributes' do
+ get :select_options, params: { q: 'bob' }, format: :json
+
+ json = JSON.parse(response.body)
+
+ expect(json.size).to eq(1)
+ expect(json.first).to eq({ 'id' => user_2.id, 'name' => '[email protected]' })
+ end
+
+ it 'returns empty array when no users match' do
+ get :select_options, params: { q: 'nonexistent' }, format: :json
+
+ json = JSON.parse(response.body)
+
+ expect(json).to eq([])
+ end
+
+ it 'limits results to 50 users' do
+ 55.times { |i| create(:user, email: "test#{i}@example.com") }
+
+ get :select_options, params: { q: 'test' }, format: :json
+
+ json = JSON.parse(response.body)
+
+ expect(json.size).to eq(50)
+ end
+
+ it 'orders results by email' do
+ get :select_options, params: { q: 'example.com' }, format: :json
+
+ json = JSON.parse(response.body)
+ emails = json.map { |u| u['name'] }
+
+ expect(emails).to eq(emails.sort)
+ end
+
+ context 'with hash search params' do
+ it 'accepts ransack-style hash params' do
+ get :select_options, params: { q: { email_cont: 'bob' } }, format: :json
+
+ json = JSON.parse(response.body)
+
+ expect(json.size).to eq(1)
+ expect(json.first['name']).to eq('[email protected]')
+ end
+ end
+ end
end