Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fixed Price List Volume Rule not working during add to cart (#13447)

Damian Legawiec16e06b86f82c
diff --git a/core/app/models/spree/line_item.rb b/core/app/models/spree/line_item.rb
index 22734d6868..f86209c837 100644
--- a/core/app/models/spree/line_item.rb
+++ b/core/app/models/spree/line_item.rb
@@ -227,6 +227,27 @@ module Spree
variant.with_digital_assets?
end
+ # Recalculates and persists the price based on the current quantity and pricing context
+ # This is used for volume-based pricing and other price list rules
+ # @return [void]
+ def recalculate_price
+ context = Spree::Pricing::Context.from_order(variant, order, quantity: quantity)
+ currency_price = variant.price_for(context)
+
+ return unless currency_price.present?
+
+ new_price = currency_price.price_including_vat_for(tax_zone: tax_zone)
+
+ return unless new_price.present?
+
+ new_price_list_id = currency_price.price_list_id
+
+ # Only update if price or price list changed
+ if new_price != price || new_price_list_id != price_list_id
+ update_columns(price: new_price, price_list_id: new_price_list_id, updated_at: Time.current)
+ end
+ end
+
private
def ensure_valid_quantity
@@ -276,24 +297,6 @@ module Spree
!order.completed?
end
- def recalculate_price
- context = Spree::Pricing::Context.from_order(variant, order, quantity: quantity)
- currency_price = variant.price_for(context)
-
- return unless currency_price.present?
-
- new_price = currency_price.price_including_vat_for(tax_zone: tax_zone)
-
- return unless new_price.present?
-
- new_price_list_id = currency_price.price_list_id
-
- # Only update if price or price list changed
- if new_price != price || new_price_list_id != price_list_id
- update_columns(price: new_price, price_list_id: new_price_list_id)
- end
- end
-
def recalculate_adjustments
Spree::Adjustable::AdjustmentsUpdater.update(self)
end
diff --git a/core/app/services/spree/cart/add_item.rb b/core/app/services/spree/cart/add_item.rb
index aa9fc69d7b..c2e4ec42c0 100644
--- a/core/app/services/spree/cart/add_item.rb
+++ b/core/app/services/spree/cart/add_item.rb
@@ -39,7 +39,7 @@ module Spree
return failure(line_item) unless line_item.save
- line_item.reload.update_price
+ line_item.reload.recalculate_price
::Spree::TaxRate.adjust(order, [line_item]) if line_item_created
success(order: order, line_item: line_item, line_item_created: line_item_created, options: options)
diff --git a/core/spec/models/spree/line_item_spec.rb b/core/spec/models/spree/line_item_spec.rb
index 7ad9b78457..457dd2ab26 100644
--- a/core/spec/models/spree/line_item_spec.rb
+++ b/core/spec/models/spree/line_item_spec.rb
@@ -646,6 +646,30 @@ describe Spree::LineItem, type: :model do
expect(line_item.reload.price).to eq(original_price)
end
end
+
+ context 'when creating line item with quantity meeting volume threshold' do
+ let!(:price_list) { create(:price_list, :active, store: store) }
+ let!(:volume_rule) { create(:volume_price_rule, price_list: price_list, min_quantity: 10) }
+ let!(:volume_price) { create(:price, variant: variant, currency: 'USD', amount: 7.00, price_list: price_list) }
+
+ it 'applies volume price on initial creation' do
+ result = Spree::Cart::AddItem.call(order: order, variant: variant, quantity: 15)
+ expect(result.success?).to be true
+
+ new_line_item = order.line_items.find_by(variant: variant)
+ expect(new_line_item.price).to eq(7.00)
+ expect(new_line_item.price_list_id).to eq(price_list.id)
+ end
+
+ it 'does not apply volume price when quantity is below threshold' do
+ result = Spree::Cart::AddItem.call(order: order, variant: variant, quantity: 5)
+ expect(result.success?).to be true
+
+ new_line_item = order.line_items.find_by(variant: variant)
+ expect(new_line_item.price).to eq(10.00)
+ expect(new_line_item.price_list_id).to be_nil
+ end
+ end
end
describe '#discounted_price' do