Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Remove obsolet `BogusSimple` payment method (#13682)

Damian Legawiec1a75dc05f100
diff --git a/spree/core/app/models/spree/gateway/bogus_simple.rb b/spree/core/app/models/spree/gateway/bogus_simple.rb
deleted file mode 100644
index d9707a94e9..0000000000
--- a/spree/core/app/models/spree/gateway/bogus_simple.rb
+++ /dev/null
@@ -1,24 +0,0 @@
-# Bogus Gateway that doesn't support payment profiles
-module Spree
- class Gateway::BogusSimple < Gateway::Bogus
- def payment_profiles_supported?
- false
- end
-
- def authorize(_money, credit_card, _options = {})
- if VALID_CCS.include? credit_card.number
- Spree::PaymentResponse.new(true, 'Bogus Gateway: Forced success', {}, test: true, authorization: '12345', avs_result: { code: 'A' })
- else
- Spree::PaymentResponse.new(false, 'Bogus Gateway: Forced failure', { message: 'Bogus Gateway: Forced failure' }, test: true)
- end
- end
-
- def purchase(_money, credit_card, _options = {})
- if VALID_CCS.include? credit_card.number
- Spree::PaymentResponse.new(true, 'Bogus Gateway: Forced success', {}, test: true, authorization: '12345', avs_result: { code: 'A' })
- else
- Spree::PaymentResponse.new(false, 'Bogus Gateway: Forced failure', message: 'Bogus Gateway: Forced failure', test: true)
- end
- end
- end
-end
diff --git a/spree/core/lib/spree/core/engine.rb b/spree/core/lib/spree/core/engine.rb
index ff8cdd52dd..ecff865e99 100644
--- a/spree/core/lib/spree/core/engine.rb
+++ b/spree/core/lib/spree/core/engine.rb
@@ -123,7 +123,6 @@ module Spree
Rails.application.config.spree.payment_methods = [
Spree::Gateway::Bogus,
- Spree::Gateway::BogusSimple,
Spree::Gateway::CustomPaymentSourceMethod,
Spree::PaymentMethod::Check,
Spree::PaymentMethod::StoreCredit
diff --git a/spree/core/lib/spree/testing_support/factories/payment_method_factory.rb b/spree/core/lib/spree/testing_support/factories/payment_method_factory.rb
index 759fa8fa6f..26126fd7be 100644
--- a/spree/core/lib/spree/testing_support/factories/payment_method_factory.rb
+++ b/spree/core/lib/spree/testing_support/factories/payment_method_factory.rb
@@ -23,12 +23,7 @@ FactoryBot.define do
name { 'Credit Card' }
end
- # authorize.net was moved to spree_gateway.
- # Leaving this factory in place with bogus in case anyone is using it.
- factory :simple_credit_card_payment_method, parent: :payment_method, class: Spree::Gateway::BogusSimple do
- type { 'Spree::Gateway::BogusSimple' }
- name { 'Credit Card' }
- end
+ factory :simple_credit_card_payment_method, parent: :credit_card_payment_method
factory :store_credit_payment_method, parent: :payment_method, class: Spree::PaymentMethod::StoreCredit do
type { 'Spree::PaymentMethod::StoreCredit' }
diff --git a/spree/core/spec/models/spree/gateway/bogus_simple.rb b/spree/core/spec/models/spree/gateway/bogus_simple.rb
deleted file mode 100644
index 31c49f7c6a..0000000000
--- a/spree/core/spec/models/spree/gateway/bogus_simple.rb
+++ /dev/null
@@ -1,18 +0,0 @@
-require 'spec_helper'
-
-describe Spree::Gateway::BogusSimple, type: :model do
- subject { Spree::Gateway::BogusSimple.new }
-
- # regression test for #3824
- describe '#capture' do
- it 'returns success with the right response code' do
- response = subject.capture(123, '12345', {})
- expect(response.message).to include('success')
- end
-
- it 'returns failure with the wrong response code' do
- response = subject.capture(123, 'wrong', {})
- expect(response.message).to include('failure')
- end
- end
-end