Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

fix assigning primary media to product on session uploaded assets (#14118)

Kacper Mękarski1be4db9b88ae
diff --git a/spree/admin/app/controllers/spree/admin/products_controller.rb b/spree/admin/app/controllers/spree/admin/products_controller.rb
index ff2c84e266..a5d4d74007 100644
--- a/spree/admin/app/controllers/spree/admin/products_controller.rb
+++ b/spree/admin/app/controllers/spree/admin/products_controller.rb
@@ -293,6 +293,8 @@ module Spree
return if uploaded_assets.empty?
uploaded_assets.update_all(viewable_id: @product.id, viewable_type: 'Spree::Product', updated_at: Time.current)
+ @product.update_thumbnail!
+
clear_session_for_uploaded_assets('Spree::Product')
end
diff --git a/spree/admin/spec/controllers/spree/admin/products_controller_spec.rb b/spree/admin/spec/controllers/spree/admin/products_controller_spec.rb
index efa04402b0..56c05de269 100644
--- a/spree/admin/spec/controllers/spree/admin/products_controller_spec.rb
+++ b/spree/admin/spec/controllers/spree/admin/products_controller_spec.rb
@@ -394,6 +394,41 @@ RSpec.describe Spree::Admin::ProductsController, type: :controller do
end
end
+ context 'with session uploaded assets' do
+ let(:product_params) do
+ {
+ name: 'Product with images',
+ shipping_category_id: shipping_category.id
+ }
+ end
+ let(:session_uuid) { SecureRandom.uuid }
+ let!(:asset) { create(:image, viewable_id: nil, viewable_type: 'Spree::Product', session_id: session_uuid) }
+
+ before do
+ session['spree.admin.uploaded_assets.spree/product.uuid'] = session_uuid
+ end
+
+ after do
+ session.delete('spree.admin.uploaded_assets.spree/product.uuid')
+ end
+
+ it 'assigns session uploaded assets to the product' do
+ expect(asset.viewable_id).to be_nil
+
+ subject
+
+ product = Spree::Product.last
+ expect(asset.reload.viewable).to eq(product)
+ end
+
+ it 'updates the product primary media' do
+ subject
+
+ product = Spree::Product.last
+ expect(product.primary_media).to eq(asset)
+ end
+ end
+
context 'with stock items' do
let(:product_params) do
{