Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
FIX gift card overspend race condition vulnerability (#13734)
brozek1ce4d24042a5
diff --git a/spree/core/app/services/spree/gift_cards/apply.rb b/spree/core/app/services/spree/gift_cards/apply.rbindex 1d048ceba6..8fb7d8283e 100644--- a/spree/core/app/services/spree/gift_cards/apply.rb+++ b/spree/core/app/services/spree/gift_cards/apply.rb@@ -25,15 +25,16 @@ module Spreereturn failure(:gift_card_mismatched_customer) if gift_card.user != order.userend- amount = [gift_card.amount_remaining, order.total].minstore = order.store- return failure(:gift_card_no_amount_remaining) unless amount.positive? || order.total.zero?-payment_method = ensure_store_credit_payment_method!(store)- gift_card.lock!order.with_lock do+ gift_card.lock!+ amount = [gift_card.amount_remaining, order.total].min++ return failure(:gift_card_no_amount_remaining) unless amount.positive? || order.total.zero?+store_credit = gift_card.store_credits.create!(store: store,user: order.user,diff --git a/spree/core/spec/services/spree/gift_cards/apply_spec.rb b/spree/core/spec/services/spree/gift_cards/apply_spec.rbindex e64a5f43df..a485d4b27a 100644--- a/spree/core/spec/services/spree/gift_cards/apply_spec.rb+++ b/spree/core/spec/services/spree/gift_cards/apply_spec.rb@@ -105,6 +105,33 @@ RSpec.describe Spree::GiftCards::Apply doendend+ context 'when applied concurrently to multiple orders' do+ let(:gift_card) { create(:gift_card, amount: 100, store: store) }+ let(:users) { Array.new(5) { create(:user) } }+ let(:orders) do+ users.map do |user|+ order = create(:order, store: store, user: user)+ order.update_columns(total: 80, item_total: 80)+ order+ end+ end++ it 'does not generate store credits exceeding the gift card value' do+ threads = orders.map do |order|+ Thread.new do+ described_class.call(gift_card: gift_card, order: order)+ end+ end+ threads.each(&:join)++ gift_card.reload+ total_credits = Spree::StoreCredit.where(originator: gift_card).sum(:amount)++ expect(total_credits).to be <= gift_card.amount+ expect(gift_card.amount_used).to be <= gift_card.amount+ end+ end+context 'when the gift card has no amount remaining' dobefore { gift_card.update!(amount_used: gift_card.amount) }