Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Disable Spree Events in some specs to speed them up

Damian Legawiec1faf8a82b330
diff --git a/api/spec/spec_helper.rb b/api/spec/spec_helper.rb
index b95cbd5fe1..5e88744591 100644
--- a/api/spec/spec_helper.rb
+++ b/api/spec/spec_helper.rb
@@ -76,6 +76,7 @@ RSpec.configure do |config|
config.include Spree::TestingSupport::ImageHelpers
config.before(:suite) do
+ Spree::Events.disable!
# Clean out the database state before the tests run
DatabaseCleaner.strategy = :transaction
DatabaseCleaner.clean_with(:truncation)
diff --git a/core/lib/spree/events.rb b/core/lib/spree/events.rb
index ad953e25be..2c837ce347 100644
--- a/core/lib/spree/events.rb
+++ b/core/lib/spree/events.rb
@@ -201,6 +201,14 @@ module Spree
ensure
RequestStore.store[:spree_events_disabled] = previous
end
+
+ # Set the disabled state of the event system
+ # Useful for testing
+ # @param value [Boolean] The disabled state
+ # @return [void]
+ def disable!
+ RequestStore.store[:spree_events_disabled] = false
+ end
end
end
end
diff --git a/core/lib/spree/testing_support/store.rb b/core/lib/spree/testing_support/store.rb
index 91ae0f3972..2011a05089 100644
--- a/core/lib/spree/testing_support/store.rb
+++ b/core/lib/spree/testing_support/store.rb
@@ -16,8 +16,10 @@ RSpec.configure do |config|
# Ensure locale is set to :en before creating store to avoid translation issues
# when previous tests left the locale in a different language
I18n.with_locale(:en) do
- @default_country = Spree::Country.find_by(iso: 'US') || FactoryBot.create(:country_us)
- @default_store = Spree::Store.find_by(default: true) || FactoryBot.create(:store, default: true, default_country: @default_country, default_currency: 'USD')
+ Spree::Events.disable do
+ @default_country = Spree::Country.find_by(iso: 'US') || FactoryBot.create(:country_us)
+ @default_store = Spree::Store.find_by(default: true) || FactoryBot.create(:store, default: true, default_country: @default_country, default_currency: 'USD')
+ end
end
end
end
diff --git a/packages/page_builder/spec/spec_helper.rb b/packages/page_builder/spec/spec_helper.rb
index 11382a027a..37b0b27ce3 100644
--- a/packages/page_builder/spec/spec_helper.rb
+++ b/packages/page_builder/spec/spec_helper.rb
@@ -52,6 +52,7 @@ RSpec.configure do |config|
config.use_transactional_fixtures = false
config.before(:suite) do
+ Spree::Events.disable!
DatabaseCleaner.strategy = :transaction
DatabaseCleaner.clean_with(:truncation)
end
diff --git a/sample/lib/spree_sample.rb b/sample/lib/spree_sample.rb
index 75973aea09..683984f811 100644
--- a/sample/lib/spree_sample.rb
+++ b/sample/lib/spree_sample.rb
@@ -7,28 +7,30 @@ module SpreeSample
# Needs to be here so we can access it inside the tests
def self.load_samples
- Spree::Sample.load_sample('addresses')
- Spree::Sample.load_sample('zones')
- Spree::Sample.load_sample('payment_methods')
- Spree::Sample.load_sample('shipping_methods')
- Spree::Sample.load_sample('tax_categories')
- Spree::Sample.load_sample('tax_rates')
- Spree::Sample.load_sample('promotions')
+ Spree::Events.disable do
+ Spree::Sample.load_sample('addresses')
+ Spree::Sample.load_sample('zones')
+ Spree::Sample.load_sample('payment_methods')
+ Spree::Sample.load_sample('shipping_methods')
+ Spree::Sample.load_sample('tax_categories')
+ Spree::Sample.load_sample('tax_rates')
+ Spree::Sample.load_sample('promotions')
- Spree::Sample.load_sample('taxons')
- Spree::Sample.load_sample('option_types')
- Spree::Sample.load_sample('option_values')
- Spree::Sample.load_sample('products')
- Spree::Sample.load_sample('variants')
- Spree::Sample.load_sample('metafields')
- Spree::Sample.load_sample('stock')
+ Spree::Sample.load_sample('taxons')
+ Spree::Sample.load_sample('option_types')
+ Spree::Sample.load_sample('option_values')
+ Spree::Sample.load_sample('products')
+ Spree::Sample.load_sample('variants')
+ Spree::Sample.load_sample('metafields')
+ Spree::Sample.load_sample('stock')
- Spree::Sample.load_sample('orders')
- Spree::Sample.load_sample('adjustments')
- Spree::Sample.load_sample('payments')
- Spree::Sample.load_sample('reimbursements')
+ Spree::Sample.load_sample('orders')
+ Spree::Sample.load_sample('adjustments')
+ Spree::Sample.load_sample('payments')
+ Spree::Sample.load_sample('reimbursements')
- Spree::Sample.load_sample('posts')
+ Spree::Sample.load_sample('posts')
+ end
end
end
end
diff --git a/storefront/spec/spec_helper.rb b/storefront/spec/spec_helper.rb
index 21d6d18af3..422e24f6d9 100644
--- a/storefront/spec/spec_helper.rb
+++ b/storefront/spec/spec_helper.rb
@@ -67,6 +67,7 @@ RSpec.configure do |config|
config.use_transactional_fixtures = true
config.before(:suite) do
+ Spree::Events.disable!
Capybara.match = :smart
Capybara.javascript_driver = :selenium_chrome_headless
Capybara.default_max_wait_time = 10