Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fixed rendering variant import rows in admin (#13571)

Damian Legawiec28de4ddbe110
diff --git a/backend/engines/admin/app/views/spree/admin/variants/_variant.html.erb b/backend/engines/admin/app/views/spree/admin/variants/_variant.html.erb
index 7f08a32bcf..c92a72481e 100644
--- a/backend/engines/admin/app/views/spree/admin/variants/_variant.html.erb
+++ b/backend/engines/admin/app/views/spree/admin/variants/_variant.html.erb
@@ -5,7 +5,7 @@
<% variant_url = spree.edit_admin_product_variant_path(variant.product, variant) %>
<% end %>
- <%= link_to variant_url, id: spree_dom_id(variant), data: { turbo_permanent: true, turbo_frame: :_top }, class: 'flex items-center justify-start no-underline' do %>
+ <%= link_to variant_url, id: dom_id(variant, 'spree'), data: { turbo_permanent: true, turbo_frame: :_top }, class: 'flex items-center justify-start no-underline' do %>
<%= render "spree/admin/shared/product_image", object: variant %>
<div class="ml-6">
<strong><%= variant.name %></strong>
diff --git a/backend/engines/admin/spec/controllers/spree/admin/imports_controller_spec.rb b/backend/engines/admin/spec/controllers/spree/admin/imports_controller_spec.rb
index 7c2080ad1f..f71f97bc30 100644
--- a/backend/engines/admin/spec/controllers/spree/admin/imports_controller_spec.rb
+++ b/backend/engines/admin/spec/controllers/spree/admin/imports_controller_spec.rb
@@ -100,6 +100,18 @@ RSpec.describe Spree::Admin::ImportsController, type: :controller do
expect(assigns(:rows)).to eq([row])
end
end
+
+ context 'when rows have variant items' do
+ let(:import) { create(:product_import, status: :completed_mapping) }
+ let(:variant) { create(:variant) }
+ let!(:row) { create(:import_row, import: import, status: :completed, item: variant) }
+
+ it 'renders the variant partial' do
+ get :show, params: { id: import.to_param }
+ expect(response).to have_http_status(:ok)
+ expect(response.body).to include(variant.name)
+ end
+ end
end
describe 'PUT #complete_mapping' do