Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fixed: Use `to_param` for JSON preview in Admin UI

Damian Legawiec2c6dfbeb9bc2
diff --git a/spree/admin/app/helpers/spree/admin/json_preview_helper.rb b/spree/admin/app/helpers/spree/admin/json_preview_helper.rb
index a64fb68784..3a20699c3a 100644
--- a/spree/admin/app/helpers/spree/admin/json_preview_helper.rb
+++ b/spree/admin/app/helpers/spree/admin/json_preview_helper.rb
@@ -12,7 +12,7 @@ module Spree
link_to_with_icon(
'code',
Spree.t('admin.show_json'),
- spree.admin_json_preview_resource_path(record.id, resource_type: record.class.to_s),
+ spree.admin_json_preview_resource_path(record.to_param, resource_type: record.class.to_s),
options
)
end
diff --git a/spree/admin/spec/controllers/spree/admin/json_previews_controller_spec.rb b/spree/admin/spec/controllers/spree/admin/json_previews_controller_spec.rb
index 7162895e52..4cf5096266 100644
--- a/spree/admin/spec/controllers/spree/admin/json_previews_controller_spec.rb
+++ b/spree/admin/spec/controllers/spree/admin/json_previews_controller_spec.rb
@@ -9,7 +9,7 @@ RSpec.describe Spree::Admin::JsonPreviewsController, type: :controller do
describe 'GET #show' do
it 'assigns @object and renders the show template' do
- get :show, params: { resource_type: resource_type, id: product.id }
+ get :show, params: { resource_type: resource_type, id: product.to_param }
expect(response).to render_template(:show)
expect(assigns(:object)).to eq(product)
end
@@ -25,7 +25,7 @@ RSpec.describe Spree::Admin::JsonPreviewsController, type: :controller do
context 'when resource_type is invalid' do
it 'raises ActiveRecord::RecordNotFound' do
expect {
- get :show, params: { resource_type: 'InvalidType', id: product.id }
+ get :show, params: { resource_type: 'InvalidType', id: product.to_param }
}.to raise_error(ActiveRecord::RecordNotFound)
end
end