Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Add spec tests.

Matthew Kennedy2dc1589d5e8c
diff --git a/api/app/serializers/spree/api/v2/platform/digital_link_serializer.rb b/api/app/serializers/spree/api/v2/platform/digital_link_serializer.rb
index ed69223e0c..d511d477f7 100644
--- a/api/app/serializers/spree/api/v2/platform/digital_link_serializer.rb
+++ b/api/app/serializers/spree/api/v2/platform/digital_link_serializer.rb
@@ -6,8 +6,6 @@ module Spree
set_type :digital_link
attributes :token, :access_counter
-
- belongs_to :line_item
end
end
end
diff --git a/api/app/serializers/spree/api/v2/platform/digital_serializer.rb b/api/app/serializers/spree/api/v2/platform/digital_serializer.rb
index 98826aea57..fe16e6f0b2 100644
--- a/api/app/serializers/spree/api/v2/platform/digital_serializer.rb
+++ b/api/app/serializers/spree/api/v2/platform/digital_serializer.rb
@@ -11,18 +11,16 @@ module Spree
end
attribute :content_type do |digital|
- digital.attachment.content_type
+ digital.attachment.content_type.to_s
end
attribute :filename do |digital|
- digital.attachment.filename
+ digital.attachment.filename.to_s
end
attribute :byte_size do |digital|
- digital.attachment.byte_size
+ digital.attachment.byte_size.to_i
end
-
- belongs_to :variant
end
end
end
diff --git a/api/app/serializers/spree/v2/storefront/digital_link_serializer.rb b/api/app/serializers/spree/v2/storefront/digital_link_serializer.rb
index 1bc913f8d2..7b75ce975b 100644
--- a/api/app/serializers/spree/v2/storefront/digital_link_serializer.rb
+++ b/api/app/serializers/spree/v2/storefront/digital_link_serializer.rb
@@ -5,8 +5,6 @@ module Spree
set_type :digital_link
attributes :token
-
- belongs_to :line_item
end
end
end
diff --git a/api/app/serializers/spree/v2/storefront/store_serializer.rb b/api/app/serializers/spree/v2/storefront/store_serializer.rb
index 866f261966..52bb23bd2a 100644
--- a/api/app/serializers/spree/v2/storefront/store_serializer.rb
+++ b/api/app/serializers/spree/v2/storefront/store_serializer.rb
@@ -6,7 +6,7 @@ module Spree
attributes :name, :url, :meta_description, :meta_keywords, :seo_title, :default_currency, :default, :supported_currencies, :facebook,
:twitter, :instagram, :default_locale, :customer_support_email, :default_country_id, :description,
- :address, :contact_phone, :supported_locales
+ :address, :contact_phone, :supported_locales, :settings
has_many :menus
has_many :cms_pages
diff --git a/api/spec/integration/api/v2/platform/digitals_spec.rb b/api/spec/integration/api/v2/platform/digitals_spec.rb
new file mode 100644
index 0000000000..1d7caf7178
--- /dev/null
+++ b/api/spec/integration/api/v2/platform/digitals_spec.rb
@@ -0,0 +1,44 @@
+require 'swagger_helper'
+
+describe 'Digitals API', swagger: true do
+ include ActionDispatch::TestProcess::FixtureFile
+
+ include_context 'Platform API v2'
+
+ resource_name = 'Digital'
+ include_example = 'variant'
+ filter_example = 'name_cont=Birthday'
+
+ let(:image) { fixture_file_upload('icon_256x256.jpg') }
+
+ let!(:variant) { create(:variant) }
+ let!(:id) { create(:digital).id }
+ let!(:records_list) { create_list(:digital, 2) }
+
+ let(:valid_create_param_valuex) do
+ create(:digital)
+ end
+
+ let(:valid_create_param_value) do
+ {
+ digital: {
+ variant_id: variant.id.to_s,
+ attachment: image
+ }
+ }
+ end
+
+ let(:valid_update_param_value) do
+ {
+ variant_id: variant.id.to_s,
+ }
+ end
+
+ let(:invalid_param_value) do
+ {
+ variant_id: ''
+ }
+ end
+
+ include_examples 'CRUD examples', resource_name, include_example, filter_example
+end
diff --git a/api/spec/serializers/spree/api/v2/platform/cms_section_serializer_spec.rb b/api/spec/serializers/spree/api/v2/platform/cms_section_serializer_spec.rb
index d4f8f44856..a6a8e3b0c9 100644
--- a/api/spec/serializers/spree/api/v2/platform/cms_section_serializer_spec.rb
+++ b/api/spec/serializers/spree/api/v2/platform/cms_section_serializer_spec.rb
@@ -10,6 +10,9 @@ describe Spree::Api::V2::Platform::CmsSectionSerializer do
it { expect(subject.serializable_hash).to be_kind_of(Hash) }
it do
+ # Reload to get STI in the results.
+ cms_section.reload
+
expect(subject.serializable_hash).to eq(
{
data: {
diff --git a/api/spec/serializers/spree/api/v2/platform/digital_link_serializer_spec.rb b/api/spec/serializers/spree/api/v2/platform/digital_link_serializer_spec.rb
new file mode 100644
index 0000000000..1e109cb16d
--- /dev/null
+++ b/api/spec/serializers/spree/api/v2/platform/digital_link_serializer_spec.rb
@@ -0,0 +1,27 @@
+require 'spec_helper'
+
+describe Spree::Api::V2::Platform::DigitalLinkSerializer do
+ subject { described_class.new(digital_link) }
+
+ let(:digital_link) { create(:digital_link) }
+
+ it { expect(subject.serializable_hash).to be_kind_of(Hash) }
+
+ it do
+ expect(subject.serializable_hash).to eq(
+ {
+ data: {
+ id: digital_link.id.to_s,
+ type: :digital_link,
+ attributes: {
+ access_counter: 0,
+ token: digital_link.token
+ }
+ }
+ }
+ )
+ end
+
+ it { expect(subject.serializable_hash[:data][:id]).to be_kind_of(String) }
+ it { expect(subject.serializable_hash[:data][:type]).to be(:digital_link) }
+end
diff --git a/api/spec/serializers/spree/api/v2/platform/digital_serializer_spec.rb b/api/spec/serializers/spree/api/v2/platform/digital_serializer_spec.rb
new file mode 100644
index 0000000000..edc11d5aa4
--- /dev/null
+++ b/api/spec/serializers/spree/api/v2/platform/digital_serializer_spec.rb
@@ -0,0 +1,30 @@
+require 'spec_helper'
+
+describe Spree::Api::V2::Platform::DigitalSerializer do
+ subject { described_class.new(digital) }
+
+ let(:digital) { create(:digital) }
+
+ it { expect(subject.serializable_hash).to be_kind_of(Hash) }
+
+ it do
+ expect(subject.serializable_hash).to eq(
+ {
+ data: {
+ id: digital.id.to_s,
+ type: :digital,
+ attributes: {
+ byte_size: digital.attachment.byte_size.to_i,
+ content_type: digital.attachment.content_type.to_s,
+ filename: digital.attachment.filename.to_s,
+ url: Rails.application.routes.url_helpers.polymorphic_url(digital.attachment, only_path: true)
+ }
+ }
+ }
+ )
+ end
+
+ it { expect(subject.serializable_hash[:data][:id]).to be_kind_of(String) }
+ it { expect(subject.serializable_hash[:data][:type]).to be(:digital) }
+ it { expect(subject.serializable_hash[:data][:attributes][:url]).to include('thinking-cat.jpg') }
+end
diff --git a/api/spec/serializers/spree/api/v2/platform/store_serializer_spec.rb b/api/spec/serializers/spree/api/v2/platform/store_serializer_spec.rb
index 8761f122cc..7a484dae8d 100644
--- a/api/spec/serializers/spree/api/v2/platform/store_serializer_spec.rb
+++ b/api/spec/serializers/spree/api/v2/platform/store_serializer_spec.rb
@@ -38,7 +38,8 @@ describe Spree::Api::V2::Platform::StoreSerializer do
new_order_notifications_email: store.new_order_notifications_email,
seo_robots: store.seo_robots,
supported_locales: store.supported_locales,
- deleted_at: store.deleted_at
+ deleted_at: store.deleted_at,
+ settings: store.settings
},
relationships: {
default_country: {
diff --git a/api/spec/serializers/spree/api/v2/platform/variant_serializer_spec.rb b/api/spec/serializers/spree/api/v2/platform/variant_serializer_spec.rb
index a56c9641bb..74b440e6b0 100644
--- a/api/spec/serializers/spree/api/v2/platform/variant_serializer_spec.rb
+++ b/api/spec/serializers/spree/api/v2/platform/variant_serializer_spec.rb
@@ -1,11 +1,12 @@
require 'spec_helper'
describe Spree::Api::V2::Platform::VariantSerializer do
- include_context 'API v2 serializers params'
-
subject { described_class.new(variant, params: serializer_params) }
+ include_context 'API v2 serializers params'
+
let!(:variant) { create(:variant, price: 10, compare_at_price: 15, images: create_list(:image, 2), tax_category: create(:tax_category)) }
+ let!(:digital) { create(:digital, variant: variant) }
it { expect(subject.serializable_hash).to be_kind_of(Hash) }
@@ -63,6 +64,14 @@ describe Spree::Api::V2::Platform::VariantSerializer do
}
]
},
+ digitals: {
+ data: [
+ {
+ id: variant.digitals.first.id.to_s,
+ type: :digital
+ }
+ ]
+ },
images: {
data: [
{
diff --git a/api/spec/serializers/spree/v2/storefront/digital_link_serializer.rb b/api/spec/serializers/spree/v2/storefront/digital_link_serializer.rb
new file mode 100644
index 0000000000..3ec984edf2
--- /dev/null
+++ b/api/spec/serializers/spree/v2/storefront/digital_link_serializer.rb
@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+describe Spree::V2::Storefront::DigitalLinkSerializer do
+ subject { described_class.new(digital_link) }
+
+ let(:digital_link) { create(:digital_link) }
+
+ it { expect(subject.serializable_hash).to be_kind_of(Hash) }
+
+ it do
+ expect(subject.serializable_hash).to eq(
+ {
+ data: {
+ id: digital_link.id.to_s,
+ type: :digital_link,
+ attributes: {
+ token: digital_link.token
+ }
+ }
+ }
+ )
+ end
+
+ it { expect(subject.serializable_hash[:data][:id]).to be_kind_of(String) }
+ it { expect(subject.serializable_hash[:data][:type]).to be(:digital_link) }
+end
diff --git a/core/lib/spree/testing_support/factories/digital_factory.rb b/core/lib/spree/testing_support/factories/digital_factory.rb
new file mode 100644
index 0000000000..5c534a544a
--- /dev/null
+++ b/core/lib/spree/testing_support/factories/digital_factory.rb
@@ -0,0 +1,10 @@
+FactoryBot.define do
+ factory :digital, class: Spree::Digital do
+ after(:build) do |digital|
+ digital.attachment.attach(io: File.new("#{Spree::Core::Engine.root}/spec/fixtures/thinking-cat.jpg"),
+ filename: 'thinking-cat.jpg')
+ end
+
+ variant
+ end
+end
diff --git a/core/lib/spree/testing_support/factories/digital_link_factory.rb b/core/lib/spree/testing_support/factories/digital_link_factory.rb
new file mode 100644
index 0000000000..9f9bd4c796
--- /dev/null
+++ b/core/lib/spree/testing_support/factories/digital_link_factory.rb
@@ -0,0 +1,6 @@
+FactoryBot.define do
+ factory :digital_link, class: Spree::DigitalLink do
+ digital
+ line_item
+ end
+end