Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Add deprecation warning when trying to set deprecated preferences (#11611)

Damian Legawiec3102cb67ce8c
diff --git a/api/lib/spree/api/engine.rb b/api/lib/spree/api/engine.rb
index 2b36d4b7f3..a0c9672d6e 100644
--- a/api/lib/spree/api/engine.rb
+++ b/api/lib/spree/api/engine.rb
@@ -18,13 +18,6 @@ module Spree
Migrations.new(config, engine_name).check
end
- initializer 'spree.api.checking_deprecated_preferences' do
- Spree::Api::Config.deprecated_preferences.each do |pref|
- # FIXME: we should only notify about deprecated preferences that are in use, not all of them
- # warn "[DEPRECATION] Spree::Api::Config[:#{pref[:name]}] is deprecated. #{pref[:message]}"
- end
- end
-
def self.activate
Dir.glob(File.join(File.dirname(__FILE__), '../../../app/models/spree/api/webhooks/*_decorator*.rb')) do |c|
Rails.application.config.cache_classes ? require(c) : load(c)
diff --git a/core/lib/spree/core/engine.rb b/core/lib/spree/core/engine.rb
index b85f2cc62a..087ef62c44 100644
--- a/core/lib/spree/core/engine.rb
+++ b/core/lib/spree/core/engine.rb
@@ -143,13 +143,6 @@ module Spree
Migrations.new(config, engine_name).check
end
- initializer 'spree.core.checking_deprecated_preferences' do
- Spree::Config.deprecated_preferences.each do |pref|
- # FIXME: we should only notify about deprecated preferences that are in use, not all of them
- # warn "[DEPRECATION] Spree::Config[:#{pref[:name]}] is deprecated. #{pref[:message]}"
- end
- end
-
config.to_prepare do
# Ensure spree locale paths are present before decorators
I18n.load_path.unshift(*(Dir.glob(
diff --git a/core/lib/spree/core/preferences/preferable_class_methods.rb b/core/lib/spree/core/preferences/preferable_class_methods.rb
index c66d80c8e3..cc1385b528 100644
--- a/core/lib/spree/core/preferences/preferable_class_methods.rb
+++ b/core/lib/spree/core/preferences/preferable_class_methods.rb
@@ -19,6 +19,8 @@ module Spree::Preferences
value = convert_preference_value(value, type)
preferences[name] = value
+ ActiveSupport::Deprecation.warn("`#{name}` is deprecated. #{deprecated}") if deprecated
+
# If this is an activerecord object, we need to inform
# ActiveRecord::Dirty that this value has changed, since this is an
# in-place update to the preferences hash.