Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Give a store back its default tax category when seeding again

Łukasz Adamczyk32c2f1ae0392
diff --git a/spree/core/app/services/spree/seeds/tax_categories.rb b/spree/core/app/services/spree/seeds/tax_categories.rb
index fe45a9277a..62c80a8ede 100644
--- a/spree/core/app/services/spree/seeds/tax_categories.rb
+++ b/spree/core/app/services/spree/seeds/tax_categories.rb
@@ -5,9 +5,12 @@ module Spree
def call
Spree::Store.find_each do |store|
- store.tax_categories.find_or_create_by!(name: 'Default') do |tax_category|
- tax_category.is_default = true
- end
+ # The block form only runs on create, so a store that already had a
+ # "Default" category with the flag unset kept no default at all — and
+ # the default is what taxes an item carrying no category of its own.
+ default = store.tax_categories.find_or_create_by!(name: 'Default')
+ default.update!(is_default: true) unless default.is_default?
+
store.tax_categories.find_or_create_by!(name: 'Non-taxable')
end
end
diff --git a/spree/core/spec/services/spree/seeds/tax_categories_spec.rb b/spree/core/spec/services/spree/seeds/tax_categories_spec.rb
index 2901b0314a..6348d8a17f 100644
--- a/spree/core/spec/services/spree/seeds/tax_categories_spec.rb
+++ b/spree/core/spec/services/spree/seeds/tax_categories_spec.rb
@@ -34,13 +34,26 @@ RSpec.describe Spree::Seeds::TaxCategories do
context 'when TaxCategories already exist' do
before do
expected_categories.each do |category_attrs|
- @default_store.tax_categories.create!(name: category_attrs[:name], is_default: category_attrs[:is_default])
+ create(:tax_category, store: @default_store, name: category_attrs[:name],
+ is_default: category_attrs[:is_default])
end
end
it "doesn't create new TaxCategories" do
expect { subject }.not_to change(Spree::TaxCategory, :count)
end
+
+ # find_or_create_by! runs its block only on create, so seeding a store that
+ # already had a Default category left it without a default — and the
+ # default is what taxes an item carrying no category of its own.
+ it 'marks an existing Default category as the default' do
+ Spree::TaxCategory.where(store: @default_store, name: 'Default').
+ update_all(is_default: false)
+
+ subject
+
+ expect(Spree::TaxCategory.default(@default_store)&.name).to eq('Default')
+ end
end
end
end