Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

FIX update payment intents for gift cards (#13142)

brozek3ebbb8a46f35
diff --git a/core/app/services/spree/gift_cards/apply.rb b/core/app/services/spree/gift_cards/apply.rb
index 5b1e795779..393814ee6c 100644
--- a/core/app/services/spree/gift_cards/apply.rb
+++ b/core/app/services/spree/gift_cards/apply.rb
@@ -44,6 +44,7 @@ module Spree
state: 'checkout',
response_code: store_credit.generate_authorization_code
)
+ order.update_with_updater!
end
success(order.reload)
diff --git a/core/app/services/spree/gift_cards/remove.rb b/core/app/services/spree/gift_cards/remove.rb
index a79b7f61e0..86ed7f1c1d 100644
--- a/core/app/services/spree/gift_cards/remove.rb
+++ b/core/app/services/spree/gift_cards/remove.rb
@@ -29,6 +29,7 @@ module Spree
end
order.update!(gift_card: nil)
+ order.update_with_updater!
end
success(true)
diff --git a/core/spec/services/spree/gift_cards/apply_spec.rb b/core/spec/services/spree/gift_cards/apply_spec.rb
index 6127224e03..fa9a0d3004 100644
--- a/core/spec/services/spree/gift_cards/apply_spec.rb
+++ b/core/spec/services/spree/gift_cards/apply_spec.rb
@@ -35,6 +35,11 @@ RSpec.describe Spree::GiftCards::Apply do
expect(store_credit.originator).to eq(gift_card)
end
+ it 'calls update_with_updater!' do
+ expect(order).to receive(:update_with_updater!)
+ subject
+ end
+
context 'when the order has applied store credit' do
let!(:store_credit_payment_method) { create(:store_credit_payment_method, stores: [store]) }
let!(:store_credit) { create(:store_credit, user: order.user, amount: 10, store: store) }
diff --git a/core/spec/services/spree/gift_cards/remove_spec.rb b/core/spec/services/spree/gift_cards/remove_spec.rb
index 2c84ac4e3e..5cb8c2e1a2 100644
--- a/core/spec/services/spree/gift_cards/remove_spec.rb
+++ b/core/spec/services/spree/gift_cards/remove_spec.rb
@@ -39,6 +39,11 @@ RSpec.describe Spree::GiftCards::Remove do
expect(store_credit_payment.source).to be_deleted
end
+ it 'calls update_with_updater!' do
+ expect(order).to receive(:update_with_updater!)
+ subject
+ end
+
context 'for a completed order' do
before { order.update_column(:completed_at, Time.current) }