Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fixed store switching based an URL + added a lot of regression tests for storefront and API

Damian Legawiec3efacffa2562
diff --git a/api/spec/requests/spree/api/v2/store_spec.rb b/api/spec/requests/spree/api/v2/store_spec.rb
new file mode 100644
index 0000000000..a4c84c650a
--- /dev/null
+++ b/api/spec/requests/spree/api/v2/store_spec.rb
@@ -0,0 +1,43 @@
+require 'spec_helper'
+
+describe 'API v2 Store Switching spec', type: :request do
+ let!(:store) { Spree::Store.default }
+ let!(:another_store) { create(:store, url: 'another-store.lvh.me', name: 'Another Store') }
+
+ let!(:product) { create(:product, stores: [store]) }
+ let!(:another_product) { create(:product, stores: [another_store]) }
+
+ context 'existing store found' do
+ before { host!('another-store.lvh.me') }
+
+ context 'product associated with store' do
+ before { get "/api/v2/storefront/products/#{another_product.slug}" }
+
+ it_behaves_like 'returns 200 HTTP status'
+ end
+
+ context 'product not associated with store' do
+ before { get "/api/v2/storefront/products/#{product.slug}" }
+
+ it_behaves_like 'returns 404 HTTP status'
+ end
+ end
+
+ context 'non-existing store' do
+ before { host!('missing-store.lvh.me') }
+
+ context 'fallbacks to the default store' do
+ context 'product associated with store' do
+ before { get "/api/v2/storefront/products/#{product.slug}" }
+
+ it_behaves_like 'returns 200 HTTP status'
+ end
+
+ context 'product not associated with store' do
+ before { get "/api/v2/storefront/products/#{another_product.slug}" }
+
+ it_behaves_like 'returns 404 HTTP status'
+ end
+ end
+ end
+end
diff --git a/core/lib/spree/core/controller_helpers/store.rb b/core/lib/spree/core/controller_helpers/store.rb
index 46092a3731..08835d264e 100644
--- a/core/lib/spree/core/controller_helpers/store.rb
+++ b/core/lib/spree/core/controller_helpers/store.rb
@@ -11,7 +11,7 @@ module Spree
end
def current_store
- @current_store ||= current_store_finder.new(url: request.env['HTTP_SERVER_NAME']).execute
+ @current_store ||= current_store_finder.new(url: request.env['SERVER_NAME']).execute
end
def available_menus
diff --git a/core/lib/spree/testing_support/capybara_config.rb b/core/lib/spree/testing_support/capybara_config.rb
index c1dd06ee82..c043e62ead 100644
--- a/core/lib/spree/testing_support/capybara_config.rb
+++ b/core/lib/spree/testing_support/capybara_config.rb
@@ -24,3 +24,5 @@ else
end
Capybara.default_max_wait_time = 45
Capybara.server = :puma
+
+Capybara.always_include_port = true
diff --git a/core/spec/lib/spree/core/controller_helpers/store_spec.rb b/core/spec/lib/spree/core/controller_helpers/store_spec.rb
index f618058fa9..3d372896aa 100644
--- a/core/spec/lib/spree/core/controller_helpers/store_spec.rb
+++ b/core/spec/lib/spree/core/controller_helpers/store_spec.rb
@@ -24,7 +24,7 @@ describe Spree::Core::ControllerHelpers::Store, type: :controller do
context 'by domain' do
before do
- controller.request.env['HTTP_SERVER_NAME'] = 'another.com'
+ controller.request.env['SERVER_NAME'] = 'another.com'
end
it 'returns current store' do
@@ -36,7 +36,7 @@ describe Spree::Core::ControllerHelpers::Store, type: :controller do
let!(:store_3) { create :store, url: 'some.another.com' }
before do
- controller.request.env['HTTP_SERVER_NAME'] = 'some.another.com'
+ controller.request.env['SERVER_NAME'] = 'some.another.com'
end
it 'returns current store' do
diff --git a/frontend/spec/features/store_spec.rb b/frontend/spec/features/store_spec.rb
index a791d0c334..c79ff6e285 100644
--- a/frontend/spec/features/store_spec.rb
+++ b/frontend/spec/features/store_spec.rb
@@ -1,7 +1,7 @@
require 'spec_helper'
-describe 'Store', type: :feature, js: true do
- context 'stores footer info is shown in footer' do
+describe 'Store', type: :feature do
+ context 'stores footer info is shown in footer', js: true do
before do
create(:store, default: true, description: 'This is store description', address: 'Address street 123, City 123', contact_phone: '123123123', customer_support_email: '[email protected]')
@@ -17,4 +17,31 @@ describe 'Store', type: :feature, js: true do
end
end
end
+
+ context 'store switchinng based on url' do
+ let!(:store) { Spree::Store.default }
+ let!(:another_store) { create(:store, url: 'another-store.lvh.me', name: 'Another Store') }
+
+ context 'existing store found' do
+ before do
+ Capybara.app_host = 'http://another-store.lvh.me'
+ visit spree.root_path
+ end
+
+ after { Capybara.app_host = nil }
+
+ it { expect(page).to have_content(another_store.name) }
+ end
+
+ context 'non-existing store fallbacks to the default store' do
+ before do
+ Capybara.app_host = 'http://wrong-store.lvh.me'
+ visit spree.root_path
+ end
+
+ after { Capybara.app_host = nil }
+
+ it { expect(page).to have_content(store.name) }
+ end
+ end
end