Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

FIX create account service (#13188)

brozek3fbce99d7aff
diff --git a/core/app/services/spree/orders/create_user_account.rb b/core/app/services/spree/orders/create_user_account.rb
index 590967fdc1..af49acfe35 100644
--- a/core/app/services/spree/orders/create_user_account.rb
+++ b/core/app/services/spree/orders/create_user_account.rb
@@ -7,7 +7,11 @@ module Spree
def call(order:, accepts_email_marketing: false)
existing_user = Spree.user_class.find_by(email: order.email)
- return existing_user if existing_user.present?
+ if existing_user.present?
+ order.update_columns(user_id: existing_user.id, updated_at: Time.current)
+ order.user = existing_user
+ return success(existing_user)
+ end
user = create_new_user(order, accepts_email_marketing)
return failure(:user_creation_failed) unless user.persisted?
diff --git a/core/spec/services/spree/orders/create_user_account_spec.rb b/core/spec/services/spree/orders/create_user_account_spec.rb
index 6d2a066c40..3d8131226d 100644
--- a/core/spec/services/spree/orders/create_user_account_spec.rb
+++ b/core/spec/services/spree/orders/create_user_account_spec.rb
@@ -44,5 +44,15 @@ describe Spree::Orders::CreateUserAccount do
it 'does not create a new user' do
expect { subject }.to change { Spree.user_class.count }.by(0)
end
+
+ it 'assigns the user to the order' do
+ subject
+ expect(order.reload.user).to eq(user)
+ end
+
+ it 'returns success with the user' do
+ expect(subject).to be_success
+ expect(subject.value).to eq(user)
+ end
end
end