Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Assert that a generic write needs a documented request body
Damian Legawiec4033022bc80b
diff --git a/spree/api/spec/lib/spree/api/agent_tools_contract_spec.rb b/spree/api/spec/lib/spree/api/agent_tools_contract_spec.rbindex f2063b9bc0..382128aab2 100644--- a/spree/api/spec/lib/spree/api/agent_tools_contract_spec.rb+++ b/spree/api/spec/lib/spree/api/agent_tools_contract_spec.rb@@ -263,6 +263,19 @@ RSpec.describe 'agent tool contract' doendend+ # The real guard on generic writes is the OpenAPI document, not the+ # hand-written exclusion list: a resource the Admin API does not document a+ # write body for cannot become writable, whether or not anyone remembered+ # to list it. Asserting that keeps the list belt-and-braces rather than the+ # sole defence — a new service-written controller is refused by default.+ it 'writes only what the Admin API documents a write body for' do+ undocumented = Spree::AgentTools::ResourceMap.all.select(&:generic_writes?).reject do |entry|+ Spree::Api::AgentWriteSchemas.attribute_names(entry.key).any?+ end++ expect(undocumented.map(&:key)).to be_empty+ end+it 'scopes every registered resource to a store' dounscoped = Spree::AgentTools::ResourceMap.all.reject(&:store_scoped?)