Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fix missing translation in tests.

Matthew Kennedy409d4d73496d
diff --git a/backend/spec/features/admin/cms_pages/edit_feature_page_spec.rb b/backend/spec/features/admin/cms_pages/edit_feature_page_spec.rb
index 7c0a8638a1..5aca0f56f1 100644
--- a/backend/spec/features/admin/cms_pages/edit_feature_page_spec.rb
+++ b/backend/spec/features/admin/cms_pages/edit_feature_page_spec.rb
@@ -7,6 +7,12 @@ describe 'Edit Feature Page', type: :feature do
let!(:store_1) { create(:store) }
before do
+ I18n.backend.store_translations(:fr,
+ spree: {
+ i18n: {
+ this_file_language: 'Français (FR)'
+ }
+ })
visit spree.new_admin_cms_page_path
fill_in 'Title *', with: 'Homepage (English)'
select 'Feature Page', from: 'cms_page[type]'
@@ -48,12 +54,11 @@ describe 'Edit Feature Page', type: :feature do
it 'allows user to switch language', js: true do
find('[aria-controls="collapsePageSettings"]').click
- select2 'fr', from: 'Language'
+ select2 'Français (FR)', from: 'Language'
click_on 'Update'
- # TODO: Not the best translation ever.
- expect(page).to have_text('This File Language')
+ expect(page).to have_text('Français (FR)')
end
end
end
diff --git a/backend/spec/features/admin/cms_pages/edit_homepage_spec.rb b/backend/spec/features/admin/cms_pages/edit_homepage_spec.rb
index c6d908e773..1c247b5722 100644
--- a/backend/spec/features/admin/cms_pages/edit_homepage_spec.rb
+++ b/backend/spec/features/admin/cms_pages/edit_homepage_spec.rb
@@ -7,7 +7,15 @@ describe 'Edit Homepage', type: :feature do
let!(:store_1) { create(:store) }
before do
+ I18n.backend.store_translations(:fr,
+ spree: {
+ i18n: {
+ this_file_language: 'Français (FR)'
+ }
+ })
+
visit spree.new_admin_cms_page_path
+
fill_in 'Title *', with: 'Homepage (English)'
select 'Homepage', from: 'cms_page[type]'
@@ -48,12 +56,11 @@ describe 'Edit Homepage', type: :feature do
it 'allows user to switch language', js: true do
find('[aria-controls="collapsePageSettings"]').click
- select2 'fr', from: 'Language'
+ select2 'Français (FR)', from: 'Language'
click_on 'Update'
- # TODO: Not the best translation ever.
- expect(page).to have_text('This File Language')
+ expect(page).to have_text('Français (FR)')
end
end
end
diff --git a/backend/spec/features/admin/cms_pages/edit_standard_page_spec.rb b/backend/spec/features/admin/cms_pages/edit_standard_page_spec.rb
index f08081843a..909d78ab34 100644
--- a/backend/spec/features/admin/cms_pages/edit_standard_page_spec.rb
+++ b/backend/spec/features/admin/cms_pages/edit_standard_page_spec.rb
@@ -8,6 +8,12 @@ describe 'Edit Standard Page', type: :feature do
before do
visit spree.new_admin_cms_page_path
+ I18n.backend.store_translations(:fr,
+ spree: {
+ i18n: {
+ this_file_language: 'Français (FR)'
+ }
+ })
fill_in 'Title *', with: 'Privacy Policy'
fill_in 'Meta Title', with: 'Meta-T-Content'
@@ -38,12 +44,11 @@ describe 'Edit Standard Page', type: :feature do
it 'allows user to switch language', js: true do
find('[aria-controls="collapsePageSettings"]').click
- select2 'fr', from: 'Language'
+ select2 'Français (FR)', from: 'Language'
click_on 'Update'
- # TODO: Not the best translation ever.
- expect(page).to have_text('This File Language')
+ expect(page).to have_text('Français (FR)')
end
it 'allows user to toggle visability', js: true do