Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fixed setting store when creating payment methods in admin

Damian Legawiec41174c06c982
diff --git a/backend/app/controllers/spree/admin/payment_methods_controller.rb b/backend/app/controllers/spree/admin/payment_methods_controller.rb
index 1268acd22d..fbced3e4ee 100644
--- a/backend/app/controllers/spree/admin/payment_methods_controller.rb
+++ b/backend/app/controllers/spree/admin/payment_methods_controller.rb
@@ -10,6 +10,7 @@ module Spree
def create
@payment_method = params[:payment_method].delete(:type).constantize.new(payment_method_params)
@object = @payment_method
+ set_store
invoke_callbacks(:create, :before)
if @payment_method.save
invoke_callbacks(:create, :after)
diff --git a/backend/spec/controllers/spree/admin/payment_methods_controller_spec.rb b/backend/spec/controllers/spree/admin/payment_methods_controller_spec.rb
index bf546d1f8e..ef84e86dd0 100644
--- a/backend/spec/controllers/spree/admin/payment_methods_controller_spec.rb
+++ b/backend/spec/controllers/spree/admin/payment_methods_controller_spec.rb
@@ -8,7 +8,8 @@ module Spree
describe Admin::PaymentMethodsController, type: :controller do
stub_authorization!
- let(:payment_method) { GatewayWithPassword.create!(name: 'Bogus', preferred_password: 'haxme') }
+ let(:store) { Spree::Store.default }
+ let(:payment_method) { GatewayWithPassword.create!(name: 'Bogus', preferred_password: 'haxme', stores: [store]) }
# regression test for #2094
it 'does not clear password on update' do
@@ -49,6 +50,8 @@ module Spree
post :create, params: { payment_method: { name: 'Test Method', type: 'Spree::Gateway::Bogus' } }
end.to change(Spree::PaymentMethod, :count).by(1)
+ expect(Spree::PaymentMethod.last.stores).to eq([store])
+
expect(response).to be_redirect
expect(response).to redirect_to spree.edit_admin_payment_method_path(assigns(:payment_method))
end