Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fixed `TableHelper#session_selected_columns`

Damian Legawiec425ff017c433
diff --git a/admin/app/helpers/spree/admin/table_helper.rb b/admin/app/helpers/spree/admin/table_helper.rb
index 65f86b1e53..f36d7a5635 100644
--- a/admin/app/helpers/spree/admin/table_helper.rb
+++ b/admin/app/helpers/spree/admin/table_helper.rb
@@ -24,12 +24,12 @@ module Spree
# Get selected column keys from session
# @param table_key [Symbol] table key
- # @return [Array<Symbol>, nil]
+ # @return [Array<String>, nil]
def session_selected_columns(table_key)
keys = session["table_columns_#{table_key}"]
return nil if keys.blank?
- keys.split(',').map(&:to_sym)
+ keys.split(',')
end
# Render a single column value based on its type
diff --git a/admin/spec/helpers/spree/admin/table_helper_spec.rb b/admin/spec/helpers/spree/admin/table_helper_spec.rb
index 50472eefa4..30f9efa4ae 100644
--- a/admin/spec/helpers/spree/admin/table_helper_spec.rb
+++ b/admin/spec/helpers/spree/admin/table_helper_spec.rb
@@ -16,12 +16,12 @@ RSpec.describe Spree::Admin::TableHelper, type: :helper do
expect(helper.session_selected_columns(:products)).to be_nil
end
- it 'returns array of symbols when columns are in session' do
+ it 'returns array of strings when columns are in session' do
session['table_columns_products'] = 'name,price,status'
result = helper.session_selected_columns(:products)
- expect(result).to eq([:name, :price, :status])
+ expect(result).to eq(%w[name price status])
end
it 'returns nil for empty string' do