Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Permit admin_name on stock location strong params (#14279)

Łukasz Adamczyk4512d4845bfa
diff --git a/spree/admin/spec/controllers/spree/admin/stock_locations_controller_spec.rb b/spree/admin/spec/controllers/spree/admin/stock_locations_controller_spec.rb
index 095a156640..660e9a8b77 100644
--- a/spree/admin/spec/controllers/spree/admin/stock_locations_controller_spec.rb
+++ b/spree/admin/spec/controllers/spree/admin/stock_locations_controller_spec.rb
@@ -31,6 +31,7 @@ RSpec.describe Spree::Admin::StockLocationsController, type: :controller do
let(:stock_location_params) do
{
name: 'Main Warehouse',
+ admin_name: 'Internal Warehouse',
address1: '123 Main St',
city: 'Portland',
zipcode: '97210',
@@ -48,6 +49,7 @@ RSpec.describe Spree::Admin::StockLocationsController, type: :controller do
expect(stock_location).to be_persisted
expect(stock_location.name).to eq('Main Warehouse')
+ expect(stock_location.admin_name).to eq('Internal Warehouse')
expect(stock_location.address1).to eq('123 Main St')
expect(stock_location.city).to eq('Portland')
end
@@ -68,10 +70,11 @@ RSpec.describe Spree::Admin::StockLocationsController, type: :controller do
let!(:stock_location) { create(:stock_location, name: 'Main Warehouse') }
it 'updates the stock location' do
- put :update, params: { id: stock_location.to_param, stock_location: { name: 'New Warehouse' } }
+ put :update, params: { id: stock_location.to_param, stock_location: { name: 'New Warehouse', admin_name: 'Internal Warehouse' } }
expect(response).to redirect_to(spree.edit_admin_stock_location_path(stock_location))
expect(stock_location.reload.name).to eq('New Warehouse')
+ expect(stock_location.admin_name).to eq('Internal Warehouse')
end
end
diff --git a/spree/core/lib/spree/permitted_attributes.rb b/spree/core/lib/spree/permitted_attributes.rb
index 26302aa787..6bf9e8986b 100644
--- a/spree/core/lib/spree/permitted_attributes.rb
+++ b/spree/core/lib/spree/permitted_attributes.rb
@@ -257,7 +257,7 @@ module Spree
@@stock_item_attributes = [:variant_id, :stock_location_id, :backorderable, :count_on_hand, { metadata: {} }]
@@stock_location_attributes = [
- :name, :active, :address1, :address2, :city, :zipcode, :company,
+ :name, :admin_name, :active, :address1, :address2, :city, :zipcode, :company,
:backorderable_default, :state_name, :state_id, :country_id, :phone,
:propagate_all_variants
]