Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Fix code reviews.
Matthew Kennedy460bd610de23
diff --git a/backend/app/helpers/spree/admin/base_helper.rb b/backend/app/helpers/spree/admin/base_helper.rbindex fec3072ee1..250cd0cedb 100644--- a/backend/app/helpers/spree/admin/base_helper.rb+++ b/backend/app/helpers/spree/admin/base_helper.rb@@ -218,16 +218,6 @@ module Spreeendend- def stores_formatted_for_select- formatted_stores = []-- @stores.each do |store|- formatted_stores << ["#{store.name} (#{store.code})", store.id]- end-- formatted_stores- end-def select2_local_fallbackstripped_locale = I18n.locale.to_s.split('-').firstdiff --git a/backend/app/helpers/spree/admin/stores_helper.rb b/backend/app/helpers/spree/admin/stores_helper.rbindex 72c64e4a8d..6ee8cfe9eb 100644--- a/backend/app/helpers/spree/admin/stores_helper.rb+++ b/backend/app/helpers/spree/admin/stores_helper.rb@@ -4,6 +4,14 @@ module Spreedef selected_checkout_zone(store)store&.checkout_zone || Spree::Zone.default_checkout_zoneend++ def stores_formatted_for_select+ formatted_stores = []++ @stores.map { |store| formatted_stores << [store.unique_name, store.id] }++ formatted_stores+ endendendenddiff --git a/backend/spec/features/admin/menus/index_menu_spec.rb b/backend/spec/features/admin/menus/index_menu_spec.rbindex ad5ae0459d..033d0be86b 100644--- a/backend/spec/features/admin/menus/index_menu_spec.rb+++ b/backend/spec/features/admin/menus/index_menu_spec.rb@@ -14,10 +14,10 @@ describe 'Menus Index', type: :feature doendcontext 'when menus are present' do- let!(:store_1) { create(:store, name: 'AbCd') }- let!(:store_2) { create(:store, name: 'EfGh') }- let!(:store_3) { create(:store, name: 'IjKl') }- let!(:store_4) { create(:store, name: 'MnOp') }+ let!(:store_1) { create(:store) }+ let!(:store_2) { create(:store) }+ let!(:store_3) { create(:store) }+ let!(:store_4) { create(:store) }let!(:main_menu) { create(:menu, name: 'Main Menu', store_id: store_1.id) }let!(:main_menu_fr) { create(:menu, name: 'Main Menu FR', store_id: store_1.id, locale: 'fr') }@@ -33,7 +33,7 @@ describe 'Menus Index', type: :feature dovisit spree.admin_menus_pathend- it 'lists each menu with its store ' do+ it 'lists each menu with stores' dowithin_table('menusTable') doexpect(page).to have_text 'Main Menu'expect(page).to have_text 'Footer Menu'@@ -56,7 +56,7 @@ describe 'Menus Index', type: :feature doexpect(page).not_to have_css('.translation_missing', visible: :all)end- describe 'when filtering menus', js: true do+ describe 'when filtering', js: true doit 'is able to filter by name' doclick_on 'Filter'fill_in 'Name', with: 'Main Menu FR'@@ -75,7 +75,7 @@ describe 'Menus Index', type: :feature doexpect(page).not_to have_text 'Footer Menu'end- it 'is able to filter by menu location' do+ it 'is able to filter by location' doclick_on 'Filter'select2 'Footer', from: 'Location'click_on 'Search'