Skip to content

armgit / spree

Public Imported from GitHub
0

Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.

Fix: email fulfillment group items were typed as a single item

Damian Legawiec4910a7c412aa
diff --git a/packages/admin-sdk/src/types/generated/emails/EmailFulfillmentGroup.ts b/packages/admin-sdk/src/types/generated/emails/EmailFulfillmentGroup.ts
index 72f07c1dc8..f92f4f0240 100644
--- a/packages/admin-sdk/src/types/generated/emails/EmailFulfillmentGroup.ts
+++ b/packages/admin-sdk/src/types/generated/emails/EmailFulfillmentGroup.ts
@@ -1,4 +1,4 @@
-// Typelizer digest 7416b03c2741fd7774b1bc35b93f3b49
+// Typelizer digest 1ac70b65123bd8028d5f98ae3c2cad09
//
// DO NOT MODIFY: This file was automatically generated by Typelizer.
import type {EmailParcelItem} from '.'
@@ -7,7 +7,7 @@ interface EmailFulfillmentGroup {
name: string | null;
display_cost: string;
seller_names: Array<string>;
- items: EmailParcelItem;
+ items: Array<EmailParcelItem>;
}
export default EmailFulfillmentGroup;
diff --git a/packages/admin-sdk/src/zod/generated/emails/EmailFulfillmentGroup.ts b/packages/admin-sdk/src/zod/generated/emails/EmailFulfillmentGroup.ts
index 165ec61384..6743673112 100644
--- a/packages/admin-sdk/src/zod/generated/emails/EmailFulfillmentGroup.ts
+++ b/packages/admin-sdk/src/zod/generated/emails/EmailFulfillmentGroup.ts
@@ -6,7 +6,7 @@ export const EmailFulfillmentGroupSchema = z.object({
name: z.string().nullable(),
display_cost: z.string(),
seller_names: z.array(z.string()),
- items: EmailParcelItemSchema,
+ items: z.array(EmailParcelItemSchema),
});
export type EmailFulfillmentGroup = z.infer<typeof EmailFulfillmentGroupSchema>;
diff --git a/spree/emails/config/initializers/typelizer.rb b/spree/emails/config/initializers/typelizer.rb
index 627152c73c..7d3699bcbb 100644
--- a/spree/emails/config/initializers/typelizer.rb
+++ b/spree/emails/config/initializers/typelizer.rb
@@ -14,7 +14,10 @@ Rails.application.config.after_initialize do
Spree::Emails::AmountLineSerializer.typelize(label: [:string, nullable: true], amount: :string, display_amount: :string)
Spree::Emails::FulfillmentGroupSerializer.typelize(name: [:string, nullable: true], display_cost: :string,
- seller_names: [:string, multi: true])
+ seller_names: [:string, multi: true],
+ # Declared before Typelizer's hooks were attached, so it
+ # cannot tell this association is a list.
+ items: [:EmailParcelItem, multi: true])
Spree::Emails::ParcelItemSerializer.typelize(
id: :string, name: :string, quantity: :number, sku: [:string, nullable: true], options_text: [:string, nullable: true],
display_price: :string, display_amount: :string, url: [:string, nullable: true], image_url: [:string, nullable: true]