Open Source Platform for DTC, B2B Commerce, Marketplaces & Omnichannel. REST APIs, TypeScript SDKs, and production-ready Next.js storefront. Self-host it. Own your data. No vendor lock-in. Zero platform fees.
Ruby b2b-commercee-commerceecommerceecommerce-apiecommerce-frameworkecommerce-platformheadlessheadless-commerceheadless-ecommercemarketplacemulti-tenantmulti-vendormulti-vendor-ecommerceopen-sourcespree-commerce
Do not return other users credit cards for admin user
Szymon Iwacz4d477bd489a2
diff --git a/api/app/controllers/spree/api/v2/storefront/account/credit_cards_controller.rb b/api/app/controllers/spree/api/v2/storefront/account/credit_cards_controller.rbindex 6a7c42b3ab..4fdbf64add 100644--- a/api/app/controllers/spree/api/v2/storefront/account/credit_cards_controller.rb+++ b/api/app/controllers/spree/api/v2/storefront/account/credit_cards_controller.rb@@ -12,6 +12,10 @@ module SpreeSpree::CreditCardend+ def scope+ super.where(user: spree_current_user)+ end+def collection_serializerSpree::Api::Dependencies.storefront_credit_card_serializer.constantizeenddiff --git a/api/spec/requests/spree/api/v2/storefront/account/credit_cards_spec.rb b/api/spec/requests/spree/api/v2/storefront/account/credit_cards_spec.rbindex 31abc3d8da..b9856cb497 100644--- a/api/spec/requests/spree/api/v2/storefront/account/credit_cards_spec.rb+++ b/api/spec/requests/spree/api/v2/storefront/account/credit_cards_spec.rb@@ -47,6 +47,20 @@ describe 'Storefront API v2 CreditCards spec', type: :request doit_behaves_like 'returns 403 HTTP status'end++ context 'when user has admin privileges' do+ let!(:user) { create(:admin_user) }+ let!(:new_user) { create(:user) }+ let!(:new_credit_card) { create(:credit_card, user_id: new_user.id, last_digits: '2222') }++ before { get '/api/v2/storefront/account/credit_cards', headers: headers_bearer }++ it 'should return user credit cards only' do+ expect(json_response['data'][0]).to have_type('credit_card')+ expect(json_response['data'].size).to eq(credit_cards.count)+ expect(json_response['data'].map { |card| card['attributes']['last_digits'] }).not_to include(new_credit_card.last_digits)+ end+ endenddescribe 'credit_cards#show' do